From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110296 invoked by alias); 18 Oct 2018 01:31:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110284 invoked by uid 89); 18 Oct 2018 01:31:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,SPF_PASS autolearn=ham version=3.3.2 spammy=redirect, disconnected X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Oct 2018 01:31:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1539826270; x=1542418270; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7eNuOqK+lpR5REjpcFhh7mocwY7pWZhA6IAUboaGecg=; b=T0st81aFaQ/HFf8hgk7f7KHXso84ZjbKNidoedZuZgwmQQeUHfUg6Tsek4sjYuEX HYTnn9ogatT4ZyMrentJoRTdoh7zkJ1Sgz4k4eqQouaxejpXbrPXRWfSwMhlyFLC wDqsjcpSTYXnDSNiNFwFG2K9AdCGaSCFNd2KkUx6P/A=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id AA.C5.18386.E52E7CB5; Thu, 18 Oct 2018 03:31:10 +0200 (CEST) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 18 Oct 2018 03:31:06 +0200 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 18 Oct 2018 03:31:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7eNuOqK+lpR5REjpcFhh7mocwY7pWZhA6IAUboaGecg=; b=Hz+IJ3ofklRSZcyAiUyHCY0M4YtP+sC2B39hmZRhLOcJJiqYsrup58qwfjwe0Zt8hse6m+/MXxiaPUEGZ58DOc3CTE9UdCfPLP+dBK4sftLimTv1SvtlpWnWyzu27xmUl7FnH45Q5nM3x+FdN7hFxrmK4ZbGnptyG2K8SC4EwBQ= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2326.namprd15.prod.outlook.com (52.135.197.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.31; Thu, 18 Oct 2018 01:31:03 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::619e:2dbd:180c:a2fb%5]) with mapi id 15.20.1228.027; Thu, 18 Oct 2018 01:31:03 +0000 From: Simon Marchi To: Jan Vrany , "gdb-patches@sourceware.org" Subject: Re: [RFC 2/2] gdb/mi: add new async events =target-connected and =target-disconnected Date: Thu, 18 Oct 2018 01:31:00 -0000 Message-ID: <771a41a2-15e9-e8a6-ef66-767d4277a08d@ericsson.com> References: <20181014125534.11724-1-jan.vrany@fit.cvut.cz> <20181014125534.11724-3-jan.vrany@fit.cvut.cz> In-Reply-To: <20181014125534.11724-3-jan.vrany@fit.cvut.cz> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <432F9C047333EB48A94F0BAB8008DB10@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00389.txt.bz2 T24gMjAxOC0xMC0xNCA4OjU1IGEubS4sIEphbiBWcmFueSB3cm90ZToNCj4g V2hlbmV2ZXIgYSB0YXJnZXQgaXMgY29ubmVjdGVkIG9yIGRpc2Nvbm5lY3Rl ZCwgZW1pdCBuZXcgYXN5bmNocm9ub3VzDQo+IGV2ZW50ID10YXJnZXQtY29u bmVjdGVkIGFuZCA9dGFyZ2V0LWRpc2Nvbm5lY3RlZC4gRXZlbnRzIHJlcG9y dA0KPiBib3RoIHNob3J0IG5hbWUgYW5kIGZ1bGwgbmFtZSBvZiBjb25uZWN0 ZWQgb3IgZGlzY29ubmVjdGVkIHRhcmdldC4NCj4gSW4gYWRkaXRpb24sID10 YXJnZXQtY29ubmVjdGVkIHJlcG9ydCBhIHNldCBvZiB0YXJnZXQgZmVhdHVy ZXMuDQo+IA0KPiBUaGlzIGFsbG93cyBmcm9udGVuZHMgdG8ga2VlcCB0cmFj ayBvZiBjdXJyZW50IHRhcmdldCBhbmQgaXRzIGZlYXR1cmVzDQo+IHJlZ2Fy ZGxlc3Mgd2hldGhlciB0YXJnZXQgaXMgY2hhbmdlZCBleHBsaWNpdGx5IGJ5 IE1JIC10YXJnZXQtc2VsZWN0DQo+IGNvbW1hbmQsIENMSSB0YXJnZXQgY29t bWFuZCBvciBpbXBsaWNpdGx5IGJ5ICBuYXRpdmUgdGFyZ2V0IGF1dG8tY29u bmVjdC4NCg0KVGhhbmtzLCBJIGxpa2UgdGhlIGlkZWEuICBBIG5vbi1SRkMg dmVyc2lvbiBvZiB0aGlzIHdvdWxkIHJlcXVpcmUgY29ycmVzcG9uZGluZw0K dGVzdHMgdG8gYmUgYWNjZXB0ZWQuDQoNCj4gQEAgLTEyNzEsNiArMTI3NSw3 MyBAQCBtaV91c2VyX3NlbGVjdGVkX2NvbnRleHRfY2hhbmdlZCAodXNlcl9z ZWxlY3RlZF93aGF0IHNlbGVjdGlvbikNCj4gICAgICB9DQo+ICB9DQo+ICAN Cj4gK3N0YXRpYyB2b2lkDQo+ICttaV90YXJnZXRfY29ubmVjdGVkIChzdHJ1 Y3QgdGFyZ2V0X29wcyAqdGFyZ2V0KQ0KPiArew0KPiArICBTV0lUQ0hfVEhS VV9BTExfVUlTICgpDQo+ICsgICAgew0KPiArICAgICAgc3RydWN0IG1pX2lu dGVycCAqbWkgPSBhc19taV9pbnRlcnAgKHRvcF9sZXZlbF9pbnRlcnByZXRl ciAoKSk7DQo+ICsgICAgICBzdHJ1Y3QgdWlfb3V0ICptaV91aW91dDsNCj4g Kw0KPiArICAgICAgaWYgKG1pID09IE5VTEwpDQo+ICsgICAgICAgIGNvbnRp bnVlOw0KPiArDQo+ICsgICAgICBtaV91aW91dCA9IHRvcF9sZXZlbF9pbnRl cnByZXRlciAoKS0+aW50ZXJwX3VpX291dCAoKTsNCj4gKw0KPiArICAgICAg dGFyZ2V0X3Rlcm1pbmFsOjpzY29wZWRfcmVzdG9yZV90ZXJtaW5hbF9zdGF0 ZSB0ZXJtX3N0YXRlOw0KPiArICAgICAgdGFyZ2V0X3Rlcm1pbmFsOjpvdXJz X2Zvcl9vdXRwdXQgKCk7DQo+ICsNCj4gKyAgICAgIGZwcmludGZfdW5maWx0 ZXJlZCAobWktPmV2ZW50X2NoYW5uZWwsInRhcmdldC1jb25uZWN0ZWQiKTsN Cj4gKw0KPiArICAgICAgbWlfdWlvdXQtPnJlZGlyZWN0IChtaS0+ZXZlbnRf Y2hhbm5lbCk7DQo+ICsNCj4gKyAgICAgIG1pX3Vpb3V0LT5maWVsZF9zdHJp bmcgKCJ0eXBlIiwgdGFyZ2V0LT5zaG9ydG5hbWUoKSk7DQo+ICsgICAgICBt aV91aW91dC0+ZmllbGRfc3RyaW5nICgibmFtZSIsIHRhcmdldC0+bG9uZ25h bWUoKSk7DQo+ICsNCj4gKyAgICAgIHsNCj4gKyAgICAgICAgdWlfb3V0X2Vt aXRfbGlzdCBsaXN0X2VtaXR0ZXIgKG1pX3Vpb3V0LCAiZmVhdHVyZXMiKTsN Cj4gKw0KPiArICAgICAgICBpZiAobWlfYXN5bmNfcCAoKSkNCj4gKyAgICAg ICAgICBtaV91aW91dC0+ZmllbGRfc3RyaW5nIChOVUxMLCAiYXN5bmMiKTsN Cj4gKyAgICAgICAgaWYgKHRhcmdldF9jYW5fZXhlY3V0ZV9yZXZlcnNlKQ0K PiArICAgICAgICAgIG1pX3Vpb3V0LT5maWVsZF9zdHJpbmcgKE5VTEwsICJy ZXZlcnNlIik7DQo+ICsgICAgICB9DQo+ICsNCj4gKyAgICAgIG1pX3Vpb3V0 LT5yZWRpcmVjdCAoTlVMTCk7DQo+ICsNCj4gKyAgICAgIGdkYl9mbHVzaCAo bWktPmV2ZW50X2NoYW5uZWwpOw0KPiArICAgIH0NCj4gK30NCg0KSSB0aGlu ayB0aGVyZSBpcyBhIChraW5kIG9mIGNvcm5lci1jYXNlLCBidXQgc3RpbGwp IGJ1ZyB3aXRoIHVzaW5nDQptaV9hc3luY19wIGFuZCB0YXJnZXRfY2FuX2V4 ZWN1dGVfcmV2ZXJzZS4gIEhlcmUgYXJlIHNvbWUgQ0xJIGNvbW1hbmRzDQpJ IHR5cGUgaW4gYSAiZ2RiIC1pIG1pIiwgYW5kIHRoZSBjb3JyZXNwb25kaW5n DQo9dGFyZ2V0LWNvbm5lY3RlZC9kaXNjb25uZWN0ZWQgZXZlbnQ6DQoNCnNl dCBtaS1hc3luYyBvbg0KZmlsZSB0ZXN0DQo9dGFyZ2V0LWNvbm5lY3RlZCx0 eXBlPSJleGVjIixuYW1lPSJMb2NhbCBleGVjIGZpbGUiLGZlYXR1cmVzPVtd DQoNCnN0YXJ0DQo9dGFyZ2V0LWNvbm5lY3RlZCx0eXBlPSJuYXRpdmUiLG5h bWU9Ik5hdGl2ZSBwcm9jZXNzIixmZWF0dXJlcz1bImFzeW5jIl0NCg0KcmVj b3JkDQo9dGFyZ2V0LWNvbm5lY3RlZCx0eXBlPSJyZWNvcmQtZnVsbCIsbmFt ZT0iUHJvY2VzcyByZWNvcmQgYW5kIHJlcGxheSB0YXJnZXQiLGZlYXR1cmVz PVsiYXN5bmMiLCJyZXZlcnNlIl0NCg0KZmlsZQ0KPXRhcmdldC1kaXNvbm5l Y3RlZCx0eXBlPSJleGVjIixuYW1lPSJMb2NhbCBleGVjIGZpbGUiDQoNCmZp bGUgL2Jpbi9scw0KPXRhcmdldC1jb25uZWN0ZWQsdHlwZT0iZXhlYyIsbmFt ZT0iTG9jYWwgZXhlYyBmaWxlIixmZWF0dXJlcz1bImFzeW5jIiwicmV2ZXJz ZSJdDQoNClRoYXQgbGFzdCBldmVudCBzYXlzIHRoZSBleGVjIHRhcmdldCBz dXBwb3J0cyBhc3luYyBhbmQgcmV2ZXJzZSwgd2hpY2ggaXMgd3JvbmcuDQpT byB5b3Ugd291bGQgbmVlZCB0byB3cml0ZSBhbiBlcXVpdmFsZW50IG9mIG1p X2FzeW5jX3AvdGFyZ2V0X2Nhbl9leGVjdXRlX3JldmVyc2UNCnRvIHdoaWNo IHlvdSBjYW4gcGFzcyBhIHRhcmdldF9vcHMqLCBpdCBzaG91bGQgbm90IGJl IHRvbyBoYXJkLg0KDQpTaW1vbg0K >From gdb-patches-return-151672-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Oct 18 09:31:40 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 65094 invoked by alias); 18 Oct 2018 09:31:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 65072 invoked by uid 89); 18 Oct 2018 09:31:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=tighten, H*f:sk:871s8qc, H*f:sk:4aa9c21, H*f:sk:6c7d1b6 X-HELO: mail-wm1-f68.google.com Received: from mail-wm1-f68.google.com (HELO mail-wm1-f68.google.com) (209.85.128.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Oct 2018 09:31:37 +0000 Received: by mail-wm1-f68.google.com with SMTP id r63-v6so4712460wma.4 for ; Thu, 18 Oct 2018 02:31:37 -0700 (PDT) Return-Path: Received: from ?IPv6:2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4? ([2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id 12-v6sm5098373wms.11.2018.10.18.02.31.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 02:31:34 -0700 (PDT) Subject: Re: [PATCH v2] Release the GIL while running a gdb command or expression To: Tom Tromey , Pedro Alves Cc: gdb-patches@sourceware.org References: <20181010202233.17985-1-tom@tromey.com> <6c7d1b6d-2d7a-dcaf-8d20-615bfb474af9@redhat.com> <871s8qcab9.fsf@tromey.com> <4aa9c215-9b86-40f9-37e9-d96121e80736@redhat.com> <87woqhbmh6.fsf@tromey.com> From: Phil Muldoon Message-ID: <72bce55f-57d8-bd77-e39a-732e85c21787@redhat.com> Date: Thu, 18 Oct 2018 09:31:00 -0000 MIME-Version: 1.0 In-Reply-To: <87woqhbmh6.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00390.txt.bz2 Content-length: 1548 On 16/10/2018 22:39, Tom Tromey wrote: > Pedro> Hopefully it'll be possible to tighten the test a bit to avoid that. > > I should have read the test more closely. It doesn't do what it claims > to do at all. I'm not sure what it or I claimed? The initial snippet and test was included with this explanation: "As for a test, we also have a test included. It does not appear to be racy for our purposes. I also include it for consideration. This snippet is just for initial consideration and will make any changes needed to include it in the patch." This was from the original (version 1) email. > > The only way the test can fail is if one "Hello" or "Sleeping" line > comes with the wrong number: > > set n $expect_out(1,string) > if { $hello_last + 1 != $n } { > fail $test > > But this just isn't possible. I can't remember why I wrote it this way, or if there was a modification to the patch over the years, but, the original intention to the patch was to test interleaved output from the Python thread and GDB (thereby proving the GIL was released). > > Also the Python code is calling print on a gdb stream in a background > thread, which is a no-no. Yeah, this came up in the original review thread. You pointed out that GDB wasn't thread safe when I was worried over any existing scripts out there that would rely on the expectation that the gdb.command API would hold the GIL. For some reason, I did not know this beforehand (that GDB wasn't thread safe), so that is why it snuck in there (back in 2014). Cheers Phil