From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8bjqNLsNvmiFgzIAWB0awg (envelope-from ) for ; Sun, 07 Sep 2025 18:56:59 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=RWEbBDRC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D06ED1E0BA; Sun, 07 Sep 2025 18:56:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 145511E047 for ; Sun, 07 Sep 2025 18:56:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9AA013858C42 for ; Sun, 7 Sep 2025 22:56:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9AA013858C42 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=RWEbBDRC Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id ACD953858CD9 for ; Sun, 7 Sep 2025 22:56:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACD953858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ACD953858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::436 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757285765; cv=none; b=sR9MPnwmM45bHZ1gyXk8VNCBnMqKmKGmx6qxkEOmSkgqpbtKDgcsxbEAnSUlvV1Pxspi914jG4cxR7nSGngz8a8OTTW8SOMWA48Zu7CRg5+KqmJmDQgCzQZB24xCqw7Ipw1C7eSX40vKs1yh5IE2vmV+XgQeqAXpyl0IkYk/w3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757285765; c=relaxed/simple; bh=GxA8btb6et1yiAH1AT8AOvmf5llUhtyJiCRnD+sK0Fs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=iBHFY2k+EgKJjH4FWZq54KFbv8V4urGG5FEVQIkI31SpraZSBxcIhvRpi3PwWUgH1HRhAFDtV8yqqHUg35wjox+IJ85fKiq4OT1er1Yfo8raX3vSQnW1G98JyyqeL90FnxUPZbRL/k0HD3YOustE8mbQjwZ9E0bIk+5qUnPlcbM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ACD953858CD9 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3da9ad0c1f4so2534854f8f.3 for ; Sun, 07 Sep 2025 15:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757285763; x=1757890563; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=2/TCkKsSC5KoHhFEJOV7h2SfPE4i58Z2olx8SRqRC7E=; b=RWEbBDRCufhHGHlm8EdMxBHeLormrccrVVLfeUJCw9tdTCp09NgiLofqGM+zqs7Uee 9nQ9C1hTzlyHooBxytZhDuPm4jaZJ/Zvc8LB1MEWjbep2rDYy3aqPy3UPvDmxWCGBqn6 QhBbr7hkFMuzJIIbOg9V3kVe2EMfbogZzdQHIDd+kGHv+GwecnIwG1ZL14pEh++/O4DM bMFOYQcoblfNbIemdX8loc9c5H1oA6TrF21Xp8taTd8/N8PW6RkgZdEsr7IaYjrQd0QG FHKygUwo6HgNU4hYEA7zPALcfBSLmenQ8f1CknkdGg2T9/1CQojXQ6ajwz1zx3AeEax3 Q5Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757285763; x=1757890563; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2/TCkKsSC5KoHhFEJOV7h2SfPE4i58Z2olx8SRqRC7E=; b=L01BqUj5MkrKyi5wr+BL0iXANj5ddrejzP6biZZMP5vGh0Y2J6pZslV9sCQN/TmLN9 tAygnsfAq1RvsCkEwqjZ8blbiHB1grjBw0+M9z9LjPPVzu0m6xJwOxj1PU0aU6fleWR/ YVAOb/OV2grznIh6ViJ5WCA8DQESUv2wjQLNRP0PNI2L948Rs8qr2nqcR/TQsy1vkzWD oRdiXDFRFfwZUGcAYFMJQeaA4OxLIFsydFONktdFzQ9Eu/PMOhxL7BxmIXoZEuYaqMIi qbl9FA89G69TOzDxRMsIK6VxACAhUqDDRbkldM3nBZ/CyHdM5Traos0ZjCZ2Bxb8rkdm ZH/Q== X-Forwarded-Encrypted: i=1; AJvYcCWfOeayYaUsi8z92rgDLRiFiAOSmMKpN/DOuvp18R6OFXgYVkjH+EY3HGw824/ETva8UTYzCASKUNjHng==@sourceware.org X-Gm-Message-State: AOJu0Yyo/euHUeO3Q2i24pnuD0fradbZvebF1xy9zJE3ObcM712NLXgh S2kxcSFtAE4qKMpIyMuC3VrDzRu5/MnuD6OTIcD+0BgDqjhj4/zY1J2122qEPioX X-Gm-Gg: ASbGnctFMJjZMUWczTgxkqwUc7DFZXmFKSmQCDVQQH+C4FsCswg78a8ABC92MA78niu p/2TuA8yYF7a0hsssoqflkJTofDVrxueoTFOics2Wa5ZIgpzPlqjBFlr4nR5m/oQ4QGU1evtdsL U0bRPegq4/+/+dXUoZ+O/PUx1MQHT4zSy7yZiR4H5cmkgOcyJT4kWIpMAW+megiDzfbw//zIkZG pZ5AxQKtNBjwCHpVJR9ifnnN36F036/1DMB6pYZIZARamOAPx/g3EXNPVkDbt53rEPcRXvbx3o9 cSbo3skGgoA39Ev8JqzCASE55U+zUcQ/UHASwRJxFej8yt20/rEBMlzxVEGMMlpKjyfRsZpJctC uAigAzVCJDiran0boPUi2zYreXCCrg8EnDnU= X-Google-Smtp-Source: AGHT+IEQbGcQwox56u1c5FfPZWTv6drh8artlTC63y9T007oFqNFJ71AB06RzpV8YLNK9f30RGnw4Q== X-Received: by 2002:a05:6000:3101:b0:3e4:f194:2886 with SMTP id ffacd0b85a97d-3e642cadca2mr4888870f8f.19.1757285763208; Sun, 07 Sep 2025 15:56:03 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf275d2717sm39197064f8f.15.2025.09.07.15.56.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Sep 2025 15:56:02 -0700 (PDT) Message-ID: <76a288b0-96b6-4ce1-9c86-8340de5281cf@gmail.com> Date: Sun, 7 Sep 2025 23:56:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Luis Subject: Re: [RFC PATCH 3/5] gdb/aarch64: signal frame support for fpmr To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org, Thiago Jung Bauermann References: <20250905131707.77027-1-Ezra.Sitorus@arm.com> <20250905131707.77027-4-Ezra.Sitorus@arm.com> Content-Language: en-US In-Reply-To: <20250905131707.77027-4-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 05/09/2025 14:17, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > Add support for FPMR in signal frames and restore contents of FPMR. > > Manually validated with Shrinkwrap (Arm FVP). > --- > gdb/aarch64-linux-tdep.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c > index acb650db514..b4911d36410 100644 > --- a/gdb/aarch64-linux-tdep.c > +++ b/gdb/aarch64-linux-tdep.c > @@ -168,6 +168,7 @@ > #define AARCH64_TPIDR2_MAGIC 0x54504902 > #define AARCH64_ZT_MAGIC 0x5a544e01 > #define AARCH64_GCS_MAGIC 0x47435300 > +#define AARCH64_FPMR_MAGIC 0x46504d52 > > /* Defines for the extra_context that follows an AARCH64_EXTRA_MAGIC. */ > #define AARCH64_EXTRA_DATAP_OFFSET 8 > @@ -214,6 +215,9 @@ > /* features_enabled value offset in the GCS signal frame context. */ > #define AARCH64_GCS_CONTEXT_FEATURES_ENABLED_OFFSET 16 > > +/* FPMR constants. */ > +#define AARCH64_FPMR_OFFSET 8 > + > /* Holds information about the signal frame. */ > struct aarch64_linux_sigframe > { > @@ -261,6 +265,12 @@ struct aarch64_linux_sigframe > uint64_t gcspr; > /* Flags indicating which GCS features are enabled for the thread. */ > uint64_t gcs_features_enabled; > + > + /* True if we have an FPMR entry in the signal context, false otherwise. */ > + bool fpmr_available = false; > + /* The Floating Point Mode Register. */ > + CORE_ADDR fpmr = 0; > + > }; > > /* Read an aarch64_ctx, returning the magic value, and setting *SIZE to the > @@ -577,6 +587,22 @@ aarch64_linux_read_signal_frame_info (const frame_info_ptr &this_frame, > section += size; > break; > } > + case AARCH64_FPMR_MAGIC: > + { > + gdb_byte buf[8]; > + if (target_read_memory (section + AARCH64_FPMR_OFFSET, > + buf, 8) != 0) > + { > + warning (_("Failed to read the FPMR section address from the" > + " signal frame context.")); > + section += size; > + break; > + } > + signal_frame.fpmr = extract_unsigned_integer (buf, 8, byte_order); > + signal_frame.fpmr_available = true; > + section += size; > + break; > + } > case AARCH64_EXTRA_MAGIC: > { > /* Extra is always the last valid section in reserved and points to > @@ -740,6 +766,13 @@ aarch64_linux_sigframe_init (const struct tramp_frame *self, > } > } > > + /* Handle FPMR. */ > + if (tdep->has_fpmr () && signal_frame.fpmr_available != 0) > + { > + trad_frame_set_reg_value (this_cache, tdep->fpmr_regnum, > + signal_frame.fpmr); > + } > + > /* Restore the tpidr2 register, if the target supports it and if there is > an entry for it. */ > if (signal_frame.tpidr2_section != 0 && tdep->has_tls () > @@ -792,6 +825,7 @@ aarch64_linux_sigframe_prev_arch (const frame_info_ptr &this_frame, > aarch64_features features = aarch64_features_from_target_desc (tdesc); > features.vq = sve_vq_from_vl (signal_frame.vl); > features.svq = (uint8_t) sve_vq_from_vl (signal_frame.svl); > + features.fpmr = signal_frame.fpmr_available; Unrelated, but looks like we're not handling gcs in aarch64_linux_sigframe_prev_arch. Is that something we need to do Thiago? > > struct gdbarch_info info; > info.bfd_arch_info = bfd_lookup_arch (bfd_arch_aarch64, bfd_mach_aarch64); Otherwise, I don't have comments on this patch. Reviewed-By: Luis Machado