From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5133 invoked by alias); 1 Oct 2012 09:29:39 -0000 Received: (qmail 5094 invoked by uid 22791); 1 Oct 2012 09:29:38 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_CP X-Spam-Check-By: sourceware.org Received: from eu1sys200aog115.obsmtp.com (HELO eu1sys200aog115.obsmtp.com) (207.126.144.139) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Oct 2012 09:29:32 +0000 Received: from beta.dmz-eu.st.com ([164.129.1.35]) (using TLSv1) by eu1sys200aob115.postini.com ([207.126.147.11]) with SMTP ID DSNKUGlidrwuLL5ABJWF29RFqNSI6VQDnxm0@postini.com; Mon, 01 Oct 2012 09:29:31 UTC Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 63B65F2; Mon, 1 Oct 2012 09:29:21 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas4.st.com [10.75.90.69]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id EEEE829F5; Mon, 1 Oct 2012 09:29:20 +0000 (GMT) Received: from SAFEX1MAIL1.st.com ([10.75.90.1]) by Safex1hubcas4.st.com ([10.75.90.69]) with mapi; Mon, 1 Oct 2012 11:29:20 +0200 From: Giuseppe MONTALTO To: Tom Tromey Cc: "gdb-patches@sourceware.org" , "Abid, Hafiz" Date: Mon, 01 Oct 2012 09:29:00 -0000 Subject: RE: [PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions) Message-ID: <76FE3225DF13124EA2D05B290B624C95E66B295956@SAFEX1MAIL1.st.com> References: <76FE3225DF13124EA2D05B290B624C95E65F2D466E@SAFEX1MAIL1.st.com> <87sjf9rzr0.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E65FECE356@SAFEX1MAIL1.st.com> <871umsqgu8.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E65FECE48F@SAFEX1MAIL1.st.com> <87397624b9.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E662A6921F@SAFEX1MAIL1.st.com> <76FE3225DF13124EA2D05B290B624C95E6632A4256@SAFEX1MAIL1.st.com> <878vcc1s9f.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E66B003EA8@SAFEX1MAIL1.st.com> <87wqzgwm4k.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E66B004AC6@SAFEX1MAIL1.st.com> <87r4plsyh0.fsf@fleche.redhat.com> In-Reply-To: <87r4plsyh0.fsf@fleche.redhat.com> Content-Type: multipart/mixed; boundary="_002_76FE3225DF13124EA2D05B290B624C95E66B295956SAFEX1MAIL1st_" MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00002.txt.bz2 --_002_76FE3225DF13124EA2D05B290B624C95E66B295956SAFEX1MAIL1st_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 1436 New patch attached: - removed trivial comments - removed redundant "else if" clause=20 Any further feedback is always welcome, Giuseppe. > -----Original Message----- > From: Tom Tromey [mailto:tromey@redhat.com] > Sent: Friday, September 28, 2012 10:07 PM > To: Giuseppe MONTALTO > Cc: gdb-patches@sourceware.org; Abid, Hafiz > Subject: Re: [PATCH] enhancement of mi_cmd_data_write_memory_bytes > for filling memory regions (was [PATCH] new MI command for pattern filling > of memory regions) >=20 > >>>>> "Giuseppe" =3D=3D Giuseppe MONTALTO > writes: >=20 > Giuseppe> the attached patch should fix all the issues. >=20 > Thanks. Unfortunately I thought of one more little thing. >=20 > Giuseppe> + remainder =3D count % len; /* there may be some spare by= tes. > */ >=20 > Comment should start with a capital letter. > Though TBH you could also just remove this comment since I think the > code is already clear. >=20 > Giuseppe> + if (remainder > 0) /* copy spare bytes too. */ >=20 > Likewise on both counts. >=20 > Giuseppe> + else if (len > count) > Giuseppe> + { > Giuseppe> + /* Pattern is longer than count: > Giuseppe> + just copy len bytes. */ > Giuseppe> + data =3D xmalloc (len); > Giuseppe> + make_cleanup (xfree, data); > Giuseppe> + memcpy (data, databuf, len); >=20 > There's no need to copy the data here. > Just set data=3Ddatabuf. >=20 > Tom --_002_76FE3225DF13124EA2D05B290B624C95E66B295956SAFEX1MAIL1st_ Content-Type: application/octet-stream; name="patch-V.7.patch" Content-Description: patch-V.7.patch Content-Disposition: attachment; filename="patch-V.7.patch"; size=5658; creation-date="Mon, 01 Oct 2012 09:23:40 GMT"; modification-date="Mon, 01 Oct 2012 09:23:40 GMT" Content-Transfer-Encoding: base64 Content-length: 7670 IGdkYi9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg IDUgKysKIGdkYi9taS9taS1tYWluLmMgICAgICAgICAgICAgICAgICAgICAg ICB8ICAgNDUgKysrKysrKysrKysrKysrKystLS0tCiBnZGIvdGVzdHN1aXRl L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgICA0ICsrCiBnZGIvdGVz dHN1aXRlL2dkYi5taS9taS1maWxsLW1lbW9yeS5leHAgfCAgIDY4ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwg MTE0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZ2RiL0NoYW5nZUxvZyBiL2dkYi9DaGFuZ2VMb2cKaW5kZXggOTU5ZTkw ZC4uMDYwY2I5MyAxMDA2NDQKLS0tIGEvZ2RiL0NoYW5nZUxvZworKysgYi9n ZGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsOCBAQAorMjAxMi0wOS0yNyAgR2l1 c2VwcGUgTW9udGFsdG8gIDxnaXVzZXBwZS5tb250YWx0b0BzdC5jb20+CisK KwkqIG1pL21pLW1haW4uYyAgKG1pX2NtZF9kYXRhX3dyaXRlX21lbW9yeSk6 IEFkZGl0aW9uYWwKKwlwYXJhbWV0ZXIgZm9yIHBhdHRlcm4gZmlsbGluZyBv ZiBtZW1vcnkgcmVnaW9ucworCQogMjAxMi0wOS0yNyAgWWFvIFFpICA8eWFv QGNvZGVzb3VyY2VyeS5jb20+CiAKIAlQUiBicmVha3BvaW50cy8xMzg5OApk aWZmIC0tZ2l0IGEvZ2RiL21pL21pLW1haW4uYyBiL2dkYi9taS9taS1tYWlu LmMKaW5kZXggZjFkMjFiYy4uYjA4MzY4NSAxMDA2NDQKLS0tIGEvZ2RiL21p L21pLW1haW4uYworKysgYi9nZGIvbWkvbWktbWFpbi5jCkBAIC0xNjU2LDcg KzE2NTYsOCBAQCBtaV9jbWRfZGF0YV93cml0ZV9tZW1vcnkgKGNoYXIgKmNv bW1hbmQsIGNoYXIgKiphcmd2LCBpbnQgYXJnYykKIC8qIEltcGxlbWVudGF0 aW9uIG9mIHRoZSAtZGF0YS13cml0ZS1tZW1vcnktYnl0ZXMgY29tbWFuZC4K IAogICAgQUREUjogc3RhcnQgYWRkcmVzcwotICAgREFUQTogc3RyaW5nIG9m IGJ5dGVzIHRvIHdyaXRlIGF0IHRoYXQgYWRkcmVzcy4gICovCisgICBEQVRB OiBzdHJpbmcgb2YgYnl0ZXMgdG8gd3JpdGUgYXQgdGhhdCBhZGRyZXNzCisg ICBDT1VOVDogbnVtYmVyIG9mIGJ5dGVzIHRvIGJlIGZpbGxlZCAoZGVjaW1h bCBpbnRlZ2VyKS4gICovCiAKIHZvaWQKIG1pX2NtZF9kYXRhX3dyaXRlX21l bW9yeV9ieXRlcyAoY2hhciAqY29tbWFuZCwgY2hhciAqKmFyZ3YsIGludCBh cmdjKQpAQCAtMTY2NCwyNyArMTY2NSw1NSBAQCBtaV9jbWRfZGF0YV93cml0 ZV9tZW1vcnlfYnl0ZXMgKGNoYXIgKmNvbW1hbmQsIGNoYXIgKiphcmd2LCBp bnQgYXJnYykKICAgQ09SRV9BRERSIGFkZHI7CiAgIGNoYXIgKmNkYXRhOwog ICBnZGJfYnl0ZSAqZGF0YTsKLSAgaW50IGxlbiwgciwgaTsKKyAgZ2RiX2J5 dGUgKmRhdGFidWY7CisgIHNpemVfdCBsZW4sIHIsIGksIHN0ZXBzLCByZW1h aW5kZXI7CisgIGxvbmcgaW50IGNvdW50LCBqOwogICBzdHJ1Y3QgY2xlYW51 cCAqYmFja190bzsKIAotICBpZiAoYXJnYyAhPSAyKQotICAgIGVycm9yIChf KCJVc2FnZTogQUREUiBEQVRBLiIpKTsKKyAgaWYgKGFyZ2MgIT0gMiAmJiBh cmdjICE9IDMpCisgICAgZXJyb3IgKF8oIlVzYWdlOiBBRERSIERBVEEgW0NP VU5UXS4iKSk7CiAKICAgYWRkciA9IHBhcnNlX2FuZF9ldmFsX2FkZHJlc3Mg KGFyZ3ZbMF0pOwogICBjZGF0YSA9IGFyZ3ZbMV07CiAgIGxlbiA9IHN0cmxl biAoY2RhdGEpLzI7CisgIGlmIChhcmdjID09IDMpCisgICAgY291bnQgPSBz dHJ0b3VsIChhcmd2WzJdLCBOVUxMLCAxMCk7CisgIGVsc2UKKyAgICBjb3Vu dCA9IGxlbjsKIAotICBkYXRhID0geG1hbGxvYyAobGVuKTsKLSAgYmFja190 byA9IG1ha2VfY2xlYW51cCAoeGZyZWUsIGRhdGEpOworICBkYXRhYnVmID0g eG1hbGxvYyAobGVuICogc2l6ZW9mIChnZGJfYnl0ZSkpOworICBiYWNrX3Rv ID0gbWFrZV9jbGVhbnVwICh4ZnJlZSwgZGF0YWJ1Zik7CiAKICAgZm9yIChp ID0gMDsgaSA8IGxlbjsgKytpKQogICAgIHsKICAgICAgIGludCB4OwogICAg ICAgc3NjYW5mIChjZGF0YSArIGkgKiAyLCAiJTAyeCIsICZ4KTsKLSAgICAg IGRhdGFbaV0gPSAoZ2RiX2J5dGUpIHg7CisgICAgICBkYXRhYnVmW2ldID0g KGdkYl9ieXRlKSB4OworICAgIH0KKworICBpZiAobGVuIDwgY291bnQpCisg ICAgeworICAgICAgLyogUGF0dGVybiBpcyBtYWRlIG9mIGxlc3MgYnl0ZXMg dGhhbiBjb3VudDogCisgICAgICAgICByZXBlYXQgcGF0dGVybiB0byBmaWxs IG1lbW9yeS4gICovCisgICAgICBkYXRhID0geG1hbGxvYyAoY291bnQpOwor ICAgICAgbWFrZV9jbGVhbnVwICh4ZnJlZSwgZGF0YSk7CisgICAgCisgICAg ICBzdGVwcyA9IGNvdW50IC8gbGVuOworICAgICAgcmVtYWluZGVyID0gY291 bnQgJSBsZW47CisgICAgICBmb3IgKGogPSAwOyBqIDwgc3RlcHM7IGorKykK KyAgICAgICAgbWVtY3B5IChkYXRhICsgaiAqIGxlbiwgZGF0YWJ1ZiwgbGVu KTsKKworICAgICAgaWYgKHJlbWFpbmRlciA+IDApCisgICAgICAgIG1lbWNw eSAoZGF0YSArIHN0ZXBzICogbGVuLCBkYXRhYnVmLCByZW1haW5kZXIpOwor ICAgIH0KKyAgZWxzZSAKKyAgICB7CisgICAgICAvKiBQYXR0ZXJuIGlzIGxv bmdlciB0aGFuIG9yIGVxdWFsIHRvIGNvdW50OiAKKyAgICAgICAgIGp1c3Qg Y29weSBsZW4gYnl0ZXMuICAqLworICAgICAgZGF0YSA9IGRhdGFidWY7CiAg ICAgfQogCi0gIHIgPSB0YXJnZXRfd3JpdGVfbWVtb3J5IChhZGRyLCBkYXRh LCBsZW4pOworICByID0gdGFyZ2V0X3dyaXRlX21lbW9yeSAoYWRkciwgZGF0 YSwgY291bnQpOwogICBpZiAociAhPSAwKQogICAgIGVycm9yIChfKCJDb3Vs ZCBub3Qgd3JpdGUgbWVtb3J5IikpOwogCmRpZmYgLS1naXQgYS9nZGIvdGVz dHN1aXRlL0NoYW5nZUxvZyBiL2dkYi90ZXN0c3VpdGUvQ2hhbmdlTG9nCmlu ZGV4IDY3MDc3NTEuLjQ5MGIyMTIgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3Vp dGUvQ2hhbmdlTG9nCisrKyBiL2dkYi90ZXN0c3VpdGUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsNyBAQAorMjAxMi0yNy0xOCAgR2l1c2VwcGUgTW9udGFsdG8g IDxnaXVzZXBwZS5tb250YWx0b0BzdC5jb20+CisKKwkqIGdkYi5taS9taS1m aWxsLW1lbW9yeS5leHA6IE5ldyB0ZXN0LgorCiAyMDEyLTA5LTI2ICBUb20g VHJvbWV5ICA8dHJvbWV5QHJlZGhhdC5jb20+CiAKIAkqIGdkYi5kd2FyZjIv ZHcyLWNvbW1vbi1ibG9jay5TOiBOZXcgZmlsZS4KZGlmZiAtLWdpdCBhL2dk Yi90ZXN0c3VpdGUvZ2RiLm1pL21pLWZpbGwtbWVtb3J5LmV4cCBiL2dkYi90 ZXN0c3VpdGUvZ2RiLm1pL21pLWZpbGwtbWVtb3J5LmV4cApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4zZGY2YTk2Ci0tLSAvZGV2L251 bGwKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIubWkvbWktZmlsbC1tZW1vcnku ZXhwCkBAIC0wLDAgKzEsNjggQEAKKyMgQ29weXJpZ2h0IChDKSAyMDEyIEZy ZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorIyBDb3B5cmlnaHQgKEMp IDIwMTIgU1RNaWNyb2VsZWN0cm9uaWNzCisKKyMgVGhpcyBwcm9ncmFtIGlz IGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9v ciBtb2RpZnkKKyMgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyMgdGhlIEZy ZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMyBvZiB0 aGUgTGljZW5zZSwgb3IKKyMgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIg dmVyc2lvbi4KKyMKKyMgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGlu IHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRI T1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdh cnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBB IFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyMgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKyMKKyMgWW91IHNo b3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UKKyMgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJ ZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisK KyMKKyMgdGVzdCBiYXNpYyBNYWNoaW5lIGludGVyZmFjZSAoTUkpIG9wZXJh dGlvbnMKKyMKKyMgVmVyaWZ5IHRoYXQsIHVzaW5nIHRoZSBNSSwgd2UgY2Fu IGxvYWQgYSBwcm9ncmFtIGFuZCBkbworIyBvdGhlciBiYXNpYyB0aGluZ3Mg dGhhdCBhcmUgdXNlZCBieSBhbGwgdGVzdCBmaWxlcyB0aHJvdWdoICBtaV9n ZGJfZXhpdCwKKyMgbWlfZ2RiX3N0YXJ0LCBtaV9kZWxldGVfYnJlYWtwb2lu dHMsIG1pX2dkYl9yZWluaXRpYWxpemVfZGlyIGFuZAorIyBtaV9nZGJfbG9h ZCwgc28gd2UgY2FuIHNhZmVseSB1c2UgdGhvc2UuCisjCisjIFRoZSBnb2Fs IGlzIG5vdCB0byB0ZXN0IGdkYiBmdW5jdGlvbmFsaXR5LCB3aGljaCBpcyBk b25lIGJ5IG90aGVyIHRlc3RzLAorIyBidXQgdGhlIGNvbW1hbmQgc3ludGF4 IGFuZCBjb3JyZWN0IG91dHB1dCByZXNwb25zZSB0byBNSSBvcGVyYXRpb25z LgorIyAKKyMgYWRkZWQgZm9yIHRlc3RpbmcgdGhlIC1kYXRhLXdyaXRlLW1l bW9yeS1ieXRlcyBNSSBjb21tYW5kIGVuaGFuY2VtZW50cworIworCitsb2Fk X2xpYiBtaS1zdXBwb3J0LmV4cAorc2V0IE1JRkxBR1MgIi1pPW1pIgorCitn ZGJfZXhpdAoraWYgW21pX2dkYl9zdGFydF0geworICAgIGNvbnRpbnVlCit9 CisKK3N0YW5kYXJkX3Rlc3RmaWxlICJtaS1yZWFkLW1lbW9yeSIKKyAKK2lm IHtbYnVpbGRfZXhlY3V0YWJsZSAke3Rlc3RmaWxlfS5leHAgJHtiaW5maWxl fSAke3NyY2ZpbGV9LmMge2RlYnVnIGFkZGl0aW9uYWxfZmxhZ3M9LURGQUtF QVJHVn1dID09IC0xfSB7CisgICAgcmV0dXJuIC0xCit9CisKK21pX3J1bl90 b19tYWluCittaV9uZXh0X3RvICJtYWluIiAiIiAibWktcmVhZC1tZW1vcnku YyIgIjIwIiAibmV4dCBhdCBtYWluIgorCittaV9nZGJfdGVzdCAiMS1kYXRh LXdyaXRlLW1lbW9yeS1ieXRlcyJcCisJIjFcXFxeZXJyb3IsbXNnPVwiVXNh Z2U6IEFERFIgREFUQSBcXFxbQ09VTlRcXFxdXC5cIiJcCisJIm5vIGFyZ3Vt ZW50cyIKKworbWlfZ2RiX3Rlc3QgIjItZGF0YS13cml0ZS1tZW1vcnktYnl0 ZXMgOCJcCisJIjJcXFxeZXJyb3IsbXNnPVwiVXNhZ2U6IEFERFIgREFUQSBc XFxbQ09VTlRcXFxdXC5cIiJcCisJIm9uZSBhcmd1bWVudCBtaXNzaW5nIgor CittaV9nZGJfdGVzdCAiMy1kYXRhLXdyaXRlLW1lbW9yeS1ieXRlcyBcJHBj IGFiIlwKKwkiM1xcXF5kb25lIiBcCisJIm1lbW9yeSBzdWNjZXNzZnVsbHkg d3JpdHRlbiIKKworbWlfZ2RiX3Rlc3QgIjQtZGF0YS13cml0ZS1tZW1vcnkt Ynl0ZXMgXCRwYyBhYiA4IlwKKwkiNFxcXF5kb25lIiBcCisJIm1lbW9yeSBz dWNjZXNzZnVsbHkgZmlsbGVkICg4IGJ5dGVzKSIKKworbWlfZ2RiX3Rlc3Qg IjUtaW50ZXJwcmV0ZXItZXhlYyBjb25zb2xlIFwieCBcJHBjXCIiIFwKKyAg ICAiLioweGFiYWJhYmFiLioiIFwKKyAgICAicGF0dGVybiBjb3JyZWN0bHkg cmVhZCBmcm9tIG1lbW9yeSIKKworbWlfZ2RiX2V4aXQK --_002_76FE3225DF13124EA2D05B290B624C95E66B295956SAFEX1MAIL1st_--