From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24150 invoked by alias); 7 Aug 2017 14:47:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23399 invoked by uid 89); 7 Aug 2017 14:47:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=bitten, scratching X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Aug 2017 14:47:16 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v77ElAp7030551 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 7 Aug 2017 10:47:14 -0400 Received: by simark.ca (Postfix, from userid 112) id E93DB1EA1D; Mon, 7 Aug 2017 10:47:09 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 0A74D1E9AB; Mon, 7 Aug 2017 10:47:09 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 07 Aug 2017 14:47:00 -0000 From: Simon Marchi To: Leszek Swirski Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix dwarf2_string_attr for -gsplit-dwarf In-Reply-To: <1d6cd6f279a39b0dba941e995c571cab@polymtl.ca> References: <20170801092030.70676-1-leszeks@google.com> <257cba5bb5ca13e66d1e0cd01175aa37@polymtl.ca> <1d6cd6f279a39b0dba941e995c571cab@polymtl.ca> Message-ID: <768d5702f3767758c3c635b2a9549052@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 7 Aug 2017 14:47:10 +0000 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00122.txt.bz2 On 2017-08-02 12:56, Simon Marchi wrote: > On 2017-08-02 12:12, Leszek Swirski via gdb-patches wrote: >>> If you think this will be a one-time contribution, we can merge the >>> patch >>> for you, and there is no need for copyright assignment for a simple >>> patch >>> like that. However, if you'd like to contribute further to GDB, we >>> can look >>> into giving you write access, so you'll be able to push patches by >>> yourself. >>> Let me know which one you prefer. >> >> Probably a one-off for now, this was pretty much just scratching an >> itch. >> Anything that requires copyright assignment becomes more complicated >> for >> obvious reasons if sent from my work account. > > Ok. > >>> The indentation for this line should be one tab + two spaces (like >>> the >>> previous line). >> >> Yeah, I noticed that as soon as the email sent -- I had it right at >> one point, >> but I guess I got bitten by `set expandtab` before sending. My bad. >> >> I'm assuming you don't need anything more from me to push? > > No, it should be fine. I'll just leave this patch up for review for a > few days in case somebody else wants to comment, and will push after > that. > > Thanks, > > Simon I have pushed this patch, thanks again. I ran the tests with the "fission" board file and there were many tests that went from FAIL -> PASS. So I concluded that we don't need to add a test specifically for this, but we should probably run the testsuite with the fission board on the buildbot. Simon