Re: [PATCH] sim: ppc: use silent build rules here too

will schmidt via Gdb-patches
2021-11-03T16:56:11Z

On Tue, 2021-11-02 at 23:07 -0400, Mike Frysinger wrote:
> On 02 Nov 2021 18:58, will schmidt wrote:
> > On Sun, 2021-10-31 at 05:27 -0400, Mike Frysinger via Gdb-patches
> > wrote:
> > > The ppc codebase is unique and doesn't leverage common/, so have
> > > to
> > > add silent rules to it specifically.
> >
> > I may have evidence to the contrary. :-) I don't see any
> > changes
> > here or in the recent patches that I can specifically identify as
> > troublesome, but something seems fishy between sim/ppc/libsim.a and
> > sim/common/libcommon.a ; I'm seeing this error during recent
> > build
> > attempts on ppc64le, sometime since late last week.
>
> this patch is unrelated to any link failures like this
>
> > /home/willschm/install/bin/ld:
> > ../sim/ppc/libsim.a(callback.o):(.toc+0x10): undefined reference to
> > `cb_init_errno_map'
> > /home/willschm/install/bin/ld:
> > ../sim/ppc/libsim.a(callback.o):(.toc+0x18): undefined reference to
> > `cb_init_signal_map'
> > /home/willschm/install/bin/ld:
> > ../sim/ppc/libsim.a(callback.o):(.toc+0x20): undefined reference to
> > `cb_init_open_map'
>
> you've removed important details from the log ... like what program
> is
> failing to link here ?
> -mike

Hi,

So.. Git bisect suggests one of the other patches. I don't want to
confuse the threads, so will continue to reply on this thread, will hop
over to another thread if thats appropriate. :-)

# first bad commit: [a7e40a99318c46ec57a9c0a64c622b6ec0ed89ff] sim: nltvals: pull target errno out into a dedicated source file

The error with that patch applied is :

CXXLD gdb
/usr/lib64/gcc/powerpc64le-suse-linux/11/../../../../powerpc64le-suse-linux/bin/ld: ../sim/ppc/libsim.a(callback.o):(.toc+0x10): undefined reference to `cb_init_errno_map'
collect2: error: ld returned 1 exit status

Presumably the undefined referece to cb_init_signal_map and cb_init_open_map fall in line with these subsequent patches.

670817b94710 sim: nltvals: pull target open flags out into a dedicated source file
88c8370b25c6 sim: nltvals: pull target signal out into a dedicated source file

Thanks,
-Will