From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AkIuCSjJTWFnNwAAWB0awg (envelope-from ) for ; Fri, 24 Sep 2021 08:48:40 -0400 Received: by simark.ca (Postfix, from userid 112) id 146B31EE25; Fri, 24 Sep 2021 08:48:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A9E01EDF0 for ; Fri, 24 Sep 2021 08:48:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 63697385801A for ; Fri, 24 Sep 2021 12:48:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63697385801A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1632487717; bh=R6azaPoB72aHp5tK5KlI831Kfb9wT3jJkDPIWtE8SJQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=cIj54PG+mFuxuU5hiDxrpvjhxMeWhPcL9T9knNG2WDP4PZOz8Qyb43xDnFOE3s1Kl k2o8i7JrnrqqQ53yV9UWNq8DKO1j2O0PFHUfogXrDCNVHlPyMCd/UX227/YWS1ae6U 5OWCgl/Gz8UoLbXljADSxBnlqsVYWdW++m9IAdTo= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id B21443858402 for ; Fri, 24 Sep 2021 12:48:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B21443858402 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E614022432; Fri, 24 Sep 2021 12:48:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7FE8613B67; Fri, 24 Sep 2021 12:48:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eS50HBHJTWFfGQAAMHmgww (envelope-from ); Fri, 24 Sep 2021 12:48:17 +0000 Subject: Re: [PATCH][gdb/testsuite] Dump /proc/cpuinfo into gdb.log To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20210921080157.GA18967@delia> <671f08cc-cc93-f36e-563d-20f2be20488e@polymtl.ca> Message-ID: <76702685-e072-813e-07b5-9f3ab4878b94@suse.de> Date: Fri, 24 Sep 2021 14:48:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------8D7709A2A480B3866D8B2527" Content-Language: en-US X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This is a multi-part message in MIME format. --------------8D7709A2A480B3866D8B2527 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 9/24/21 2:21 PM, Pedro Alves wrote: > On 2021-09-23 11:06 p.m., Tom de Vries via Gdb-patches wrote: > >> gdb/testsuite/gdb.testsuite/dump-system-info.exp | 48 ++++++++++++++++++++++++ >> 1 file changed, 48 insertions(+) >> >> diff --git a/gdb/testsuite/gdb.testsuite/dump-system-info.exp b/gdb/testsuite/gdb.testsuite/dump-system-info.exp >> new file mode 100644 >> index 00000000000..bf181469bd5 >> --- /dev/null >> +++ b/gdb/testsuite/gdb.testsuite/dump-system-info.exp >> @@ -0,0 +1,48 @@ >> +# Copyright 2021 Free Software Foundation, Inc. >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 3 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program. If not, see . >> + >> +# The purpose of this test-case is to dump /proc/cpuinfo and similar system >> +# info into gdb.log. >> + >> +# Check if /proc/cpuinfo is available. >> +set res [remote_exec target "test -r /proc/cpuinfo"] >> +set status [lindex $res 0] >> +set output [lindex $res 1] > Hi, thanks for the review. > OOC, why "test -r" -> "cat" instead of "cat" straight away, which > is basically what is done for the other dumps? > The other cases are commands without file argument, this is a command with file argument. So, I was trying to not cause errors due to missing file. But you're right, it's not really necesssary. > Consider factoring out a proc, like (untested, written in email): > Copied from mail, and done ... which also fixes the typo you reported. I'll commit this unless there are further comments. Thanks, - Tom --------------8D7709A2A480B3866D8B2527 Content-Type: text/x-patch; charset=UTF-8; name="0002-gdb-testsuite-Factor-out-dump_info-in-gdb.testsuite-dump-system-info.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0002-gdb-testsuite-Factor-out-dump_info-in-gdb.testsuite-dum"; filename*1="p-system-info.exp.patch" [gdb/testsuite] Factor out dump_info in gdb.testsuite/dump-system-info.exp Factor out new proc dump_info, and in the process: - fix a few typos - remove unnecessary "test -r /proc/cpuinfo" Tested on x86_64-linux. Co-Authored-By: Pedro Alves --- gdb/testsuite/gdb.testsuite/dump-system-info.exp | 42 +++++++++--------------- 1 file changed, 16 insertions(+), 26 deletions(-) diff --git a/gdb/testsuite/gdb.testsuite/dump-system-info.exp b/gdb/testsuite/gdb.testsuite/dump-system-info.exp index bf181469bd5..1831479265c 100644 --- a/gdb/testsuite/gdb.testsuite/dump-system-info.exp +++ b/gdb/testsuite/gdb.testsuite/dump-system-info.exp @@ -15,34 +15,24 @@ # The purpose of this test-case is to dump /proc/cpuinfo and similar system # info into gdb.log. -# Check if /proc/cpuinfo is available. -set res [remote_exec target "test -r /proc/cpuinfo"] -set status [lindex $res 0] -set output [lindex $res 1] -if { $status == 0 && $output == "" } { - verbose -log "Cpuinfo available, dumping:" - remote_exec target "cat /proc/cpuinfo" -} else { - verbose -log "Cpuinfo not available" -} - -set res [remote_exec target "lsb_release -a"] -set status [lindex $res 0] -set output [lindex $res 1] +proc dump_info {cmd {what ""}} { -if { $status == 0 } { - verbose -log "lsb_release -a availabe, dumping:\n$output" -} else { - verbose -log "lsb_release -a not available" -} + if {$what == ""} { + set what $cmd + } -set res [remote_exec target "uname -a"] -set status [lindex $res 0] -set output [lindex $res 1] + set res [remote_exec target $cmd] + set status [lindex $res 0] + set output [lindex $res 1] -if { $status == 0 } { - verbose -log "uname -a availabe, dumping:\n$output" -} else { - verbose -log "uname -a not available" + if { $status == 0 } { + verbose -log "$what available, dumping:\n$output" + } else { + verbose -log "$what not available" + } } + +dump_info "cat /proc/cpuinfo" "Cpuinfo" +dump_info "uname -a" +dump_info "lsb_release -a" --------------8D7709A2A480B3866D8B2527--