From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118734 invoked by alias); 2 May 2017 16:12:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117610 invoked by uid 89); 2 May 2017 16:12:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 16:12:21 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B518AC0EEE31; Tue, 2 May 2017 16:12:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B518AC0EEE31 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B518AC0EEE31 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 168B917B88; Tue, 2 May 2017 16:12:21 +0000 (UTC) Subject: Re: [PATCH v3] Use std::vector in lm_info_target To: Simon Marchi , gdb-patches@sourceware.org References: <614e9e92-fa8b-35f3-c15c-9dde043962e8@redhat.com> <20170430003455.13878-1-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <7652620c-1f87-8fe2-ee9a-50952166197e@redhat.com> Date: Tue, 02 May 2017 16:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170430003455.13878-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00018.txt.bz2 On 04/30/2017 01:34 AM, Simon Marchi wrote: > @@ -372,10 +364,7 @@ Could not relocate shared library \"%s\": wrong number of ALLOC sections"), > { > int bases_index = 0; > int found_range = 0; > - CORE_ADDR *section_bases; > - > - section_bases = VEC_address (CORE_ADDR, > - li->section_bases); > + CORE_ADDR *section_bases = li->section_bases.data (); I think this variable could be eliminated, and replaced by further below doing: - low = section_bases[i]; + low = li->section_bases[i]; in a couple places. Otherwise LGTM. Thanks, Pedro Alves