From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bj0bILa95mfLnh0AWB0awg (envelope-from ) for ; Fri, 28 Mar 2025 11:18:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HHhHfhwx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 73AB21E0C3; Fri, 28 Mar 2025 11:18:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E545E1E0C0 for ; Fri, 28 Mar 2025 11:18:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8B325382E2B3 for ; Fri, 28 Mar 2025 15:18:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B325382E2B3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HHhHfhwx Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A1643382E290 for ; Fri, 28 Mar 2025 15:17:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1643382E290 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A1643382E290 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743175061; cv=none; b=Tid4Q5X5+Ze1Xj754ZDBnYhBF3KbvQvvbAYUzKBq+GyW8308Kb4atDLxPwX/ljFskXHVnQpc7Gt1FhPtXE3r8b1gF5fCSnF2Y6K1ZwnKRKPVmoXxKKhi7bcvDaEd6oEBvm8hLcCyCvaPUPLFEhbQ5IafpuxzDTkNG2s0W41v3jI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743175061; c=relaxed/simple; bh=RmCSWyRSYj7ThE4127VBsGUghewMZjOxAJ+/EAtfanY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=eyKEI0cBSLE2KTchFZLR0ZNeRCdEWY6iZC1Su23G6kNmmLkc4Nnz2Y6gJUI3kWsUKjS80YHaYA4KMxJ84YMoeVuHSHo9X7lev+UBwc2+rBQZvVs+3GMiqGS52p/NDoUA100U63JKVDVT1fUKSnSAmK9/+i8BFbXzdgpL6pAhvus= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A1643382E290 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743175061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3QTIeZdqHNhVusg4/1Z/qxb5oz0YLwnWpuyGMBA9sZA=; b=HHhHfhwxU8H16Zdfu5A2ndO+8MIpGP6Y1qZPXtrLVA4i0qxgnCgRksyFust8CFPdemdHFs y/bMCKFJfITh6yXSqM3v+Wo2bsMzShpdEnt/xCHVf/vUHR+DyHjsjz8hPmegsGM5zlHAbk tdt6tZsqRbUIoKHHLIKagQgISXk75yM= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-XOF6oyAZPdSnKRqyhInUXw-1; Fri, 28 Mar 2025 11:17:40 -0400 X-MC-Unique: XOF6oyAZPdSnKRqyhInUXw-1 X-Mimecast-MFC-AGG-ID: XOF6oyAZPdSnKRqyhInUXw_1743175059 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-225107fbdc7so42405745ad.0 for ; Fri, 28 Mar 2025 08:17:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743175058; x=1743779858; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3QTIeZdqHNhVusg4/1Z/qxb5oz0YLwnWpuyGMBA9sZA=; b=AWfImtT9sQOsf5j7ANvBsLS+GYcUCcdC42RCX+cWo/8HTKbaY57zeqGzMpQZF8yjfE 2cCKdS52zPW2n2f/EkVZcz7HZeia5VsjrKASp5abcnVlljwgwo9h346FW9EVoG2736rN ywiX6XrQh/QvP2CIG7u7tq0F2QvXCUXWVicybBNdYnSSIgI4Y92jw8uuq2INQRVYCzl5 fwd9D1PujWh/p+QbDu2sXC9TnQkj1A66Hyv8wPHyXFz95Uk4jXpcD8/HvBrrMtig7fkI dSon3mxiTUjiFr25tsGirkUL8OV/4EKC2DEfGzgrvrZ0ZVN3ik6vnJ3YcIqgjG5OURDM TTRA== X-Gm-Message-State: AOJu0Ywk019B33dXF0Ks2O114jVXCcbFuyNTFKCI6Uwoe2L4FPZ0QwnS VkBswPZQvdtReVg+ru+YiJ09cVycFeAWY8ASEh1DPO9u8xe2TVTnMk1pK+/3iAUQbSORiwZBdk3 UtgbrP6HJH5t17K9r36k06WhAWoeWe31oBHmCQ0JmjRx9PVX93pKT9Xm68NiMv6Slc9Y= X-Gm-Gg: ASbGncso/ezZzEYHqUxQMljUUW3xy/VDkCp/sTJBq/o2fEcp+s7FOzbuMAiyoCJwGlW +Q4rUAZvGQ9HUKB5tKjLjLd7jPeevUlDSHdH4z/U1iXurhGpiyMNtgs5u+frfgYCkHDh+xi1A6l OiuoFDp201a/9lWhJb0rrh1GnqTJJfAuEvTuhaRjYGkionS2vrkyXY6Kha9S1J5LSYyOBJW71Pu B1GrWfDTGIQpha1l5ZaTijVPxZusGAGTZWDGKJsa+Mawc/wBGXzg2Va8By18Q8eFzspfGHgq7b/ s/O8XG1CVqcaihLXTYIG X-Received: by 2002:a05:6a00:3392:b0:736:a7e3:d4ab with SMTP id d2e1a72fcca58-73960e0b62emr10994042b3a.5.1743175058454; Fri, 28 Mar 2025 08:17:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUpUbABSGe4RI3XuariKidSlstShptpHmlKntEUt+RKacfd1L3UHnB5JqzjUVb8VQ/LOAqCQ== X-Received: by 2002:a05:6a00:3392:b0:736:a7e3:d4ab with SMTP id d2e1a72fcca58-73960e0b62emr10994003b3a.5.1743175057792; Fri, 28 Mar 2025 08:17:37 -0700 (PDT) Received: from [150.1.200.127] ([172.56.105.77]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73970e22346sm1872334b3a.46.2025.03.28.08.17.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Mar 2025 08:17:37 -0700 (PDT) Message-ID: <764b45b5-f1ba-4e93-92dc-e1a0388aa0dd@redhat.com> Date: Fri, 28 Mar 2025 08:17:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix gstack issues To: Tom Tromey Cc: gdb-patches@sourceware.org References: <85d8b0e904d7893d55db6531edb64d4a16062a46.1743090890.git.keiths@redhat.com> <87bjtmuypo.fsf@tromey.com> From: Keith Seitz In-Reply-To: <87bjtmuypo.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: x-RJ_pEpJCw-acoj2sjmpTyGGdsNC3VPTEOqCEa4C3o_1743175059 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/27/25 11:15 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> With commit fb2ded33c1e519659743047ed7817166545b6d91, I added > Keith> Fedora's gstack script to gdb. Some issues have arisen since > Keith> then, and this patch addresses those issues: > > Keith> . As Sam James recently noted[1], PKGVERSION and VERSION > Keith> need to be quoted. > Keith> . A Fedora user reported the misuse of --readnever, which > Keith> causes gstack to omit filename and line number information in the > Keith> backtrace[Red Hat BZ 2354997]. > > Makes sense to me. Thanks for doing this. > Approved-By: Tom Tromey Thanks, Tom. I've waited until this morning to push, fearing that various CIs would detect something, but I think there's been time for that, and I've pushed the patch. Keith