From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eNF3DH53rl+lbAAAWB0awg (envelope-from ) for ; Fri, 13 Nov 2020 07:09:34 -0500 Received: by simark.ca (Postfix, from userid 112) id 2EE4B1F08B; Fri, 13 Nov 2020 07:09:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CFBA31E58F for ; Fri, 13 Nov 2020 07:09:33 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EF9E43898037; Fri, 13 Nov 2020 12:09:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF9E43898037 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1605269373; bh=Q3h6bAAITbc5LeyEOoQu5+b6NF9hbXM2juLnT+yfjUk=; h=To:References:Subject:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=X5t9niAEOVVHFpOpx8x56irKMkdyAA11klCnEFKNekE13v9ATg/hrZaW5z+P8Cc2V fdNZTmxYAsq/ULOphAr62ordjIT2OvaQC9zerstSlEywaEeDQ288S3GKlwIxaLqYQq KdOiNuf37lzAZyVujfaS19iJsOjyhZyK8nS3F+Ds= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 1B17A389802B for ; Fri, 13 Nov 2020 12:09:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1B17A389802B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-IybcGhYaNiu3TlFXxiD39g-1; Fri, 13 Nov 2020 07:09:28 -0500 X-MC-Unique: IybcGhYaNiu3TlFXxiD39g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 04A141006C83; Fri, 13 Nov 2020 12:09:27 +0000 (UTC) Received: from [10.36.114.162] (ovpn-114-162.ams2.redhat.com [10.36.114.162]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF1DF6266E; Fri, 13 Nov 2020 12:09:25 +0000 (UTC) To: Simon Marchi , Alexander Richardson References: <20201111092021.5428-1-Alexander.Richardson@cl.cam.ac.uk> <52dc77e4-ff34-be60-13af-f580d3cf77e7@simark.ca> Organization: Red Hat Subject: Re: [PATCH] GDB: Fix detection of ELF support when configuring with -Werror Message-ID: <76418730-3d48-b0f1-b5cc-5626d3c2feae@redhat.com> Date: Fri, 13 Nov 2020 12:09:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Nick Clifton via Gdb-patches Reply-To: Nick Clifton Cc: Binutils , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi Simon, >> that's what I originally planned, but it seems like elf-bfd.h (and the >> headers it includes) don't include any system headers. Since I'm not >> familiar with any of this code I assumed this was intentional. >> >> Alex >> > > Hi binutils@, > > Could you check the discussion above? Is there a reason elf-bfd.h > doesn't include the header file it needs to use the functions it uses? Essentially this is because elf-bfd.h is internal to the binutils sources, and not expected to be used elsewhere. So any code that includes it is also expected to include the sysdep.h header which does then include the needed system headers. The idea is that all of the configuration time decisions about which system headers to include are confined to one file - sysdep.h - rather than having to be copied into all header files. Cheers Nick