From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29899 invoked by alias); 23 Nov 2016 20:58:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29871 invoked by uid 89); 23 Nov 2016 20:58:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_05,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Baldwin, baldwin, HX-PHP-Originating-Script:rcube.php, Hx-languages-length:632 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Nov 2016 20:58:12 +0000 Received: by simark.ca (Postfix, from userid 33) id 5A9481E141; Wed, 23 Nov 2016 15:58:11 -0500 (EST) To: John Baldwin Subject: Re: [PATCH 1/3] Fix mismatched struct vs class tags. X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 23 Nov 2016 20:58:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20161123200652.89209-2-jhb@FreeBSD.org> References: <20161123200652.89209-1-jhb@FreeBSD.org> <20161123200652.89209-2-jhb@FreeBSD.org> Message-ID: <7640c59773727c1d5d784f18663312ed@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00687.txt.bz2 On 2016-11-23 15:06, John Baldwin wrote: > The 'collection_list' and 'number_or_range_parser' types were converted > from structs to classes, but some code still used 'struct'. Fix all > references to use 'class' which fixes -Wmismatched-tags warnings issued > by clang. Whjen using the type in a parameter or variable declaration, should we simply drop the keyword? For example: - struct collection_list *collect; + collection_list *collect; That's the approach I took in my upcoming C++ patches, so I hope it's ok :). I have also dropped the "enum" keyword when possible.