Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
To: jiangshuai_li <jiangshuai_li@linux.alibaba.com>,
	gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] gdb/csky support .reg2 for kernel 4.x and later
Date: Tue, 9 Aug 2022 09:56:44 +0200	[thread overview]
Message-ID: <762dd14c-01a5-79e8-6ec7-aae38b8813eb@suse.de> (raw)
In-Reply-To: <59e8ee98-af6f-4254-befe-de11cbd0e69c.jiangshuai_li@linux.alibaba.com>

On 8/9/22 04:29, jiangshuai_li wrote:
>  >On 8/1/22 04:40, Jiangshuai Li via Gdb-patches wrote:
>  >> +      warning (_("Unknow size %ld of section .reg2, can not get value"
>  >> +                 " of float registers."), len);
>  >
>  >This broke the build on the gdb-armhf-ubuntu20_04 builder ( see
>  >https://builder.sourceware.org/buildbot/#/builders/170/builds/246 ):
>  >...
>  >../../binutils-gdb/gdb/csky-linux-tdep.c: In function ‘void
>  >csky_supply_fregset(const regset*, regcache*, int, const void*, size_t)’:
>  >../../binutils-gdb/gdb/csky-linux-tdep.c:194:18: error: format ‘%ld’
>  >expects argument of type ‘long int’, but argument 2 has type ‘size_t’
>  >{aka ‘unsigned int’} [-Werror=format=]
>   >  194 |       warning (_("Unknow size %ld of section .reg2, can not get
>  >value"
>  >       |
>  >^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  >   195 |    " of float registers."), len);
>  >...
>  >
>  >There are uses of %z in gdb, but very few, so I suppose the way to fix
>  >this is to use %s and pulongest.
> 
> Thanks, i have used your suggestion to fix it, a patch has been committed.
> 

Thanks for fixing it, and I see the gdb-armhf-ubuntu20_04 builder is 
back to green status, yay !

Thanks,
- Tom


  reply	other threads:[~2022-08-09  7:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  2:29 jiangshuai_li via Gdb-patches
2022-08-09  7:56 ` Tom de Vries via Gdb-patches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-08-01  2:40 Jiangshuai Li via Gdb-patches
2022-08-08  7:32 ` Tom de Vries via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=762dd14c-01a5-79e8-6ec7-aae38b8813eb@suse.de \
    --to=gdb-patches@sourceware.org \
    --cc=jiangshuai_li@linux.alibaba.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox