From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by sourceware.org (Postfix) with ESMTPS id 3D9F23AAAC27 for ; Fri, 17 Jul 2020 14:20:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3D9F23AAAC27 Received: by mail-qv1-xf43.google.com with SMTP id h18so4291146qvl.3 for ; Fri, 17 Jul 2020 07:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C8+u4xKSPA3wXokiHckQEFFJbbLzAoRvuW17QPULOyo=; b=RFF2NnYOakbpKboECb+9wVSl2EMb1Zw1zJyOL9U6+MCNIUK0VqpVCP42G4MMSLcEbv CFF1Cj+AmHn1z9+SaNZOKqIWGlvToqnBlvAhH5TfQFnEb8puJ+lPLLvITOFRfkGg2pFR BemXx6UZ1g83GXvPQBN9znZXwi/vm1btymtrqxn4jJ4jAnaK1bu6SrZEAtDZevTT5bZH b3alQ7BLspsCER6Gn438/fy4Wy5pWPACAlUUYD0hh8mXpvV6bGLQqMTATerVLl0bQPyz he9B6Mzrth38KwOXVJ/JqRvSphn08CTL8z9UUwmF4ZzBqLWqLCWVhY+VTUzKUnZSNyly JLjw== X-Gm-Message-State: AOAM532u9diTFOFQYcU+T74beAASTe3EhFgjidxFtR31IvPWZDzAuVFe kNAdDpockpR8BCu3zW9vjYkTfw== X-Google-Smtp-Source: ABdhPJyH7RfFjDEzbk61CO+NHF8RBcW69Xr+I+aQ7T4WI/VnjYR3Uv+V4Igr80Tyhq/Mqg3xBOSROA== X-Received: by 2002:a05:6214:734:: with SMTP id c20mr9451260qvz.118.1594995608773; Fri, 17 Jul 2020 07:20:08 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:82c3:30f9:c348:a8bc:88d6? ([2804:7f0:8283:82c3:30f9:c348:a8bc:88d6]) by smtp.gmail.com with ESMTPSA id j7sm11116378qtd.53.2020.07.17.07.20.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 07:20:08 -0700 (PDT) From: Luis Machado Subject: Re: [PATCH 07/23] Documentation for memory tagging remote packets To: Eli Zaretskii Cc: gdb-patches@sourceware.org, Alan.Hayward@arm.com, catalin.marinas@arm.com, david.spickett@linaro.org References: <20200715194513.16641-1-luis.machado@linaro.org> <20200715194513.16641-8-luis.machado@linaro.org> <83k0z2k7pi.fsf@gnu.org> Message-ID: <762da561-1388-5e41-c1a0-958d5611c1ff@linaro.org> Date: Fri, 17 Jul 2020 11:20:05 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83k0z2k7pi.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2020 14:20:10 -0000 Thanks for reviewing this Eli. On 7/17/20 2:54 AM, Eli Zaretskii wrote: >> Date: Wed, 15 Jul 2020 16:44:57 -0300 >> From: Luis Machado via Gdb-patches >> Cc: catalin.marinas@arm.com, david.spickett@linaro.org >> >> +If the number of memory tags, @var{N}, is greater than or equal to the number >> +of memory tag granules, @var{G}, only @var{G} tags will be stored. >> + >> +If @var{N} is less than @var{G}, the behavior is that of a fill operation, >> +and the tag bytes will be used as a pattern that will get repeated until >> +@var{G} tags are stored. > > The symbols inside @var should be lower-case, per our conventions. > They look better in the printed manual that way. I've made them lower case and updated their names to nt and ng. I also updated another offender in the packet description (@var{mXX}). > >> +For AArch64 GNU/Linux systems, this feature also requires access to the smaps >> +file in the proc filesystem so memory mapping page flags can be inspected. > > "proc" should have the @file markup (and should probably be "/proc"?). > > The patch is OK with those nits fixed. > > Thanks. > I rephrased it to read "...access to the @file{/proc/@var{pid}/smaps} file...". Thanks!