From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90556 invoked by alias); 26 May 2016 18:08:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90484 invoked by uid 89); 26 May 2016 18:08:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=2417, factories X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 May 2016 18:08:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DA3FC116DF6; Thu, 26 May 2016 18:08:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4QI8EoO021817; Thu, 26 May 2016 14:08:14 -0400 Subject: Re: [PATCH v3 06/34] Introduce interpreter factories To: Simon Marchi , gdb-patches@sourceware.org References: <1462538104-19109-1-git-send-email-palves@redhat.com> <1462538104-19109-7-git-send-email-palves@redhat.com> <573CC052.6000502@ericsson.com> From: Pedro Alves Message-ID: <7619e233-6c73-c09c-fce7-abe5cef74ea3@redhat.com> Date: Thu, 26 May 2016 18:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <573CC052.6000502@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00463.txt.bz2 On 05/18/2016 08:19 PM, Simon Marchi wrote: > On 16-05-06 08:34 AM, Pedro Alves wrote: >> diff --git a/gdb/interps.h b/gdb/interps.h >> index f0badc5..3065fdf 100644 >> --- a/gdb/interps.h >> +++ b/gdb/interps.h >> @@ -24,6 +24,17 @@ >> >> struct ui_out; >> struct interp; >> +struct ui; >> + >> +typedef struct interp *(*interp_factory_func) (const char *interp, > > Nit: > > In the functions of this type ({cli,mi,tui}_interp_factory), this parameter is named > "name", so you could as well name it "name" here as well. I've done that now. > >> + struct ui *ui); > > Even in the final result (with all patches applied), none of the factories > use the ui parameter, is it expected? I think that at some point I thought of storing a pointer to the UI in the interp, but then ended up not needing it. I've removed that parameter now. I'll post a patch in response to your other email. Thanks, Pedro Alves