From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id H9TqJdispF/SAgAAWB0awg (envelope-from ) for ; Thu, 05 Nov 2020 20:54:32 -0500 Received: by simark.ca (Postfix, from userid 112) id 8E6EE1F08D; Thu, 5 Nov 2020 20:54:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0ABAB1EFBB for ; Thu, 5 Nov 2020 20:54:32 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 94C3C3A4703F; Fri, 6 Nov 2020 01:54:31 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B50873A4703F for ; Fri, 6 Nov 2020 01:54:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B50873A4703F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 560951E552; Thu, 5 Nov 2020 20:54:28 -0500 (EST) Subject: Re: [PP?] [PATCH] Remove objfile parameter from abbrev_table::read To: Tom Tromey References: <20201104231056.30808-1-tom@tromey.com> <87tuu3tgyd.fsf@tromey.com> From: Simon Marchi Message-ID: <7616ef08-4f0e-e3e9-d657-3b2868c65780@simark.ca> Date: Thu, 5 Nov 2020 20:54:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <87tuu3tgyd.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-05 8:24 p.m., Tom Tromey wrote: > Simon> LGTM, though I'd add a note in the abbrev_table::read comment, that the > Simon> caller is responsible to make sure the section is read in. > > This part was in the patch: Oops, sorry about that :S. Simon