From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BUhwEZ/2CWDAFQAAWB0awg (envelope-from ) for ; Thu, 21 Jan 2021 16:48:15 -0500 Received: by simark.ca (Postfix, from userid 112) id 2C8141EF80; Thu, 21 Jan 2021 16:48:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AD6141E590 for ; Thu, 21 Jan 2021 16:48:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 11A11382D83E; Thu, 21 Jan 2021 21:48:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 11A11382D83E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611265693; bh=YxsKw6kQoiJtTU6vd/ceR0nsjqchTNQOYplb96UOcdg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=pGVKr0ray8WCaJy158bJ1OLH1auHBBbMvb2ZaR23gPMWvxIa8qtmnq6uyECiqeP91 0sJAODA7MFlURN+oas23wQuZb0FG9qzOGm0qL8mgIFvsrZCYRv27QC3ALAHe8CvkPS rvnhInPNn7EEWZRCqp3KczmkBaviYgyh+uC/kXSs= Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-eopbgr760057.outbound.protection.outlook.com [40.107.76.57]) by sourceware.org (Postfix) with ESMTPS id 32637386186E for ; Thu, 21 Jan 2021 21:48:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 32637386186E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LkGZ3Md106Wfm9BSJ8uPpozQr157pJyFiBmXxGfaCQGY5puIQ8hD9JW2UK4Eq4Uk+/czKrWy+wBr1Fb4iDrtMxOBC8754GxS7z4Z3BaYn1FGkDwfgCLcYElc17V9OOrcLnQrQA4/EFwuZxeClLIyZS+QGpVpXHi6CNqXF2dxtmd0KhHxx5/Zm8c+fZleMd79JgNB37qdQ78xi6lajhTn3HlzPdVMaJBdX6Qt5T0CZUIC9fHfOazsaR16LKcGUMx5fgz96E/JCpStzLdbhm2D3VhjCCYm/HHjAUxjacCPdRZEf6mZIeIe2UYtUJzmbSF2S4BB9yqjV83lKl9S2IpoQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YxsKw6kQoiJtTU6vd/ceR0nsjqchTNQOYplb96UOcdg=; b=UN62N7yZ1qbaQ9mHRZbtio1hAA45UQAvU5WzGZSIM6ZXNQSgFDlQn+y3wLwnhUz5yXRdc+OdOO7V7STENoEO7ACj5P/tImNLfaaJM8uAE1lwCb2HjfSvYu4cFVWLyLfvP+qCGG+RUkv8Tbk/mbA4dTk5nuZzphujYAw5uy00ZOdzy2x7eIulZDa67W28aCGp0sLI8aHvqv/r34PXBqwna1Hn/f1H8E9n3fTLAq3OBCps7jGXAtVkrSiOjJ1LdT5kVyQXF0+FvSLGp1hzIul43mVg914gHMCg1qSobE/DiPHGBcBOF/IlPOKeVN5yoEoHA8Q080aCzGCAgMGTgRjBDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB3561.namprd12.prod.outlook.com (2603:10b6:5:3e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Thu, 21 Jan 2021 21:48:08 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3763.015; Thu, 21 Jan 2021 21:48:08 +0000 Subject: Re: [PATCH 01/30] Replace the symbol needs evaluator with a parser To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-2-Zoran.Zaric@amd.com> <87bldirnwm.fsf@tromey.com> Message-ID: <76137c22-040d-9b8b-b3ad-c7b5b0d2fe14@amd.com> Date: Thu, 21 Jan 2021 21:48:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <87bldirnwm.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [2a00:23c7:5a85:6801:988d:82ea:7d44:e02c] X-ClientProxiedBy: LO2P265CA0424.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::28) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:988d:82ea:7d44:e02c] (2a00:23c7:5a85:6801:988d:82ea:7d44:e02c) by LO2P265CA0424.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12 via Frontend Transport; Thu, 21 Jan 2021 21:48:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a12b509f-06fe-49a8-afb5-08d8be563d55 X-MS-TrafficTypeDiagnostic: DM6PR12MB3561: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dflhgr3AzuSl1xF7Rr7CJqosNKtisretI1Y7EVRfof99oAre9D3TCBXW8cjOk9xBbzbYleO/0LUFnavq2X52tGwwJvxTUc9hsdtwZXIfd+HQFtYwJH3pGKmW4OqsrakQjiYsuWhX9h3wMw4/ltuIgt3UMheF1NzCiYWmAEc+pUTZ6huIvvf2nzGPdqc1diypluAqWHKtycPAhvqFUsLWvEn8UIr+sm58SWsZtmy7m/qccE59yk4zOzGZD9Uz2eQmZKaEPOb09V/FO4VdjoDo7P9HFOaWP26DHE+1hm9PGtM+T82ddOrDqcI5QzkAlyOyN1sRYmlZI3hMWpLKHUUZPfxqnQ+1JabtIQygXOaM8vJkgIsL50M9RdOFKyL9AWmtGutfSqWWEKVmwBBzGdonrQ1hACKJKuCq+ot4wkh9imoepqg+e4DxkDm3fNnKIk4NV/uREgrw2em4wmDra5yHoeNR847+lcDjTp+7IBiAojcSLaXsrD5QqEktE2q2hnfokhGsi3IwBW6mfm/teHsNPmVKyW9BOnsrLAUvcakmBtGpG/Q5YjsHDNphz+0njUAcwuUpukOayC788qDRaGdulE8I62TWvFNSvU6gFqmOdwg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(36756003)(6666004)(186003)(66946007)(66556008)(8676002)(5660300002)(8936002)(6486002)(66476007)(2906002)(2616005)(52116002)(86362001)(31686004)(31696002)(478600001)(316002)(16526019)(110136005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bXc5cm9CWnlpTkhNUTRTeklmbk5oTHBlam5JbkwrR0k4eXFMNlZVWTNtQ1U1?= =?utf-8?B?bU52VG0yQTJIeVRIVUYzQUw2SmtoT3NRMXVrSk01OTl1am95Ylgwck5xcFVs?= =?utf-8?B?T2hsM3JxQTl4KzRROUp6WDIzTEZQKzlrakVPN0wrNFJ4aXNKYk1FclEyUDVP?= =?utf-8?B?TWt5blZ6ZkhZZ05Pd2xVTmFVSnpGU2MyWVFLVzlOcXJOY3oxbEgxYlk1N2JL?= =?utf-8?B?Nkd6UzdvbjEybjd0OXRnVG9SUWtybUZoWldNUk05aVJNVGlOcy96enJ3czRH?= =?utf-8?B?YU5JL25Kb05xM0RSem4vTFlRZzcrYmVDcG12blk2SEIyTERtRkxtdjRrNTlk?= =?utf-8?B?NG1kbGVzY3hicEw4RFJkR2NWRkszdzdIQTJNYzhsT0ExY3dTU25vZUNvbW1r?= =?utf-8?B?Snh3OWlVdEZLQ0JMMjRIbGEzSDBRN2dtRENTWVlNek9meW8yaUdXajlwUVE2?= =?utf-8?B?d0Q4ZW0xVlZpTFpoMVo5dTVvNm1mY0o0cDcyUWhvZUlRaGxmR3BJWHBqbmRs?= =?utf-8?B?VVdWbk1WYVgxSm1TeDNreEQ4OW5XK01PYXdKWTF4c3FzV3RxNG1BQlgyQ1NH?= =?utf-8?B?YWFMalg5ckZpSVlaWU8wTU1LTmpBU0pTcVZPNklkcEpEL3ZTT08rNWFLWDVF?= =?utf-8?B?QWM4VzcvTUhSck5KK1FiUDd5WjJ6eHBSUVltMlJQUUZsNlJaV2I1dHRHeHNU?= =?utf-8?B?U2RiZmhqL2NobC9OcGVZNGh2ZHcwMU9xNlUwMy9YdXFERGJ2czJwTjdiTWpr?= =?utf-8?B?RVRSNTJhTkVpKzBiNFZkZFZVL0JxOFpvUnNSZ1RJYWFaNDIrcGx5VkFiTUdo?= =?utf-8?B?RjlqeDlFQVBYN3U3T1Y0TG05VDNwY2U4ZGxBemMveHVsd05BNHltRHRNTGFF?= =?utf-8?B?a251SDFrRUpubGpRWE5pcFU5YU5YUll5ZXR5a3RrY2g3ck1ON2RPRFlDZFdP?= =?utf-8?B?dHAvS0pvYVoyU1dNMHR5RVVDendRTVJ5UmZTRUdyK1JPb3UyRG50T1c5eVlI?= =?utf-8?B?NThBRXI5Qk5OTWVVN2h6NUFGci9DbUE1RHlpK2FGWDk0c0ZxdmR5eDc1VHBn?= =?utf-8?B?eTdQNitnbTd1MGQvMzJLZ3RPSUJES25BN0pRU0h5M3A4WXYrQmVwRmN6OW5H?= =?utf-8?B?dVE2NEN0RWFEeTNIUzZSWU9wMjZZcDE0Ynh5RVRvalZmNVJBcXAzUXMwWHdS?= =?utf-8?B?bDJ1LzJ1VWlJTUFObFpFK0REUHlWUS9NeGdPUENUaTVSUUh6bE42Q3djVXhX?= =?utf-8?B?OERBdERkQkZjMjdWcmw0TUNkQ1p3aVdVZ1VKb09xQnJuMm5IQmw5TUorMFRE?= =?utf-8?B?UHJjemJkZ3VVbkNjcVgxME9qTCtPM1d6QWpaUGxQdjBBdXhXZVBqMU4yRDBN?= =?utf-8?B?K2N6cDZCR2xhY0tkaE5XTjF4dU55VnBJVkhYejgzL04zR0hmblRmaGJpRXVB?= =?utf-8?Q?VmgplYFB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a12b509f-06fe-49a8-afb5-08d8be563d55 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2021 21:48:07.9715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RZRxGb2BCqhVfZfZzOGKVaHEklAa8Rc5Jc8wlvQVEaKQFgrBsW9LWTTTBOSBE58ykyDItyXdwJMGwTgju1bvew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3561 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > Zoran> + while (op_ptr < expr_end) > Zoran> + { > Zoran> + enum dwarf_location_atom op > Zoran> + = (enum dwarf_location_atom) *op_ptr++; > Zoran> + uint64_t uoffset; > Zoran> + int64_t offset; > > IIUC this is the same as the earlier patch, that marches through the > bytecode linearly. I think I sent comments on the earlier submission. > > Tom Thank you for looking at my patches Tom. I realize that they require a fairly bit of effort considering the area in gdb that they are addressing. We ended the previous discussion thread on an agreement that this is not the best solution for the case when producer "hides" some information inside of the DWARF expression. I am not sure if this is even a reality with the existing compilers, but it is a valid concern. At this stage it is hard to solve that issue, but at least we would solve the issue of a valid DWARF expression breaking the symbol needs evaluator. Would you be OK for this symbol needs change to go in as is and then solve the other issue when the evaluator redesign is accepted? With the new evaluator design, it should be a straightforward thing to get rid of this symbol needs expression parser. Zoran