From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5Ey9CfSxD2izjwoAWB0awg (envelope-from ) for ; Mon, 28 Apr 2025 12:51:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745859060; bh=fkbxxRKI8/aqYTfUyRzakZflG44uoFJDNkX2R00we84=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NF0SkLEC5hBMk1MfT+cNg/FH3hhIjggaTf4pnbxNgURiF5wprIeXlPqh2SsDn7D+k sl/uPQrSlXnbOwepqcsxw4zqrJYwBicYr07Pa6Ni4v7eXjkt9Zp1GGPj1z4a4H5FEw kGlasNTP22FVhn55gz4k07fktgkiQ3AuXPfoMr1g= Received: by simark.ca (Postfix, from userid 112) id 14E691E10E; Mon, 28 Apr 2025 12:51:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=gMqE6YNx; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=pOa0EmFx; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8D76F1E0C0 for ; Mon, 28 Apr 2025 12:50:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 050093858031 for ; Mon, 28 Apr 2025 16:50:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 050093858031 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=gMqE6YNx; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=pOa0EmFx Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 43DDE3858406 for ; Mon, 28 Apr 2025 16:38:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43DDE3858406 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 43DDE3858406 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745858329; cv=none; b=kgmWzpbLnMOjeZCTE3va1o8o4tH0bdwbGMvmtFGulpIcbySaLfWEceL3tllSECH22n2zIlrXYbGe5qlobay3bheFCXMb3JZjzHPLUeiUCiPW5T+5eamAzR4zEUn40OCW8TJ8muHC4WnqulifQ5QC++wv3pbHvxuhfqyVMytPd4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745858329; c=relaxed/simple; bh=fkbxxRKI8/aqYTfUyRzakZflG44uoFJDNkX2R00we84=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=GaYrQfSU/s2k3D9WCpBpe54QVN0BTPaicuR5A2faahHx8+PRrCVuBTOE7nyi3l88U9a6pfR+NkaJylhD7DWkYkb+Al4XI/6/fkaMMelXS3nbvMnu7d9H1oZYvI4DbXv5DcRWwqn/2XPPGe8fDaMwlciII4NdqEes9oUafMmKvMM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43DDE3858406 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745858328; bh=fkbxxRKI8/aqYTfUyRzakZflG44uoFJDNkX2R00we84=; h=Date:Subject:To:References:From:In-Reply-To:From; b=gMqE6YNxWG8oUwAr7NyeaJomF+NyT/0HJhR6HWQTqnox9os5ATtHeUae/zy4ECbt2 L6HjItI55Z7DHrfxKots22HeHo9ipkNsLKhj51otXAenVLxmkIHxMyg9ankeiSGdhV ThTg8Y1O+kKwaUzIut0wLqrfcTvrwlpZ2JaMIfNw= Received: by simark.ca (Postfix, from userid 112) id F1A9E1E114; Mon, 28 Apr 2025 12:38:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745858327; bh=fkbxxRKI8/aqYTfUyRzakZflG44uoFJDNkX2R00we84=; h=Date:Subject:To:References:From:In-Reply-To:From; b=pOa0EmFxlRsNawwqc4ZI6DLwEGA129edkCIINX4k0O1WP4oQjo/1rnFcmD4KUc63D Sd5GEm/7Mkui/yd63yu6wF7urQM3BzIDDPSkO7ZBW+tXAiqJ2Kte1T96hF4G+zmPfl 6zQYe0OwSnCxj2OpBVkVr2IlDvILVUhD7x8bBn3I= Received: from [172.16.0.106] (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2C0B11E0C0; Mon, 28 Apr 2025 12:38:47 -0400 (EDT) Message-ID: <76039ea9-ac37-4bdc-8580-fd5a3be76373@simark.ca> Date: Mon, 28 Apr 2025 12:38:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb] Handle nullptr stream in gdb_flush To: Tom de Vries , gdb-patches@sourceware.org References: <20250425171845.9934-1-tdevries@suse.de> <20250425171845.9934-3-tdevries@suse.de> <0eedfe61-5b44-45c2-806c-493f75bb881b@simark.ca> <74728484-0770-408b-b877-2b6f827d1e2c@suse.de> Content-Language: fr From: Simon Marchi In-Reply-To: <74728484-0770-408b-b877-2b6f827d1e2c@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/28/25 12:32 PM, Tom de Vries wrote: > AFAIU, I've added it where it's needed. > > Can you tell me where you think it's needed? I cannot tell from your comments. Based on the stack trace in your commit message, it would be in gdbpy_flush. If I understand correctly, this call site is special because it can be called when GDB is getting torn down, and I suppose because the streams are closed before Python gets finalized. Most calls to gdb_flush are done on streams that we know are not nullptr/not closed. Simon