From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gLIVHKi9EGjS4wsAWB0awg (envelope-from ) for ; Tue, 29 Apr 2025 07:53:12 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b0+00+Ao; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pEZ7cPKZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b0+00+Ao; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pEZ7cPKZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6E2DB1E10E; Tue, 29 Apr 2025 07:53:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 172EE1E089 for ; Tue, 29 Apr 2025 07:53:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA22B3858C2D for ; Tue, 29 Apr 2025 11:53:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA22B3858C2D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b0+00+Ao; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pEZ7cPKZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b0+00+Ao; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pEZ7cPKZ Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 08F4B3858D1E for ; Tue, 29 Apr 2025 11:52:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08F4B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08F4B3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745927563; cv=none; b=HIGQ08ETrJrm6MceJ1h9npj4PsTNEbW1+8GRF63txNDjB7cJa7BL4x4b8hITr4diGLdSunenDs7b/wlWf3C3oQq71O/sfnV34l07d96BiakHFIqknePqE8i0B6rDB5YqYvdabg9LQBYOSUpMiQ4232dBVeqJOodwg4ZB2XgkE64= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745927563; c=relaxed/simple; bh=2JpsGkwnE0ea/aOE99IUgOjauq+ShGz6FyKTsofFR14=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Nr7pH4FkHXqhANUXOzu5qmnCJmfRzQP50iOphNP/kWYUVofyg2QAzVgQDuV+l7kJI/tCyqxePJhR9vURxIrw3BnjNAPx704U0AScOcqTDdVnhcLKe2LKZgVPeq+B6Tt2iOFBdJUvlOrqvr9GyC3f/JYl3gglNgDQhqZedt1AWSg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08F4B3858D1E Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0B6101F391; Tue, 29 Apr 2025 11:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745927562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qziZbgeJ3Iujp2tv5syYggMpMh8U9p8vup6bk2cIgBA=; b=b0+00+AoBU/WmlQtjy0hmDqe6kT8NAkGGCCIDjYEk9BEDg2OUpp8Gkbyyl74tcCP7zpP+3 pXmos3MXd5Nccl5x2QnKw4QuzXF377DCg66511wSZbeyEwTc7dOHza7NQO6Mo4LP/wt5a6 NXqye3BC7q8S8oUrEtB5vqWws3G2QHw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745927562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qziZbgeJ3Iujp2tv5syYggMpMh8U9p8vup6bk2cIgBA=; b=pEZ7cPKZwL185m9PUFzZ0Pf5fLTeLRJ4jGCNoFLhgFmIQWWXH33OYL6/8KW/kKvs/4LsFc SA+ellGcWt8aCCCg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745927562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qziZbgeJ3Iujp2tv5syYggMpMh8U9p8vup6bk2cIgBA=; b=b0+00+AoBU/WmlQtjy0hmDqe6kT8NAkGGCCIDjYEk9BEDg2OUpp8Gkbyyl74tcCP7zpP+3 pXmos3MXd5Nccl5x2QnKw4QuzXF377DCg66511wSZbeyEwTc7dOHza7NQO6Mo4LP/wt5a6 NXqye3BC7q8S8oUrEtB5vqWws3G2QHw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745927562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qziZbgeJ3Iujp2tv5syYggMpMh8U9p8vup6bk2cIgBA=; b=pEZ7cPKZwL185m9PUFzZ0Pf5fLTeLRJ4jGCNoFLhgFmIQWWXH33OYL6/8KW/kKvs/4LsFc SA+ellGcWt8aCCCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E2F111340C; Tue, 29 Apr 2025 11:52:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Mm2ZNYm9EGisSQAAD6G6ig (envelope-from ); Tue, 29 Apr 2025 11:52:41 +0000 Message-ID: <76020041-03bc-4f11-8988-0d10ed01eee3@suse.de> Date: Tue, 29 Apr 2025 13:52:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb] Handle nullptr stream in gdb_flush To: Simon Marchi , gdb-patches@sourceware.org References: <20250425171845.9934-1-tdevries@suse.de> <20250425171845.9934-3-tdevries@suse.de> <0eedfe61-5b44-45c2-806c-493f75bb881b@simark.ca> <74728484-0770-408b-b877-2b6f827d1e2c@suse.de> <76039ea9-ac37-4bdc-8580-fd5a3be76373@simark.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <76039ea9-ac37-4bdc-8580-fd5a3be76373@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.989]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/28/25 18:38, Simon Marchi wrote: > On 4/28/25 12:32 PM, Tom de Vries wrote: >> AFAIU, I've added it where it's needed. >> >> Can you tell me where you think it's needed? I cannot tell from your comments. > > Based on the stack trace in your commit message, it would be in > gdbpy_flush. If I understand correctly, this call site is special > because it can be called when GDB is getting torn down, and I suppose > because the streams are closed before Python gets finalized. Most calls > to gdb_flush are done on streams that we know are not nullptr/not > closed. Done in a v2 ( https://sourceware.org/pipermail/gdb-patches/2025-April/217565.html ). This also required fixing ioscm_flush. Thanks, - Tom