From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3wbADFgNdmr7axEAWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 12:52:40 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=m6LaBUb/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KhC9A4GZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QQTZ7/a3; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TbxT4tbb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1AC111E166; Fri, 07 Aug 2026 12:52:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 663E51E09B for ; Fri, 07 Aug 2026 12:52:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 79C9F4BB5918 for ; Fri, 7 Aug 2026 16:52:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 79C9F4BB5918 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=m6LaBUb/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KhC9A4GZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QQTZ7/a3; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TbxT4tbb Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 3008D4BB58DE for ; Fri, 7 Aug 2026 16:52:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3008D4BB58DE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3008D4BB58DE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786121533; cv=none; b=OEBi/yBe1cfRDtqqdKO0cv8SVa22gKQgiJXAUpx0YzG1SwFMjU42RHWDIcNp04D9t2gwhOeew7PDeOBG+EpMpBWivOPAD+hI6DUoIAtGZDJ8kV4dwvZwsoGcFbhNRUXTjMYl5rFBrDCZQMWbc7RuxTmjF/T4wg9pVpSik9FGSJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786121533; c=relaxed/simple; bh=uLM7gKXpbyht3k+u4vd3NBkg7YsSYthFoTBU9cFLw+8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=cXEWSmT+cn2lJ8WdDRGWP8hO8L28MoJemAwKQmG8yM5oUpnBb323atoyOoOuimY+v3giEQHIV9MYQKhHEsJ+rwNUUjUhEym5yFyqAvfeM8Us5pF1qtcAahvaAR8/I++n0/dW8Eg5cBIZpYHHDMJNXXubbCBAh1oGpqk5wHNhb7w= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=m6LaBUb/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KhC9A4GZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QQTZ7/a3; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TbxT4tbb DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3008D4BB58DE Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BE0F43E15; Fri, 7 Aug 2026 16:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786121527; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXRYxojVlYgcj7sz+0Vr8WTtjk6fzO9k1/gILtsRcgk=; b=m6LaBUb/GsTRYfTQaNWq2yhYpRbQBrUI0YsYzfzyV7IvBVusXuL9uAppvqj06TugyZyNyI xAb2ULbY8aUYLgxH+NGZz4SdbmY8rQRsnak8b4x+svZth+AL/mGVU0J0s0nSxAyEpYtBHE pT+3YQNYnAmU8Q2UvOZswtWVULh3B6M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786121527; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXRYxojVlYgcj7sz+0Vr8WTtjk6fzO9k1/gILtsRcgk=; b=KhC9A4GZwRVCR4KNQO5JBzGyWwyh7KZxGqvmSuz+v6+VMdkWhSYPhWH1M4+x8gz7q19x6s eB+9mL6qz8GSOYCw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786121523; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXRYxojVlYgcj7sz+0Vr8WTtjk6fzO9k1/gILtsRcgk=; b=QQTZ7/a3qB+a177Lqdc4nQsvXyvuY/l7HzVZIRVKEmB9xxe7pkJlUK/auhmyex+LdRIW8t eysz/xVDAYiTTQydWjEs91ABmpGeY+q/FiTbZ2nsTnvNvXnrEJ2Kj0VS9+ydnQT+Kfs0FE HPsTweYY9naaaUjUqn9lMJR9SQuIE8I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786121523; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXRYxojVlYgcj7sz+0Vr8WTtjk6fzO9k1/gILtsRcgk=; b=TbxT4tbbnr73UJwSdRqNuh22NcPanq25ScCcnA/QIS9k4PJ84kZ1dHWvXNP8UzpEynhHK3 3IivRZ11lcgMCdAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A265F779B6; Fri, 7 Aug 2026 16:52:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1Sk4JjMNdmodNwAAD6G6ig (envelope-from ); Fri, 07 Aug 2026 16:52:03 +0000 Message-ID: <75c88f8e-babb-4162-a941-424cb3bb1663@suse.de> Date: Fri, 7 Aug 2026 18:52:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb: share some thread proceed related code between CLI and MI To: Andrew Burgess , gdb-patches@sourceware.org References: <55e17e264f17f47680100684c9aa7bd9b88e377c.1786049312.git.aburgess@redhat.com> <87ik5mkkw5.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87ik5mkkw5.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/7/26 5:31 PM, Andrew Burgess wrote: > Tom de Vries writes: > >> On 8/6/26 10:54 PM, Andrew Burgess wrote: >>> + if (inf == nullptr) >>> + proceed_all_threads (); >>> + else >>> + { >>> + for (thread_info &thread : inf->threads ()) >>> + proceed_one_thread (thread); >>> } >> >> FWIW, also I wonder if it makes sense to fold this logic into >> proceed_all_threads: > > I took a look through all the other proceed() calls and couldn't see > anything else that might want to share this code, so my preference would > be to leave things as I initially proposed. I like the simpler each > function has one clear goal, rather than overloading proceed_all_threads > with multiple meanings ("all threads", or "all threads in inferior"). > Especially not a fan of default arguments for cases like this (or in > general much). > > That said, if you consider this a blocker to merging this patch then I > don't feel that strongly against it so would make the change to get this > fix merged. > Hi Andrew, I don't consider this a blocker. Thanks, - Tom > Just let me know. > > Thanks, > Andrew > > >> ... >> diff --git a/gdb/infcmd.c b/gdb/infcmd.c >> index 23e93587874..d2301ddf093 100644 >> --- a/gdb/infcmd.c >> +++ b/gdb/infcmd.c >> @@ -743,10 +743,18 @@ proceed_one_thread (thread_info &thread) >> /* See inferior.h. */ >> >> void >> -proceed_all_threads () >> +proceed_all_threads (inferior *inf) >> { >> gdb_assert (non_stop); >> >> + if (inf != nullptr) >> + { >> + for (thread_info &thread : inf->threads ()) >> + proceed_one_thread (thread); >> + >> + return; >> + } >> + >> for (thread_info &thread : all_threads ()) >> { >> /* We go through all threads individually instead of compressing >> diff --git a/gdb/inferior.h b/gdb/inferior.h >> index 8255654d9b8..2067f60ab7d 100644 >> --- a/gdb/inferior.h >> +++ b/gdb/inferior.h >> @@ -230,7 +230,7 @@ extern void continue_1 (bool all_threads_p); >> /* For use only when non_stop is true. Proceed all threads in every >> inferior. */ >> >> -extern void proceed_all_threads (); >> +extern void proceed_all_threads (inferior *inf = nullptr); >> >> /* For use only when non_stop is true. If THREAD is stopped, and is in an >> inferior that has_execution then switch to THREAD, clear its proceed >> diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c >> index e110b029e1e..1eb087b85db 100644 >> --- a/gdb/mi/mi-main.c >> +++ b/gdb/mi/mi-main.c >> @@ -259,13 +259,7 @@ exec_continue (const char *const *argv, int argc) >> if (!current_context->all) >> inf = find_inferior_id (current_context->thread_group); >> >> - if (inf == nullptr) >> - proceed_all_threads (); >> - else >> - { >> - for (thread_info &thread : inf->threads ()) >> - proceed_one_thread (thread); >> - } >> + proceed_all_threads (inf); >> >> disable_commit_resumed.reset_and_commit (); >> } >> ... >> >> Thanks, >> - Tom >