From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Clear entire "location" in value constructor
Date: Fri, 25 May 2018 22:43:00 -0000 [thread overview]
Message-ID: <75b86f0e-23b0-101e-7ec7-665d860af6f3@redhat.com> (raw)
In-Reply-To: <87vabbzfa2.fsf@tromey.com>
On 05/25/2018 08:49 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> Ah, I stumbled upon that code recently and wondered why only
> Simon> location.address was set. Either memset or {} is fine with me.
Note that this is a union.
>
> Thanks. I think I will change it to {}, since that seems cleaner.
Note that {} has the same effect as only setting the first field
of the union with Clang, so it's a nop patch. It shouldn't
really matter -- we're only supposed to access the active
member anyway.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-05-25 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 17:37 Tom Tromey
2018-04-25 15:33 ` Tom Tromey
2018-05-09 15:40 ` Tom Tromey
2018-05-25 17:30 ` Tom Tromey
2018-05-25 19:53 ` Simon Marchi
2018-05-25 21:46 ` Tom Tromey
2018-05-25 22:43 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75b86f0e-23b0-101e-7ec7-665d860af6f3@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox