Re: [PATCH 1/2] Fix asertion failure while analysing core files in AIX with terminated threads.

[Ulrich Weigand <Ulrich.Weigand@de.ibm.com>]

Aditya Vidyadhar Kamath <akamath996@gmail.com> wrote:

>If we analyse core files today in AIX ( few of them ) we get,
>  regcache.c:432: internal-error: get_thread_regcache:
>  Assertion `thread->state != THREAD_EXITED' failed.
>
>The reason being the aix-thread.c file where root cause is the
>sync_threadlists()
>function. When reading an AIX core file, threads are reported by
>libpthread library as being in PST_TERM (terminated) state, which
>is correct since process crashed. However, sync_threadlists() was
>calling delete_thread() for these terminated threads, marking them
>as THREAD_EXITED in GDBs internal state.

I guess the more fundamental question would be, do we even need
sync_threadlists() at all when debugging a core file?  Here,
the list of threads can never change, so what is the point of
attempting to sync it?  Does it work if you just never call
sync_threadlists() for core files (or have it return early)?

Bye,
Ulrich