From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115222 invoked by alias); 31 Oct 2017 14:19:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114881 invoked by uid 89); 31 Oct 2017 14:19:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:603 X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Oct 2017 14:19:33 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 8D.5A.26775.27688F95; Tue, 31 Oct 2017 15:19:30 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 31 Oct 2017 15:19:29 +0100 Received: from [142.133.61.28] (192.75.88.130) by DB4PR07MB315.eurprd07.prod.outlook.com (2a01:111:e400:982f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.4; Tue, 31 Oct 2017 14:19:28 +0000 Subject: Re: [PATCH 6/8] const-fy regcache::m_aspace To: Yao Qi , References: <1509096702-12202-1-git-send-email-yao.qi@linaro.org> <1509096702-12202-7-git-send-email-yao.qi@linaro.org> From: Simon Marchi Message-ID: <75902364-b335-e37e-75e8-db5a0ff969c3@ericsson.com> Date: Tue, 31 Oct 2017 14:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509096702-12202-7-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR18CA0011.namprd18.prod.outlook.com (2603:10b6:404:121::21) To DB4PR07MB315.eurprd07.prod.outlook.com (2a01:111:e400:982f::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b69a5aed-721f-4553-deb1-08d5206a65b3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603238);SRVR:DB4PR07MB315; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB315;3:TBHMCpjmkMNOuPNXn4sWaFMfKuwIwT30D+B5klseBHH84oIaHbcCtMfcuOOzjViBCh87zhOPj+vEyCArcwFtSJzHyHpggiNX3BjXwKJCA62lT21LgRcJi3aV8QtOURIDZcFV5AZzIb6RWo4UcKJ52Xdrovsd98QK3lmQSb1/Nekr0h/oXqku3thzbU61dHmuIgi6gWGJj+oEQqHjrI+6dTGjnXmSk0Ot9m7sJiIe4uuZccddJZa3GJDIpetBzGbp;25:eMLgBiS8udWSy327QobTx/p6cMz8MZ6g6+VrZLmu4MfmHwMza7D7dKwvaMJ3eo3XNkwajfXelik+Bs2B6XY+7v/b7d9karvPh2I9O1+IVk977vi49qMkyJA5w3+Umny4xVEKBXE8ndn8DSwhVG5okDiBTxUsh6SAdT6cbY2mQEUXgi+aiWHJyRo4wXCjpn9XrgWUQXOlHc3FqgjOJadoOSSsA39VE0xmfH8BM8A10sk8+oVEYIT7+eqn2QVMALYb9L+wsepE930cZEiGMR8rlcFuOUlG0IcK60L2DkN6nDVDVA4vifptBCyJuEY6A7D9Tm3NquZXyhrhhh2UnWEZUAKMoWGCPHu7RyXFZ4YzQqo=;31:4JBBjqhbrUmdFVXaRlcC8bC3SmsORcKrELYC+I00VJV0XNKalnN3ug7NMqru8tAKXoW47JVMyB+Q6/0I/GhdQ1vGaT/F6QpUTnDrqVTf8q5SsOsVaTo49/PF1XfPhFF0JEAMUwDDu9GdAAIq8QZcVtip772SwGLMA7iuizij7cKnNV4vW1IkCPTJ+n4Sq7W9mn0BkPy18mACYdqEHflemqis+/z26lv4ZWzsFJIqNXw= X-MS-TrafficTypeDiagnostic: DB4PR07MB315: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB315;20:ziAsjkepP8wJyUZ/hUkGAUQ14p7gZU6G5UrbPpLi6hb2+DjEVuqtbce6tbQy2cjNFOxT11opKTnXRD7mTLaH9OTIqYEgGF1vi4SzzMWFUt4dgD6R6m5HUNyObP8VjB2GSIbpQUsHgMb6JdVoUhIWJrE3mb99lkfZzhLLUFWBiydZ0a/xvsO7kkj0mytO/ov1/C+5CPhgdT6OU6TCflHBL8I0B1xw3nPyorXJ99dd6PSvFOJ0HdKLD+cOsI+IH+rCmkmAFwV3IEeC73HVoZvjgt0uNcczpz9kgsOkk6m0PMpCypoDEr4VHa3j8N1KHypMyuHHPo2aemOnPPjQZYIPdKwvGdq3yNRgKXOjLggn7WDuo6swoEyeLwk20+kJdo5KpEE6grc/evMFJcW+v5Tv/J0pmwzCAwlFLsSZ2m2u8JsaXxDxnH69pQmNAyZS6SfG2hbr/BF2KeWedN5EqOEVK6jiH9H0QouULY3ui/LVVfvFVBnCBj+8HRVYYFTJCiWU;4:d6fu9JuCqREcILKDgE76w2wt2XKBT4INkfS82LWlKu0U2/DVapFaICYtG7+mFCZgmfpeZY9zRVfPPRwecbj1pGExbrdf4kE13Jxuq84KIkACizwzFfrCD8L3Vc1gM8vuc7mXjMwNaLpKhtqtughF/PUBiPKCaEFRs92uRQh6tTad574ujmyf4Mfv3AfzCJNEqy8yfMQmuiFbAC/NiXp+oKrsWEg4xKuZXjLXZgFq/ZDR8TA8EKz5Qhn6WAkoEbbRR4o/GS2CFzt8iPs+vkocYA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231020)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123560025)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB4PR07MB315;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB4PR07MB315; X-Forefront-PRVS: 04772EA191 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(346002)(376002)(39860400002)(189002)(24454002)(199003)(377424004)(65826007)(5660300001)(50466002)(64126003)(33646002)(68736007)(86362001)(97736004)(31696002)(65806001)(65956001)(66066001)(47776003)(54356999)(31686004)(76176999)(50986999)(189998001)(4001150100001)(8676002)(7736002)(106356001)(105586002)(101416001)(2906002)(16526018)(25786009)(3846002)(6486002)(53546010)(49976008)(8936002)(316002)(6246003)(81166006)(53936002)(16576012)(305945005)(6666003)(39060400002)(478600001)(83506002)(36756003)(23676003)(81156014)(230700001)(2950100002)(58126008)(6116002)(229853002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB315;H:[142.133.61.28];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTU7MjM6eUd4aFR3UGI5a21zMU1KSSsxUVFmME0vQWlV?= =?utf-8?B?NjE5QmNqZHJ4YW5scTBwZ0dTM2xUb0VoSEI3NElGZ05UZHU4OTcySmFLeERI?= =?utf-8?B?bE95WkJ2eXlXSll6WEVVVUVaY1lZRHlGNCtpcDZDSE1odkc5Y1FpY3JUWnl1?= =?utf-8?B?SVVTcW5sYlQrVTIyaVhpUWRpa0RuNjNPaUozS3NmbzRSYVJGbGJZdXF1QVJ4?= =?utf-8?B?b1F6MDkwVlFuL3AzZDE3V3g1cW9CNzNkcmRTWUNMcENCMExmTkp0N0FLMjVv?= =?utf-8?B?ZE8rR0QxcTFPTlI1R2VUNTlaby9wemhaRDZ4NEZhaDR0KzR5UUFaSEc5enNK?= =?utf-8?B?b3JCbVIzN04yUkVlT285dTRLREhkaGhzVmUwdi9WWFYycWh3Smk1c3FscFBM?= =?utf-8?B?S1VORUVocGNCQXhyczFuditSREtsUkRrM1ozUUFVTEhtZnNjVHJGWUJGQWkz?= =?utf-8?B?OUpmekZicWMxdFY3b3dLNDdsdGkwSENUZFBITjArSzV0RVRLM3F2K1kyMGtH?= =?utf-8?B?ZlRURVlIY1J2ZEtlMlJnWDdIZWQ4bG5PUy9TVkxabTQyNkE4eVRleHFlMFVN?= =?utf-8?B?VEZBU3QxVFhUN0p3ZHlJY1dLQUFidFFSTmp5TWh6ZkliWXBSeEE5REdnVnFX?= =?utf-8?B?MUZIQS9NK25ZOUd4U2pMdkFwTnorQ2lvNFJPMlIzK1pMMDhIOE5yamRWYWt2?= =?utf-8?B?eXRBQWxDMmN4c0JVck5peWZuRXRxcjF5aVMvVWRwY3hNU05wWFYyTDdnTDJW?= =?utf-8?B?ZTFLQWk1bVVmbE15RjdFR2grWnJERC9oZStyaTdFdDFQbUxCQkEva3BPelM4?= =?utf-8?B?czkwUVUxTGp2R2srQ3NsdHBFamFzOHdrelFxMnkxVmZ1aGZtY3BaZE9xcjlT?= =?utf-8?B?SEZlMkphVTgwcHpXTGdkaGFVdWpRZDBSVzZETmYzNW5qbmJBSWJ3d0R5MS8x?= =?utf-8?B?ZERlekY4eXlwRjIzUmZNb1J6UEVvS1VMM3c1Rkpocm16TncweEFUdDZad0dS?= =?utf-8?B?OHc3SE5YZkdxK3IwaDY3NFdYVkNkWG0ybjE2WFhpOXhGdjdUOENEcUhOeEQ0?= =?utf-8?B?OG1ZNXhtWS9wdnJDY1lkUHpjTG9CNGNXVlBEdFQ1NGRraHBKMHRJUFlVRjgw?= =?utf-8?B?aUQ0RUJPYk9XUWZ5TWFCRm5Ea2JFY24rUkI2UnNrNXVNb0hMQ3VnTmlZL0kv?= =?utf-8?B?aW80YlJnM1Z2a1RycXh0MzZaZWZaejN2N3JqN0phbnAvOVMwRUp5WVFTckMr?= =?utf-8?B?QTkxVGlnTWtHQTIydnpjMUFQSU1TbWRzYVNmOGw1blRtbWVJVkhrTlFLVzNi?= =?utf-8?B?ejNYSjJSWExHUEI3Z044VWpobjEzMHhIT3Z3T2RTKzRHcUY3Y1UxbUJueWQ1?= =?utf-8?B?M3lQRXEvYXJiNk1BN2hRbmp4TkhpSkMyRURQOURFWCtxUTdaZnhJcFBqWTNm?= =?utf-8?B?dndYbEVuUURIVlJXOUIzK2Y1cUtIZGdKeTQwakpkUGVsMnJyWitrL09LYzNk?= =?utf-8?B?WSt6WmhvMTBXY3NxVzRKT0hPOGpvZ3BrWGJGSTVCOFJvR0dGaDhGWVFaZGlX?= =?utf-8?B?K0ZnYTBpR0tFZ1NjeHFhem5HU21nV1diK3lybkp3YnIybmdDWWJIbHFCT1dx?= =?utf-8?B?aEtXVG9YSWdVdG9WZXpWNmRpaTVJbGVWdTFoNFpERk5JNjNRR29wZUgrNU5m?= =?utf-8?B?cHBUeGJKTUVPcGV3bVpGODY3YmdhQ2JERSttVnpQYmRTUkJHa0VkTGxqbHRI?= =?utf-8?B?UXNwbXVzOTl2SXRwK05XSHNqMW5ORDNOcjlsSmxDbHJDMWJadGdMNFlRM3Fk?= =?utf-8?B?alV4RTl2eWJoRDRjRzUrOVNwbzU4UktiajdmY2I2S3pOK3l6K045Y2JIa1Vv?= =?utf-8?Q?3+xgIVbzZ90rnkEoaNo3kHgq4K666zQ?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB315;6:jCXk/5V6xCP2PeJTsqhQFrXCQF8NDrpy9DuvkKaF/l1TiGQ6J8TYFyUNEjFk4RDWoVuVcRNsQOESzIlM1DgHAS6oexnEFd9sL7HO4PS0TiZi16D3tZzNmCLJX2Kw8Y/BVceVBnx640HER4vGwg0cOhsfyVpJB25ElaR9+DXg1sbUjU/a5WmZ6RUgmLAQISNd6ZTpTBQ3xelh+f6pXHQG/stFRC+GIIDVdtRNobYg5evnWFGBDdu4HDDMXctmYX+bHjaPioN35gJ8uSRYZ+Q4WgPAlbPwdBB4rSsJXpKKXkqiQPl8KVsHRGMVRCqwQtZM5/VMzClhNpdyM24iXoNXLkE9nupHvxzE9wScmzPNV/M=;5:JFaH4PIPf5jhDv1fFTWpgJ5g1e69F2cRJ632Lmt/+QE+runcyuPJmyRpqYvCQuLwS8Fs09R8pX5NfHXZ3pmFuLjneSmfB/LCVz4XJXS4yNjO2moR5QW8drqjnmggL1yR8nqKCJbHyhosGM8HydDyvsQiUii/uHlEKGS6aC2dWvM=;24:4nKZg1w6Ch6xim6cLYKmi2CgAvZC7bCJayOSrZ6kmv242IiEbgUx8heq6+K/mM1h54rztTMP60jHLiP30Ik2MksuVcswW//S4Lrg4WOqbjA=;7:05CeJ7JmCB4vZvIrwh/hVi08aUuZIrR04Xs43UW3ex02oSPEOTubSDgpBAmqO6Bu7XRF9cHmGl3AMLX3KK3B6MvxgXL3S/Qfxu64jEUyTcw3jUHLA47LRoASpr054uwf8Ii32isYCtBsTSTY8ZaUEagkjGaUJj57X9A3Y1MjMt8MLtpnU407VhFYoqaUWihRb4aLoQUAdC1/6QmLCd2U5f9XpVgZMsn2g1pLSzS9KUAjwS1TvAHzmLHmsi82EOfC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2017 14:19:28.2702 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b69a5aed-721f-4553-deb1-08d5206a65b3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB315 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00926.txt.bz2 On 2017-10-27 05:31 AM, Yao Qi wrote: > regcache::m_aspace is a const, never changed during the lifetime of > regcache object. I don't really understand what this patch tries to achieve. From the description above, I thought you wanted to make the m_aspace field const, not the pointed object. If constifying the pointed address_space object is really what you meant to do, I find having the const_cast more confusing than anything else. I think we should constify all the way (removing const_casts, putting more consts where needed) or not at all. Simon