From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4438 invoked by alias); 23 Nov 2017 16:17:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4429 invoked by uid 89); 23 Nov 2017 16:17:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 16:17:32 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vANGHP2H008330 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Nov 2017 11:17:30 -0500 Received: by simark.ca (Postfix, from userid 112) id 56F601E586; Thu, 23 Nov 2017 11:17:25 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 94BC61E030; Thu, 23 Nov 2017 11:17:24 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Nov 2017 16:17:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Create private_inferior class hierarchy In-Reply-To: <6e26896a-c65c-1f72-65e5-1a02fdbf9886@redhat.com> References: <1511368867-19365-1-git-send-email-simon.marchi@ericsson.com> <1511368867-19365-2-git-send-email-simon.marchi@ericsson.com> <6e26896a-c65c-1f72-65e5-1a02fdbf9886@redhat.com> Message-ID: <757702afe1579a9d96d2aa3c47a65918@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 23 Nov 2017 16:17:25 +0000 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00553.txt.bz2 On 2017-11-23 09:09, Pedro Alves wrote: > On 11/22/2017 04:41 PM, Simon Marchi wrote: > >> diff --git a/gdb/darwin-nat-info.c b/gdb/darwin-nat-info.c >> index 44782bf..feab181 100644 >> --- a/gdb/darwin-nat-info.c >> +++ b/gdb/darwin-nat-info.c >> @@ -118,7 +118,11 @@ get_task_from_args (const char *args) >> { >> if (ptid_equal (inferior_ptid, null_ptid)) >> printf_unfiltered (_("No inferior running\n")); >> - return current_inferior ()->priv->task; >> + >> + darwin_inferior *priv >> + = (darwin_inferior *) current_inferior ()->priv.get (); >> + > > How about adding a function like this: > > static darwin_inferior * > get_darwin_inferior (inferior *inf) > { > return static_cast (inf->priv.get ()); > } > > and then using it throughout instead of the casts. Good idea. >> >> +/* Get the remote private inferior data associated to INF. */ >> + >> +static remote_inferior *get_remote_inferior (inferior *inf) > > Ah, you've added something like it to remote.c > Missing line break before get_, though. Oops, thanks. >> +{ >> + if (inf->priv == NULL) >> + inf->priv.reset (new remote_inferior); >> + >> + return (remote_inferior *) inf->priv.get (); > > static_cast would ensure that remote_inferior actually > inherits private_inferior. Didn't know static_cast checked that, cool! I'll use that. Simon