From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112487 invoked by alias); 28 Feb 2018 05:02:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112474 invoked by uid 89); 28 Feb 2018 05:02:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Feb 2018 05:02:06 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 90.C1.26548.CC7369A5; Wed, 28 Feb 2018 06:02:04 +0100 (CET) Received: from ESESSMR501.ericsson.se (153.88.183.108) by ESESSHC006.ericsson.se (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.352.0; Wed, 28 Feb 2018 06:02:04 +0100 Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSMR501.ericsson.se (153.88.183.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Wed, 28 Feb 2018 06:02:03 +0100 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Wed, 28 Feb 2018 06:02:03 +0100 Received: from [10.0.0.110] (192.222.251.162) by MW2PR1501MB2012.namprd15.prod.outlook.com (2603:10b6:302:c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Wed, 28 Feb 2018 05:01:59 +0000 Subject: Re: [PATCH v3 1/2] Create new common/pathstuff.[ch] To: Sergio Durigan Junior , GDB Patches CC: Pedro Alves , Joel Brobecker References: <20180210014241.19278-3-sergiodj@redhat.com> <20180228032708.19670-1-sergiodj@redhat.com> <20180228032708.19670-2-sergiodj@redhat.com> From: Simon Marchi Message-ID: <7555f173-8517-ef9f-897c-e1934cc3b942@ericsson.com> Date: Wed, 28 Feb 2018 05:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180228032708.19670-2-sergiodj@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YTOPR0101CA0054.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:14::31) To MW2PR1501MB2012.namprd15.prod.outlook.com (2603:10b6:302:c::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c7fbe89-ff2c-45ca-986b-08d57e68666f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:MW2PR1501MB2012; X-Microsoft-Exchange-Diagnostics: 1;MW2PR1501MB2012;3:RdzpC9pWXKRRaM6xMZ6esCTxgW9UrESXgNv8WH3IhP2cfMnMgVU12a/chpWS8ESAQJUKZ7u6p+ZDBTaH6c98MgaY3YrQ2P+9CcuQ6Yp/SZmV0hZlFkYj5cx9CIciaNgocs6YNUkIOqoj/LV2dC9+iSxz+9op68fJKLSf2FONeBJZ8JSA8+7DHQeVMh8JaY2dwVjyKvhTY4wZInhSjA79PEoKG1wdBP0xPMQCtFL0KEeVko30/08WwzFLfg5cslXP;25:k89LHo5BJVD0JX0MAb8s7UF9qY/QnVEAYC3Z9wjGzmczAvA5K4yb/tViAgK21V1I/LdsufWlqbEdmIgNBKnoJ8WGUVcplUDvG24ihcv54kJepb3Hr5YYVzdd//mNBY6JiwCijxaNK/nON+j9+vYce4KE3/+Q9jAWTb6wHrDHkhXS18cUXbJzasXL4n4A6rIL9I44pz844F5JCX97lR7lCokbYeV49z0DSaSWPdZ6lyUXrhE4BGOTT0mrwRdaW0R88JrtG6ZjPuvqGLSQS0CZl2C46bN/yRPZ0EabOOLaWxdN5y3Bib0ZrdatmwnLlHQ6uMQDsbD68LtjZcXJ+O80sg==;31:nTa3xbhCG2v0/mea5buVAtn8F/tY/mICG4fCnR2AXfxw5ZzMb53Fxa75cMSUJ+pw1TS0yQOp+iTSVmHf1+MaGZ47wWV2IBVa+qdn/gBf0DaR8xI9Z5yR0uMG6BNL64X6Ai3R/bA1I6xvAv4N7r1CSjA6oLFIb1lR9Y5e1wWXktPzmnpG0hz5kEL9fKnmnmOpOq/YSGXwVWBt0u06fRVn3SAOldc9jzj5gbIqFEsfbns= X-MS-TrafficTypeDiagnostic: MW2PR1501MB2012: X-Microsoft-Exchange-Diagnostics: 1;MW2PR1501MB2012;20:tjl7QXZ8Oo2GGWPYUc4XCcUv8E2j8tddAeLs7gqjM4/mh4MFZFrPM//w3P0qGSBufokpdgV6URIrIue2zz80RVRNYtxa5ZDkPhGSiWW6HEBUmv3YGpAzsAMjFh0zyJsxGj58lg4MQ1O4iSFIYhmSKSpod6TTHRp03IFdKSWqiEdZ6b8W8CTRGp13rO60nQQsbox+8qmR5sw8oExRTu1qfcZG3xNm2WdzZecEc61rPV3F0NzEZ72/LUY7ZL7OLCovSDKg3KVjKdM+1qKsz59e97nQtaavSd6xOnKEL7KJ9HVYZGsMuxdx4hFbez2CSpaCDNrlSabcfPYykuXgfO6Q2buB4/oSFpD4O+LOZ1OGdx8FlBP+33qQaamT5z/WKD+2PgvyWrU8YRz3NmlLRDAbsv+Fsk3f07f++CJ6x+65MhKt8q622lpJHLS62s45CHnI61RuzyfsJztAL36u/cdoXu5zJrOnJLs0zTsn5bLPE8Cw9zU4SrmB5lsrAq6Y5Tfl;4:kQeZpVwUdCoTiL+wYAZcIKKH/kNzDz4K8Pa8a1piEdKleJNtfV/QtxkFCh6kRYPcHd0Wusxj6F4pkn60pdKnt9i5r4qedQMfFAzOnfICFslGLVuXEe3ZRCBCLHVM4Kqup9dmrrhT7O1BmxBtqbc0J+QK5XB7sIyivHo0AyiUO+41rAaVb//lzNJSfJR33nyLbp0KVMlchHZ96RfsnfMfSATkh1Olp+IbICII8wh8fFtdjOLd1i90zSRcw0IokU9BECCbpTM0HRF+c49ZK/5QMw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231220)(944501214)(52105095)(6041288)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:MW2PR1501MB2012;BCL:0;PCL:0;RULEID:;SRVR:MW2PR1501MB2012; X-Forefront-PRVS: 0597911EE1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(346002)(396003)(39380400002)(39860400002)(366004)(376002)(377424004)(199004)(189003)(65956001)(50466002)(86362001)(6486002)(6666003)(31696002)(2906002)(2950100002)(6116002)(54906003)(230700001)(4326008)(97736004)(106356001)(26005)(65806001)(386003)(52146003)(305945005)(105586002)(16526019)(68736007)(64126003)(36756003)(8676002)(47776003)(25786009)(66066001)(6346003)(81156014)(8936002)(478600001)(3846002)(229853002)(53936002)(23676004)(65826007)(316002)(77096007)(6246003)(81166006)(7736002)(5660300001)(76176011)(110136005)(16576012)(2486003)(58126008)(53546011)(186003)(31686004)(52116002);DIR:OUT;SFP:1101;SCL:1;SRVR:MW2PR1501MB2012;H:[10.0.0.110];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNVzJQUjE1MDFNQjIwMTI7MjM6Y2xkWmVsaXB1Zk5UTmdHSXlxZUMxVGh0?= =?utf-8?B?RWVZdGVkczJhYmVYNkhzTU1xL0tGcFRGSVhCbituOXNUaEdwZHNiT1pCT2V6?= =?utf-8?B?dDh5SXFqakpsS1E3bHJoUUIrNEVENHJXWFk1QzdLaXJROUM4NlNCU1JIMzJC?= =?utf-8?B?azJkS1hPSEk3Zy9JaTVNQXhoZGpYbUFpNFpEenAzalNFbGNxMURIY21HbzdW?= =?utf-8?B?M1I5am0rVGdmRXJLZzlMZHFVZjAxMWQ1SEdpdytwbFhyNTc0U3BIT0pxZG5U?= =?utf-8?B?ckZxNXBxNG5FT3p1ZUhKV0hZaVlDQjNGSklMOEtjbEM1TllVVldrcU1tVGJu?= =?utf-8?B?TkRNaTlyTGd2TkpaeDdsMC83cUhRNS85NVI1cFVxWlZySmcxdHNmT3NFWWhW?= =?utf-8?B?ZUpqL0poQTRvYmVHdWF2RjZWeWl6SWRhRDBlUjlPVlg0V0pncnZVUmptVDJp?= =?utf-8?B?MzB3STVKQ3JvZmxMVG1RNytKa2lKQlpURGtUVVJmOTZrYVE4WnNvZTB6ekdB?= =?utf-8?B?MzB4b3dnZXUzR0xOZ0ZhSjRmTWQ3aWxvajlxOS85VzlJaDVkQkZQWDF6dTdu?= =?utf-8?B?clpjUWZJcmpqNDY4bGt0K25KU2gySUh0T0d5SUV5Z0xtRjRobWpQakg2SnlZ?= =?utf-8?B?WGRvRmNyYkE2c3Rza1pVMUpOTVQ2Um1YZzZhVi91NzNZcnUzUFhEaGFDa3ho?= =?utf-8?B?UUlWaEYrM013bHJKTUZUR09LMnYrRXArbnVTbEEvV0kwVW9LbU9mSE5MZ25w?= =?utf-8?B?Z2ZySXBud2xCVm9wNW5PTW1td2RiN3JDZ2lxV0xhaFYrT0t6TlJoVHUvNkJU?= =?utf-8?B?YTR3dzN3ZnZ5eHZpNCs4NUM3VEJWUVFUVmo4eGd4UUVGVDMzNDZrM2I5M3hR?= =?utf-8?B?VVUwOWs5RFNmSStINmhNUk1obVNid1NjN0JIZGNqMU1KQm5CMFVObFdQTkZY?= =?utf-8?B?d1hxNC9qdlhMaWJhVjhmVkNrV1h3akVNRVdSVnNsd29qeDhpVTZ0YjI1VTFG?= =?utf-8?B?VkR3Q1ZYeGhqTmNReERFMlZVNTZMV1J0K255UVFVcENFSE5sK2hLZlh0UG5E?= =?utf-8?B?TkZBN1N3MFd4Y01hN29oSW94KzVEdXNnQW13Qzd2VVprY2pFaXVhZGRkYWE0?= =?utf-8?B?YU5kbENXZU5EWDczZWpqM05iVkJ5Q1dablcwUmtPV0lWRU8yZ0xDc1BqL3Iw?= =?utf-8?B?SmtZK3ZLaVl6OGhLSy9GeGpxV3drdU53bzYvWmU1OS9kclFoMGxZUWN1MFlQ?= =?utf-8?B?a1ZUcGdJRHZJQ0wzZEJKSE5DUW1QTnA0TzZuSFJ6SVBTdXdneTJJR3BFQjBx?= =?utf-8?B?QkhQOVA1Y1A4YmdJU0lsOWxWK3VVN3E2NEVGdEthODJLOW9pWmVyV0lZTXdy?= =?utf-8?B?aWpBMkQ2c2hCTGRlTjczZW93QkkxR1dpcXB5WHhWVUllZGNOZEl4bzduK1lT?= =?utf-8?B?RHNlMmoxdlFOSzM1SFFQTzg0VGFOdzA5ZVJhRlE2ZmFIcnJvdXdjV2plRDBX?= =?utf-8?B?bFRzVWZXN2V2NnNjd1YrcDNieEE3ZGwxczlZaDlDNk1rY1lKcFd6M2tRWHAx?= =?utf-8?B?QU10SHVqZU14YmV2MFNEdW1TZVpXSm5XbDd1SUxlNmdqd2Mzd2pINmxtK2lr?= =?utf-8?B?aC9TWUJrRm1jTGUxWFFXaVN2UXRvaHhsMjc2NUJnSGpUZnJYQzVNa3cwMXJt?= =?utf-8?B?WCt2ak5GWWNoNmplR0lqNytFQzJ6M2ptWmpYcXYralFyYkExUjhNQUp1NXhU?= =?utf-8?B?emk2dlIzTDdpSldJeW9MUGEzdEdqQ3VzUDBqaXh2TkhSbDhqUHVJc1RnQ2Vh?= =?utf-8?B?ejVmaUEwanVkS0p0ZmNzNEk3QVI3V1drVUxLNDh0TWhlNzVWbWFYdnVGblhC?= =?utf-8?Q?aJeoguEErgPMkoukKU/Uh+ryPrAszlEJmK?= X-Microsoft-Exchange-Diagnostics: 1;MW2PR1501MB2012;6:Y9OAZyzWyahtWAwxxkIW86hcZRGvMjN5o/yW43qQiSL+s9nH2P4DgDcoVAGlI2lOvLJmM+SJp1bJY/SGHlycwGT9hGdgmfcvBsmCJS9ZyvS9w0I6gZ4AEkpEGg+2LOrYt+4O133XnNJ/jTZVkSjLhf7uulRaUjau5P2M+njXlzYaQH4/Zyo5Uhvw/l3s+sQv6iBLc1qAmODP2jPmk9q5D18IiQFuhu2anvIrHdQAIgFLBD+mVfm3+864Q7PzL4ihVsSp7AgJMP6yCOcxTWvEvQQJYwJtrDv0VXI/jbqzEHmml9z1JWejdX8FCaQzlAxusjkLr/I+yAnFtPNCgJvAmwSo3kSUKL+RMcVO3B9Pj1U=;5:kV33Hp3xQZHGhKyGOdu96wVCWOxcbNZfpUFaFoG3YGjC8UTGwEFsVc//wcD0gkmEOZh2Tx2ZgjHgnOAGxprpGqErVEL+PpnM1dclHkEWSgXUv2iufWm47b1e7irb+e2+eJhT8j3F9uKtYDMh652T4SrUr3kO/PA06fIMJ9YP1pY=;24:i4197SpHn2HMqT+ll2WQHA8ZjCCu+J7Jpki9hjbWhsBPu2MqyLRN2hT9Vjuo9tcMyAIzrmjh1t1UAUcL541qwpEwUTjMjNxaMiIk0r1HjE8=;7:FISjWhekfqV4e9ohsKxA0N4ZgyZXoX0l1sMvdgumxxYGlq1IkaqC4M9O5e2xq2ALw7RqFARdOOeiu3f+Qz8sTT80v1Kj04p9+m9NkJQLR+yff5K1Af849GLAt9W+sI9o3Ht1mp5mma97+Gm1NTNkka3YPzZ++TEo31rWHYZP9oLKZW5/o04XutgJZC9MJb7vlV8vfzPU4QSO/o194sjTXgmxsj1sF6blcWZvwuX8GQ8hxJv0TUszOUm2J8yfioZf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2018 05:01:59.6050 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c7fbe89-ff2c-45ca-986b-08d57e68666f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR1501MB2012 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00445.txt.bz2 On 2018-02-27 10:27 PM, Sergio Durigan Junior wrote: > diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c > index cb02b58507..922d5269b3 100644 > --- a/gdb/gdbserver/server.c > +++ b/gdb/gdbserver/server.c > @@ -56,6 +56,10 @@ > break; \ > } > > +/* String containing the current directory (what getwd would return). */ > + > +char *current_directory; > + > /* The environment to pass to the inferior when creating it. */ > > static gdb_environ our_environ; > @@ -3539,6 +3543,13 @@ captured_main (int argc, char *argv[]) > const char *selftest_filter = NULL; > #endif > > + current_directory = getcwd (NULL, 0); > + if (current_directory == NULL) > + { > + error (_("%s: error finding working directory"), > + safe_strerror (errno)); > + } Just one thing, I think Pedro suggested to put the variable string at the end: error (_("Could not find working directory: %s"), safe_strerror (errno)); Simon