Re: [commit] gdb_byte regcache.[hc]

["Mark Kettenis" <mark.kettenis@xs4all.nl>]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

>>
>> Argh, let's blame it on my jetlag, but I meant regcache_raw_supply and
>> regcache_raw_collect as the function that should take `void *' instead
>> of `gdb_byte *'.  The other regcache_raw_xxx functions can stay as
>> they are now.
>
> 6hrs time difference is not jetlag ...
>
> Just supply/collect is making more sense :-)

The attached patchis what I had in mind.

OK?

Mark



[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 2297 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.7235
diff -u -p -r1.7235 ChangeLog
--- ChangeLog	15 Jun 2005 16:35:28 -0000	1.7235
+++ ChangeLog	15 Jun 2005 16:46:42 -0000
@@ -1,3 +1,9 @@
+2005-06-15  Mark Kettenis  <kettenis@jive.nl>
+
+	* regcache.c (regcache_raw_supply, regcache_raw_collect): Change
+	type of last argument back to `void *'.
+	* regcache.h (regcache_raw_supply, regcache_raw_collect): Likewise.
+
 2005-06-15  Mark Kettenis  <kettenis@gnu.org>
 
 	* hppa-hpux-nat.c (hppa_hpux_fetch_register)
Index: regcache.c
===================================================================
RCS file: /cvs/src/src/gdb/regcache.c,v
retrieving revision 1.136
diff -u -p -r1.136 regcache.c
--- regcache.c	19 May 2005 16:37:09 -0000	1.136
+++ regcache.c	15 Jun 2005 16:46:43 -0000
@@ -1002,8 +1002,7 @@ write_register_pid (int regnum, CORE_ADD
 /* Supply register REGNUM, whose contents are stored in BUF, to REGCACHE.  */
 
 void
-regcache_raw_supply (struct regcache *regcache, int regnum,
-		     const gdb_byte *buf)
+regcache_raw_supply (struct regcache *regcache, int regnum, const void *buf)
 {
   void *regbuf;
   size_t size;
@@ -1036,8 +1035,7 @@ regcache_raw_supply (struct regcache *re
 /* Collect register REGNUM from REGCACHE and store its contents in BUF.  */
 
 void
-regcache_raw_collect (const struct regcache *regcache, int regnum,
-		      gdb_byte *buf)
+regcache_raw_collect (const struct regcache *regcache, int regnum, void *buf)
 {
   const void *regbuf;
   size_t size;
Index: regcache.h
===================================================================
RCS file: /cvs/src/src/gdb/regcache.h,v
retrieving revision 1.46
diff -u -p -r1.46 regcache.h
--- regcache.h	19 May 2005 16:37:09 -0000	1.46
+++ regcache.h	15 Jun 2005 16:46:43 -0000
@@ -98,9 +98,9 @@ void regcache_cooked_write_part (struct 
    target_fetch_registers() or target_store_registers().  */
 
 extern void regcache_raw_supply (struct regcache *regcache,
-				 int regnum, const gdb_byte *buf);
+				 int regnum, const void *buf);
 extern void regcache_raw_collect (const struct regcache *regcache,
-				  int regnum, gdb_byte *buf);
+				  int regnum, void *buf);
 
 
 /* The register's ``offset''.