Re: [PATCH 0/24] C++ification of struct so_list

Simon Marchi
2023-10-19T14:57:31Z

On 10/19/23 07:09, Lancelot SIX wrote:
> Hi Simon,
>
> I went through the series again, sent a few extra small remarks, and
> FWIW, it looks reasonable to me.
>
> I do agree with Pedro's point that "struct so" becomes a bit harder to
> search for, and "shobj" would have less false-positives, but I
> nevertheless ok with using "so". If it turns out to be a hurdle, we
> can always change it later.

Since you both agree with each other, I'll go with shobj.

>
> I have tested the AMDGPU part of the series (gdb.rocm/*.exp), both on
> top of master and downstream ROCgdb.
>
> So with the various nits fixed:
> Reviewed-By: Lancelot Six <lancelot.six@amd.com>

Thanks for reviewing, I will push with all the small nits fixed.

Simon