Re: [PATCH 0/24] C++ification of struct so_list

Lancelot SIX
2023-10-19T11:09:35Z

Hi Simon,

I went through the series again, sent a few extra small remarks, and
FWIW, it looks reasonable to me.

I do agree with Pedro's point that "struct so" becomes a bit harder to
search for, and "shobj" would have less false-positives, but I
nevertheless ok with using "so". If it turns out to be a hurdle, we
can always change it later.

I have tested the AMDGPU part of the series (gdb.rocm/*.exp), both on
top of master and downstream ROCgdb.

So with the various nits fixed:
Reviewed-By: Lancelot Six <lancelot.six@amd.com>

Thanks for doing this!
Lancelot.