From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QeuHG8LYB2cmoQgAWB0awg (envelope-from ) for ; Thu, 10 Oct 2024 09:38:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728567490; bh=5Za6E4+CVpjm2s/jChdHcG9mLdqoSHaJ866JLXpL44k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RVZ/UyaVWnCA89czaucmAhhdHcrVpOr7V+WDZzIlBm2HpF6HVm50zmJFgDSJ4V//h lWyUlpk7kc9sqLPOYonmVWA3+4TlXf1aSHnPP4Q2E6Q2bfafEM1leMrTZeEVL4wetI ws4olg6v8xH2zLh6J/5wRrs64Y1ovPzG32derPvQ= Received: by simark.ca (Postfix, from userid 112) id 5C3521E356; Thu, 10 Oct 2024 09:38:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=P8eRNOKH; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=MPMLsbKf; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DAFBA1E354 for ; Thu, 10 Oct 2024 09:38:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C20D3857002 for ; Thu, 10 Oct 2024 13:38:09 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A851B3857B9E for ; Thu, 10 Oct 2024 13:37:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A851B3857B9E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A851B3857B9E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728567471; cv=none; b=TcfeIxd+rTWUeMgXVoOKYyqvTOEDWR/+ydF+rvqGBusuxSz6mfsJfLL7KHWpDlyZbMrz7OkimHoZLx9GoYeRTfYBQvXBWcHgaiSXtq2SJuD56aDwkOLXDcE6kOzqAg/TA9SVtrCwmmLH0tfGSawoNSN7CpTOBDqaL+AbWlgHA7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728567471; c=relaxed/simple; bh=5Za6E4+CVpjm2s/jChdHcG9mLdqoSHaJ866JLXpL44k=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=Ao4hMO0WqiZuMbt/FxwY4MeKAAPwXpFFoR7h91PxLtXy8bmeCDJn5tuntABJ/uQThFnMOJHVdiLTSB+ZyhpSEd8LU0UjyOQwb+0wXMgC0/rTlV5AZJSwotTix1AUAWq9Gpdim3K96YN/+Yulfvex4zjrvwaMHZpZatWiXShq5eo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728567468; bh=5Za6E4+CVpjm2s/jChdHcG9mLdqoSHaJ866JLXpL44k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=P8eRNOKH7yCsMbW088IvP25IZwsSEl9qkj6CQPu7rDi4irFex7ACnFiabcdLOm8fC TWRG6XBjTi6dysrs/iIKipCVjJv7/ghfx+xFAfDhu3V5PLI/kVoU/7w6WYHvyFg9/6 UP1WlaWStBUndTNF+q6Rh3Mozbi7SIwNgdwqqMeM= Received: by simark.ca (Postfix, from userid 112) id 9603E1E358; Thu, 10 Oct 2024 09:37:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728567466; bh=5Za6E4+CVpjm2s/jChdHcG9mLdqoSHaJ866JLXpL44k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MPMLsbKfDXnhgZ5ZrXfbMBO1NgzdOaPAgBsxTWjD5SJQ0aOzSQrqeIwcpDgy0+ssK 4+8L30hsatAkqUQ5QPhwQr44PMkrbAYajnYtz8IroFWk1QhBvsYn4I0hZlCvT+oVlm 1vXXGaUljnX6+T/ZNqvFjPWI6xLrAPhD7fCddOOg= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 586521E354; Thu, 10 Oct 2024 09:37:46 -0400 (EDT) Message-ID: <74d60567-2f55-4ca7-87db-e655288dc549@simark.ca> Date: Thu, 10 Oct 2024 09:37:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] gdbserver: make arch and osabi names gdb::unique_xmalloc_ptr To: Andrew Burgess , gdb-patches@sourceware.org Cc: Luis Machado , Tom Tromey References: <642bc25ebd1e94f3378e109256b1c1229fb5f624.1728407374.git.aburgess@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <642bc25ebd1e94f3378e109256b1c1229fb5f624.1728407374.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > diff --git a/gdbserver/tdesc.h b/gdbserver/tdesc.h > index 534b8b000f5..6fc37d038bc 100644 > --- a/gdbserver/tdesc.h > +++ b/gdbserver/tdesc.h > @@ -54,18 +54,16 @@ struct target_desc final : tdesc_element > mutable const char *xmltarget = NULL; > > /* The value of element in the XML, replying GDB. */ > - const char *arch = NULL; > + gdb::unique_xmalloc_ptr arch = nullptr; Just a nit, you don't need to initialize unique_ptrs to nullptr, they are default initialized to that. Simon