From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 978 invoked by alias); 19 Mar 2019 18:14:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 969 invoked by uid 89); 19 Mar 2019 18:14:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Mar 2019 18:14:06 +0000 Received: by mail-wm1-f66.google.com with SMTP id h18so9063548wml.1 for ; Tue, 19 Mar 2019 11:14:06 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id l4sm9796500wrf.35.2019.03.19.11.14.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 11:14:03 -0700 (PDT) Subject: Re: [PATCH v2] Fix first time you type UP or DOWN in TUI's command window (Re: [RFC 8.3 0/3] Some style fixes) To: Eli Zaretskii References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> <83zhq26fcw.fsf@gnu.org> <874l899nh3.fsf@tromey.com> <8336ns3uv4.fsf@gnu.org> <83tvg4ywq2.fsf@gnu.org> <04e92055-4b62-5691-0425-d3110a862b31@redhat.com> <83imwfv1jd.fsf@gnu.org> Cc: tromey@adacore.com, gdb-patches@sourceware.org From: Pedro Alves Message-ID: <74c4ef38-2ca5-fd0f-fbf5-bfe472a079cd@redhat.com> Date: Tue, 19 Mar 2019 18:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <83imwfv1jd.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00412.txt.bz2 On 03/19/2019 06:08 AM, Eli Zaretskii wrote: >> Cc: tromey@adacore.com, gdb-patches@sourceware.org >> From: Pedro Alves >> Anyway, I've stared at this for a while, and I _think_ this captures >> the idea. WDYT? > > Thanks, LGTM. It certainly explains the values of these two members > and how they are used. > >> + { >> + /* If we've reached the end of the line, so go back to >> + letting text output go to the console. */ > > A minor typo: "If ..., so ..." sounds weird. I think you wanted to > get rid of that "If". Indeed. Fixed that, and merged to master. Thanks, Pedro Alves