From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9007 invoked by alias); 23 Aug 2017 09:20:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8980 invoked by uid 89); 23 Aug 2017 09:20:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 09:20:42 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF0CDC047B71; Wed, 23 Aug 2017 09:20:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BF0CDC047B71 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E70D17D7A; Wed, 23 Aug 2017 09:20:34 +0000 (UTC) Subject: Re: [libcc1] Improve detection of triplet on compiler names To: Sergio Durigan Junior , GDB Patches , GCC Patches References: <87mv6qhq9u.fsf@redhat.com> Cc: Tom Tromey , Keith Seitz , Phil Muldoon , Alexandre Oliva From: Pedro Alves Message-ID: <74900a91-685b-2bdc-6cb7-8333ce9c5d0a@redhat.com> Date: Wed, 23 Aug 2017 09:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87mv6qhq9u.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00433.txt.bz2 On 08/23/2017 05:17 AM, Sergio Durigan Junior wrote: > The GCC patch improves the libcc1::compiler_triplet_regexp::find and > libcp1::compiler_triplet_regexp::find methods by first trying to match > the triplet in the compiler name and correctly discarding the triplet > part of the regexp if the matching succeeds. I've had to do a few > modifications on the way the regexp's are built, but I'll explain them > in the patch itself. > > The GDB patch is very simple: it adds the trailing "-" in the triplet > regexp. Therefore, we will have a regexp that truly matches the full > triplet (e.g., "^(x86_64|i.86)(-[^-]*)?-linux(-gnu)?-") instead of one > that leaves the trailing "-" match to libcc1. > > I've tested this patch both on my Fedora and my Debian machines, and > both now work as expected, independently of the presence of the triplet > string in the compiler name. I am sorry about the cross-post, but these > patches are really dependent on one another. Is there a backward/forward compatibility impact? Does new GDB work with old GCC? Does old GDB work with new GCC? Thanks, Pedro Alves