From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Vw3SJbYsAGesUgEAWB0awg (envelope-from ) for ; Fri, 04 Oct 2024 13:58:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gHcvW6j5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 890B41E355; Fri, 4 Oct 2024 13:58:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 37E341E05C for ; Fri, 4 Oct 2024 13:58:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B9D66385332C for ; Fri, 4 Oct 2024 17:58:13 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 6D46A385C6E3 for ; Fri, 4 Oct 2024 17:57:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D46A385C6E3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D46A385C6E3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728064678; cv=none; b=tTxIGju6h82ucy22jnZNhcXWAyRfqzXZKICGgVu3Mbav2mG2DOYBLrKOwvMkCVgInsL8jbdSDE5MVDymCAyO9Kzq1pUElqlVRKlhdLaBKCFDrmsMJuwrzG4jWI6+0p5UPZvuMVqRUuWkD1AVxvCqwME3rhRpf1DTfDFyHiU3jhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728064678; c=relaxed/simple; bh=efNIYMgObGJ0PffmylR6RkeE2kNb2MG30UBLvxVVqes=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=B9mlmb34XcuueJ8PU/v742cLxHlwjXaU9DcMQV1Gq/Mf9Nmk/9LYguz08wGg8vY/IFoQSZjApaBfjsBtVM0WrhPpJ5ZKXnAhgCrRhSZqTiER5U3jRwF1pJWNVs/vX2Xpth6hZ4MskMau16RIwJ243Qt1ge547IjRZ6WzVljfDm4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728064676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N0gvtmyEYk5WbVGcPqDY4741GfVTIHZdLlfWyqlUv4c=; b=gHcvW6j511Zcwr6MOWX6q0t4gbO2q9QqHvc92lI0eadYiXW5epUvJ86In+I6Cb+RTrsO3x nHz2EfU3XPb0qSf1EOC/ecyFVxpb+gLAtSxOBX/nVO/tMyOn1mrdAkH1z7T8ZhyIBHnAuH arzBjRgvW+3KLFGkhV71W2ilyup41Pc= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-YKqo3rovOUyY7QBBxILhyg-1; Fri, 04 Oct 2024 13:57:54 -0400 X-MC-Unique: YKqo3rovOUyY7QBBxILhyg-1 Received: by mail-il1-f200.google.com with SMTP id e9e14a558f8ab-3a343860e72so27334325ab.0 for ; Fri, 04 Oct 2024 10:57:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728064674; x=1728669474; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N0gvtmyEYk5WbVGcPqDY4741GfVTIHZdLlfWyqlUv4c=; b=M9HjOies6rc8j9lsDEBj+LkXSfVSdJaEX8ZRDd9a1OjSlQa7llmDDwlGTt7YJuc4/l 6zuZie/RY8J5sidmJlbyh2tswkUH9HdWmyzzNcYeh6Fh3gP+vzJkiYgdGTeK2ASbovnu LEqDNGhovHQo/Zq1B3k2w2oA/hHWoeCJuXQJyZbec+j4TA8I9NeLFTF/7vdyyl6W3LPm NrqGZ8wuCpHQGqcbuhlB+Ecjg7GR0+b30tDvWgWr3kweOjviO0MVlwxYfmHdOvaSEQwq 0C40rXr20bat30+C572lpzqkPgQRSwh2gBfjVUve1ZG/9Jm1PiPHdL/WnEnyeuqXCq7H faPg== X-Gm-Message-State: AOJu0YyXbteTulmFEFlBruODDb6mZwR98ocNiuuFSpm5CyiApnpw41gM msyLsqF3AlXC/r8XbQjrWxb7/m4W1C8nd7ydwq+2PJK5zDXlsyx1dCirqH+TUXLZOMmmxhvtD9H Nr+lAMuHfWlj2FfobnMf4Y01ZA6aKRn2KArbp1nV10RPFd6GZxINPXY7HXNWHdZcpTIs= X-Received: by 2002:a05:6e02:18cc:b0:3a0:9f85:d74e with SMTP id e9e14a558f8ab-3a375bb7b34mr34572355ab.16.1728064673948; Fri, 04 Oct 2024 10:57:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYWOpizTWdEMm1x7W3ZHsxWH2vKHCLveUC9iV7sOw8cu7xHQN3w56xYVH9hGUCTWh4jnng1A== X-Received: by 2002:a05:6e02:18cc:b0:3a0:9f85:d74e with SMTP id e9e14a558f8ab-3a375bb7b34mr34572155ab.16.1728064673575; Fri, 04 Oct 2024 10:57:53 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a37a875117sm652375ab.82.2024.10.04.10.57.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Oct 2024 10:57:52 -0700 (PDT) Message-ID: <748d7571-1fbf-4467-9887-c5f693055bff@redhat.com> Date: Fri, 4 Oct 2024 14:57:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/5] gdb: introduce ability to disable frame unwinders To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20241001184235.3710608-1-guinevere@redhat.com> <20241001184235.3710608-5-guinevere@redhat.com> <86ttdv11ds.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <86ttdv11ds.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/2/24 3:10 AM, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: Guinevere Larsen >> Date: Tue, 1 Oct 2024 15:42:34 -0300 >> >> +maintenance set dwarf unwinders (on|off) >> + This command has been removed because the same functionality can be >> + achieved with maint frame-unwinder (enable|disable) DEBUGINFO. >> + >> +maintenance show dwarf unwinders >> + This command has been removed since the functionality can be achieved >> + by checking the last column of maint info frame-unwinders. > What is our procedure for removing maintenance commands? Are we okay > with unconditionally removing them in the same GDB release where we > introduce their replacements, or do we want to keep them for some time > for the benefit of those who use them in some scripts? While chatting to Andrew off-list I asked about this, and he said we don't offer any longevity guarantees for maintenance commands, and historically this has been done before, all that was needed was mentioning in the news file how to get the new functionality. > > The documentation parts are approved, thanks. > > Reviewed-By: Eli Zaretskii > Thanks for the review! -- Cheers, Guinevere Larsen She/Her/Hers