From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111815 invoked by alias); 17 Jan 2019 13:20:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111799 invoked by uid 89); 17 Jan 2019 13:19:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=processes, longstanding, Gmail X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Jan 2019 13:19:58 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BFE2BCA36D; Thu, 17 Jan 2019 13:19:56 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 79DD96111B; Thu, 17 Jan 2019 13:19:55 +0000 (UTC) Subject: Re: [PATCH] Simulator: prevent inlining in C++ mode To: Alan Hayward , Simon Marchi References: <7d0cf55807aabaf4391662dc5e25b3cf@polymtl.ca> <1d3c4bfafaf0782637c402c8c13041bf@polymtl.ca> Cc: "Pavel I. Kryukov" , GDB Patches , nd From: Pedro Alves Message-ID: <742d4411-89eb-9caa-5825-9c926037ba52@redhat.com> Date: Thu, 17 Jan 2019 13:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-01/txt/msg00398.txt.bz2 On 01/17/2019 09:53 AM, Alan Hayward wrote: > >> On 16 Jan 2019, at 19:51, Simon Marchi wrote: >> >> On 2019-01-16 13:29, Pavel I. Kryukov wrote: >>> Okay, there are no C++ compiler errors other than macro expansion, >>> so this patch may be ignored. I submitted a separate patch for macros >>> expansion (https://sourceware.org/ml/gdb-patches/2019-01/msg00367.html) >> >> I'll take a look. >> >>> (Sorry, I still get lines wrapped in patches while sending them via Gmail. >>> Could you please tell if there is a workaround?) >> >> The best way is to use "git-send-email". You will need an SMTP server, whether it is gmail, your ISP's, etc. This should help: >> >> https://coderwall.com/p/dp-gka/setting-up-git-send-email-with-gmail >> >> If you really can't get this to work, the next best thing is to generate a .patch file (git format-patch HEAD^) and send it as an attachment. This ensures that the formatting is preserved. >> > > As someone who suffered similar issues until I moved to git send-mail, I’m > wondering if it’s worth it adding to the "Submitting Patches” section in > the CONTRIBUTE file? I can have a go at writing that if it makes sense. That will be good, no denying that. Thanks in advance. Though I think it'd be even better to fix the longstanding CONTRIBUTE problem. I.e., replace the current gdb/CONTRIBUTE file's contents, with a pointer to: https://sourceware.org/gdb/contribute/ and then have that point to some wiki page instead of at gdb/CONTRIBUTE. Wiki pages are much easier to update to keep up with the processes, which are not tied to a specific gdb version. Also, web content can take advantage of cross linking. Note that: https://sourceware.org/gdb/wiki/ContributionChecklist#Submitting_patches also has information about git send-email and how to set up various clients. Thanks, Pedro Alves