From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8628 invoked by alias); 12 Jan 2017 16:06:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8607 invoked by uid 89); 12 Jan 2017 16:06:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*MI:sk:72b83a2, H*i:sk:72b83a2, Thunderbird, thunderbird X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jan 2017 16:06:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 050668FD03; Thu, 12 Jan 2017 16:06:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0CG6VB1026001; Thu, 12 Jan 2017 11:06:32 -0500 Subject: Re: [PATCH 3/8] Disassembly unit test: disassemble one instruction To: Yao Qi , binutils@sourceware.org, gdb-patches@sourceware.org References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-4-git-send-email-yao.qi@linaro.org> <72b83a2c-8450-7647-a83c-958d1b564296@redhat.com> From: Pedro Alves Message-ID: <74261fc9-5f06-0308-3432-bfd073be2f2b@redhat.com> Date: Thu, 12 Jan 2017 16:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <72b83a2c-8450-7647-a83c-958d1b564296@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00237.txt.bz2 On 01/12/2017 03:15 PM, Pedro Alves wrote: > Putting it all together, you'd have something like: > > explicit gdb_disassembler_test (struct gdbarch *gdbarch, > struct ui_file *stream, ^^^^^^^^^^^^^^^^^^^^^^ This stream parameter here shouldn't exist, of course. It's just that my Thunderbird hasn't learned to flag coding problems yet. :-) > const gdb_byte *insn) > : gdb_disassembler (gdbarch, > (DISASSEMBLER_TEST_VERBOSE > ? gdb_stdout : null_stream ()), > gdb_disassembler_test::read_memory), > m_insn (insn) > {} -- Thanks, Pedro Alves