Re: [PATCH] Add selftests run filtering

Simon Marchi
2017-09-06T18:44:00Z

On 2017-09-06 20:41, Simon Marchi wrote:
> On 2017-09-06 20:37, Simon Marchi wrote:
>> On 2017-09-06 17:25, Pedro Alves wrote:
>>> Sounds useful.
>>>
>>> Patch looks fine to me. Nits and comments below.
>>>
>>> I wonder whether we'll want to be able to do select tests
>>> with e.g., a regexp instead of exact matching. If we do, then
>>> the std::vector->std::map change would seem pointless.
>>
>> Not sure I understand. I am not using exact matching now either, so
>> using a map is probably already pointless. I am not sure what lead me
>> there, maybe I started with the intent of using exact matching. I'll
>> change it to a vector of a new struct type.
>
> Ah, now I remember. It was so we could easily check that there isn't
> already a test with this name, when registering a new test. It's
> won't break anything if we happened to have two tests with the same
> name, so I can just remove this check.

Oh, and also so it would automatically iterate in alphabetical order, I
thought it was prettier :).