From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4OTmIVUt5mTHqAkAWB0awg (envelope-from ) for ; Wed, 23 Aug 2023 12:01:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=bSWTcasy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 874EC1E0C2; Wed, 23 Aug 2023 12:01:25 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6B3A71E092 for ; Wed, 23 Aug 2023 12:01:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E53833830B76 for ; Wed, 23 Aug 2023 16:01:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E53833830B76 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692806482; bh=mfvh2iqQQqxsPXdojV3we3ArI7P22xCV7f/VYoUOH7Y=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=bSWTcasyam1hWekXWxkR8eKUeICFmIFHd8cYIHXiSAsb+Mroswwa8rkkzX6eoy4hA TT4XdiGznpq+ym9SOLEtMnGkoMh/taROZS2bjJ3zyTczcTeuX1+UEQ80Sqf2sg8Ay2 cAsA+QYM3yNZ4ZvTLlb+XsD7O8baanbZA5FZLeKE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 324A638515F4 for ; Wed, 23 Aug 2023 15:59:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 324A638515F4 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-vMo5erwfNSeZdJnjfs5r9Q-1; Wed, 23 Aug 2023 11:59:43 -0400 X-MC-Unique: vMo5erwfNSeZdJnjfs5r9Q-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-52a398d8a51so675486a12.0 for ; Wed, 23 Aug 2023 08:59:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692806379; x=1693411179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mfvh2iqQQqxsPXdojV3we3ArI7P22xCV7f/VYoUOH7Y=; b=Ohhch94/sYa4tM6v7NjPUfCjHfgWTnjhNUNbTKA9opI9POWSWxJL+ofnkMjQahofjS POm+1FtpRitr+F6CqZNpb2lbtxWkpv6EEowLbOqvArlCQbX+uF/TRnGU/B0QCp9COByl Etq9Nb3CmL9t2E2s9/kujZDhBB3vSWuticMQhXq8ZeyoDswKr5acmD+Gq+mT28Fm5FwP 0238HAn3MonYHqOAr0E1vnF5xosJnRSRdmhVYord5XD5wUkOkrDHCg+4ueX5VRkLruvg dppSZhsGLaWLCc9V9jVJqj+zXGnNkeOTr9gv/JoHfOScu4A+4TsDo8r6k3/qXV1rrEOL H8Bw== X-Gm-Message-State: AOJu0Yy3WhKmLRJAKdZCUnz/jktbRn7QwfZn9OOy/2FPg5SZvAai6u2u c4ODsP30C8izuL7Unogzq8TXqzHdK4IguvtIbJxT1Dzgo6Aq3x5gZS9rSsqVc7Jz9m+BAR/EFW+ Y0i5iyzICgi1RwiBjuERZcsuCFF8YVftrJFVC269eIOtPKD0zmIYk/XypYNUVpqbJ9taInvmZKr gQjtziaQ== X-Received: by 2002:aa7:d9c7:0:b0:529:4642:7933 with SMTP id v7-20020aa7d9c7000000b0052946427933mr11005229eds.36.1692806379254; Wed, 23 Aug 2023 08:59:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6zKQcozM3LDwou0V6uktlytNttlMX6uRRJWFllThZIvwIghZhUnMwdMK4yegwDm/pEQXdnA== X-Received: by 2002:aa7:d9c7:0:b0:529:4642:7933 with SMTP id v7-20020aa7d9c7000000b0052946427933mr11005215eds.36.1692806379014; Wed, 23 Aug 2023 08:59:39 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id p6-20020aa7d306000000b0052574ef0da1sm9320411edq.28.2023.08.23.08.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 08:59:35 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv4 09/10] gdb: remove tracepoint_probe_create_sals_from_location_spec Date: Wed, 23 Aug 2023 16:59:14 +0100 Message-Id: <73b7abdab3543ad5497cfa80056f96782d801219.1692806099.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" The tracepoint_probe_create_sals_from_location_spec function just forwards all its arguments to bkpt_probe_create_sals_from_location_spec, and is only used in one place. Lets delete tracepoint_probe_create_sals_from_location_spec and replace it with bkpt_probe_create_sals_from_location_spec. There should be no user visible changes after this commit. --- gdb/breakpoint.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index be2ef196f80..c6abb953ca5 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -284,9 +284,6 @@ static bool strace_marker_p (struct breakpoint *b); static void bkpt_probe_create_sals_from_location_spec (location_spec *locspec, struct linespec_result *canonical); -static void tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical); const struct breakpoint_ops code_breakpoint_ops = { @@ -301,10 +298,11 @@ static const struct breakpoint_ops bkpt_probe_breakpoint_ops = create_breakpoints_sal, }; -/* Tracepoints set on probes. */ +/* Tracepoints set on probes. We use the same methods as for breakpoints + on probes. */ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = { - tracepoint_probe_create_sals_from_location_spec, + bkpt_probe_create_sals_from_location_spec, create_breakpoints_sal, }; @@ -12211,17 +12209,6 @@ tracepoint::print_recreate (struct ui_file *fp) const gdb_printf (fp, " passcount %d\n", pass_count); } -/* Virtual table for tracepoints on static probes. */ - -static void -tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical) -{ - /* We use the same method for breakpoint on probes. */ - bkpt_probe_create_sals_from_location_spec (locspec, canonical); -} - void dprintf_breakpoint::re_set () { -- 2.25.4