From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120098 invoked by alias); 4 Apr 2017 11:01:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120088 invoked by uid 89); 4 Apr 2017 11:01:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-wr0-f177.google.com Received: from mail-wr0-f177.google.com (HELO mail-wr0-f177.google.com) (209.85.128.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 11:01:37 +0000 Received: by mail-wr0-f177.google.com with SMTP id k6so204840506wre.2 for ; Tue, 04 Apr 2017 04:01:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=gQkwzc23HtLKriZEngKhL9y80wzwaC5VIgGO8yldHjU=; b=N7iqUFH/wiB+6Sk6xX0/2snhfX4NhTWdvQaQGjfJ5cZZbA2GiCf0nYDNsWnbXY9NY8 y0I+JYvKhnLWGiw7xH3pOF/lHb+OrcSqBkTspeyQMMU5R06DN6Mp0wIHxlBsaoH6WYe4 EtTXcONnxUFM3p3VE9qiLdbzWb3zD+KTo35I3dTxQiIVBJ8RH3Y3yqHEVBq2NN3hh11w i88Dwr6QscZM/dnZ3qD1xfQqpzIkCzqZV8knosJgmnO6NF4t0ugvLI2h2vS7h8wJepbf iZ3YlvG5wlLyujOTgML0WioXYP7FsgWcstCUsGJYYv+dnOMQ0TCw9XPtZ1YNwS3QFqst YzGA== X-Gm-Message-State: AFeK/H0kBxKaXCsR8NB8y6FStTUrPj/1/hJX4nz9Q50Z7Xte4GipXPPc EERlgkXhZciahn91 X-Received: by 10.28.10.70 with SMTP id 67mr13958694wmk.131.1491303696347; Tue, 04 Apr 2017 04:01:36 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id 43sm5498185wry.64.2017.04.04.04.01.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 04:01:35 -0700 (PDT) Subject: Re: extract_unsigned_integer API (Re: [PATCH] Remove MAX_REGISTER_SIZE from frame.c) To: Yao Qi References: <86lgspqisk.fsf@gmail.com> <5f2f0cb0-6265-46aa-4ad6-eda5ba817da4@redhat.com> <8660itnzvv.fsf@gmail.com> <93774758-0354-c67b-9733-005b3d56fbfa@redhat.com> <2427e9d3-4d91-7d63-a8e4-36aeb233b86e@redhat.com> <86d1ctlhin.fsf@gmail.com> Cc: Alan Hayward , "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <7387cd88-0ed5-38b8-c56c-de6120f08e6a@redhat.com> Date: Tue, 04 Apr 2017 11:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86d1ctlhin.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00022.txt.bz2 On 04/03/2017 02:58 PM, Yao Qi wrote: >> >> Though for the particular case of frame_unwind_register, since the >> frame machinery works with struct value's, inside frame_unwind_register >> there's going to be a value created already, and that has a contents >> buffer we could access directly. So e.g., >> inside frame_unwind_register_signed, we should be able to use >> frame_unwind_register_value directly thus avoid the need for the local >> buffer and copying data. > > How is the patch below? > Fine with me. Thanks, Pedro Alves