From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UKYQKE6TR2pkkyMAWB0awg (envelope-from ) for ; Fri, 03 Jul 2026 06:47:42 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=CLwRojFz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 934CF1E024; Fri, 03 Jul 2026 06:47:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,WEIRD_PORT autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 427701E024 for ; Fri, 03 Jul 2026 06:47:40 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A12D4BA23D3 for ; Fri, 3 Jul 2026 10:47:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A12D4BA23D3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=CLwRojFz Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010044.outbound.protection.outlook.com [52.101.85.44]) by sourceware.org (Postfix) with ESMTPS id 647004BA5436 for ; Fri, 3 Jul 2026 10:47:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 647004BA5436 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 647004BA5436 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.85.44 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783075632; cv=pass; b=kqP8ezV9QNj7/JTBcacz6HIW3YWXiwJcuGHA3JtiOulWVs4kWrWWuau0Cvhl8KXPN5GeqkDkZPx4kcA1dAJU74k/cSylHzt6yz+aGpyHOqV5tl4CQXtnGsf8J1aw+9nXo5vLM0VjyHW1X2kiAejrzh5OjiSZP3SF/4VbGBbIdek= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783075632; c=relaxed/simple; bh=hU/MD4/Wq7ogaKvDXptRBLrsNpk7viDM02+ywxjkq04=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=qFXqEK6tkX2xSWeMf/XEWDGqRX1IMnfMp99hpiCXTnKZH4h7E1T5CPASJfBKfegG2AWKOJ591w/8ZOj1UIjfOS4PISAY6JXipgnKc7BqtsiZ4+hcYHxmj4tt8D3BeTS9qvBUShWDKUPN+o7itDtKcyhMyM0T3S6Hg1XQ+oLOGtA= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=CLwRojFz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 647004BA5436 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FTcf2eh5zIkgSWYQRzpeKQVGX6pd2OpKWo/AUiaYgrtk73opMwS3HOAc2VNw/kHTb18jifGXARoVpSlJH21x6eagGAgF06GUxtsykZq4YHzZNH7crEQzVBZLjEZZnTRcBjeym5lu7N+rbW3O055qVV2VkNy4mYgUsUnfm3GYj//6aXyHawtsZ7NsFrO/xagh3HU5jtz59ag0TTpKhVuZXFcQUTEROTTbwBD9v2snJNALumgQP7kYfkHqBx60c9LTZZbtbzkWyokpjf/wClfMPPWgd22N0BmgrYC1FQMRDRGlZQSmqW/q5Kt3P5dMQ6cINPU0gsn4NRqVK0H4OycgWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EiDET2OInlDZBID7SMbv8OIHBImnrqaIOQ4TKJfkxdE=; b=DHi1ek/LruPgzRMqHHm4jfh2C3DXBuTC2ZWDcdF7AEf0A4fWfKwM5+jOa8mT9H9Ff2BPBAmBnsB3dBdq1esA9uDCJF0CoI/n4WWd4hUQdIRCznssGN+r1j6caAG559OaSSNA16F/d3ORDwDIvITZADEi7bMJt+2tLJGtQMFsJcSIAqSmwgXdF0yjaL4440MKDSS3NwkMkykhKuwy7YbsVbARB00ASHOq7MfMROs7TSVqgjQQJhsC6REZke5p+VTf0fAi0sw2X1Hd5aOFh67KuMGsUht8k+TjJynmrqydw0Nq+/rmPxU9pfShVbDY6wZBaxCYZALugM2u2O90zy1w2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EiDET2OInlDZBID7SMbv8OIHBImnrqaIOQ4TKJfkxdE=; b=CLwRojFzsqm1w3kOh4cQAH32L9woXG0vei7KDARkKP3UQC0FDGBn9MP17VvBaq42BkMU0h33/U/hRHFNJi0HqmfREJ2H9bUe/TjsLgZZEp/IrjAX+bO0+pDtOW5r9YCloNSGZImG29rVY65AU5gsGdlQ931fvYBr3KZWa2I6jcg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by DM4PR12MB6496.namprd12.prod.outlook.com (2603:10b6:8:bd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Fri, 3 Jul 2026 10:47:04 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3%5]) with mapi id 15.21.0181.009; Fri, 3 Jul 2026 10:47:04 +0000 Message-ID: <73856a87-1dbe-4311-be05-ac20f045a936@amd.com> Date: Fri, 3 Jul 2026 11:46:59 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Windows/rocm-solib: Don't hardcode namespaces support To: Pedro Alves , gdb-patches@sourceware.org References: <20260702111521.320404-1-pedro@palves.net> Content-Language: en-US From: Lancelot SIX In-Reply-To: <20260702111521.320404-1-pedro@palves.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0329.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:eb::12) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|DM4PR12MB6496:EE_ X-MS-Office365-Filtering-Correlation-Id: ff3ca094-4fdc-4a8b-1d01-08ded8f06b4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|22082099003|18002099003|3023799007|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: N/83jjyCk9X5IaLwtfQU3qvKvxFdhOCcB92vYvupoqffxUdaoEOFAMtGyKo9cGv/9p5z/sHOqiq7cNXjUuia2E3AYXO1jzWzB6LqZ1SFHZawThsWLbQvmbgP774K4gOTRaVguTxdOcNx/P59mQxqjFWJaYiW3viTS9moNOPL3BuMaeZu4JTjEynBIlx+ElaJBhGffwtlZzTOVVihV030agEVbG5A56xK/bBDLO1fm2jnYLnT0r7rNQlcjUNvKSd+Qu6NXXH+fkvycpJ7NLEg6yvrP4wVLeAYXMcJLyQ3eQLM9N4AZYgm4gWBxwjRxdC8WzcWcOXlIET3OFuO965tobPOjQjjesOw/T1vs495WYOr/qyDz2CqDAMBiPThW++TeNPULHvzv6f/LDCH5Za668TTKN9oQAqw6RZEzyijrQUDqY6TITCfaEPwQT2DdZmw9inyi6WgH0C1wVZSYyRR9XZcsfirtdzxbQmgbrVPLAKpuhsBcP1RQxNy0ndnaApysueNAaNDCoyoHeEWitJZSHYeuzsFkW2zTEa9ySwrr8Tu+7FE7YxZyS9yYlvrjJEXDX8HnBxnH1Nt1fEhetzXuxOgDqqupSF732r6mwXuj2+qJUUCmD2f9/C8A/QHMBc7nn5rsqy6TE2Hh3C5V17XCFHaW7QlGSjTTIeph0awRB0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(18002099003)(3023799007)(56012099006)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1pDWUlPWmI3QWdwWjlMSWhOdTgyVEY2eUNUOXh3TDhSZXAxQXA4aDVBdmRu?= =?utf-8?B?MXNWa3hVS3NLOHBtSkM4aWRLclA5dTBRdiszN3JBSndCd0RUanhqMStFTHpM?= =?utf-8?B?WC94dERpK1FRcWdSUEMvUnFKZkg0ZmpCUW80SXFCRmJXdGRsWWRjd1d0RVFO?= =?utf-8?B?Nk9ORlhweVRPQUp2NXNvYlV2Y1pOTHZFY0V2NGpuM3JKYnpxcHJCek0vSTQx?= =?utf-8?B?cG1hNlJJa2lQWm5vNTdDOGlFM2Zsa3ltaEhreE02MTQxeStFOWdVbG5OZEli?= =?utf-8?B?aktFb2tFYTNpZmhxak1vU25KdnJSOGZNTlU5dGpBc21KRC9yMzBNYVZpMFpB?= =?utf-8?B?N0IrNE8wSng5YlprZmJCVWN4cWYvN05pSTZpQUt4WHR4ZWkzWGpKdXNKTjNL?= =?utf-8?B?NlNyZG1aVEIySDNJRm5JSWllcHlZaE03dzZhUmt6K1BvdUVrMUUzR1I0K0Ns?= =?utf-8?B?Q1VOVG9GTDJrbVZHc3F6SkNLSldka3JIbERXYXhGd2F5UzI2NHpJMSt4QWVj?= =?utf-8?B?NnovdEsvOXFheGxjZVZvZjlDOHVyTVlkUEdFeThEdlhQOFZzR3V4ODhBcXNH?= =?utf-8?B?bGNkWXlRRFEvTTJhS0RSSFdWeEJQZSt6bUN3MDM2ZHQ2b0FsQ1gzcWVLVzNV?= =?utf-8?B?MnZaYkdlVUh2cnNvTFc5dkI1SGtvdDVJeWVGdENjMnY2R0RYRlcyZEZscG9h?= =?utf-8?B?cTIxT3dkYmhmYzFicG4vTVZaeW1HcDczU0FYZWcvNmJaT0EwTUtQT21lVm1L?= =?utf-8?B?QlBwc3pnZC91Y2tSQU1zVzZRaUtyR1JmSHhLUnVEd0lWbWJ5WmJCRnVDM0lw?= =?utf-8?B?aVRFMWlwYlhUdC95aHhIdnJuYXBMU1VyNTU5N21aT2VTQnhGM3VyY0h5QStC?= =?utf-8?B?TnBEZVhjRCtndTRvY09lSlQ4MFJVeVcraXpnRytpUlJDOEFoWThCUDVZTUp1?= =?utf-8?B?amRnNi90TEt4eTNqSzRMQ1lJMEVrNlBDay95bWswODhvR2RFNVp3SC8yQlpj?= =?utf-8?B?ME8wcDk3ZXdxSWFvMjg2dHlpY1ZkbU1iY1ZyZElHd2xYc1ZYWTNUb0F2UmpB?= =?utf-8?B?blcvdE9ySmszQTFKZTNCcHJXcit2ZFBDYnFLZG0zQTE0bEd5SUdXZTA0dUo0?= =?utf-8?B?Rkw0d2RxUUpqMVFqL2pkUTdrdmZkRlVYa0VKa3ozalFnbkFTQTRqVHZVY2Qx?= =?utf-8?B?SHJxLzBGTEpib2VtZXBDWmxOOStjanh1NE80QlRlbjhxbW1hMWJkK05zVzlR?= =?utf-8?B?Y3pRclVsR29YTS9IanVRa0d4UjhjYWpKcVQrYkxvNWFKdSttNUF3Vyt3ZXJp?= =?utf-8?B?QVRYa0JLb2FwL3BiZ3hOVm9GNklSMjZPRUhWNXNWRkk1M2JFNzRXNEhwMXBs?= =?utf-8?B?ZC9CQlZUNStoRXAxcmw2TXBvNWpnblliRUZoMDNBSm1JN0hHVDFjM3JDVzc4?= =?utf-8?B?YUhLd1NhU2ROdmFjNzdiR1NoT2tmSkNkL29GR3VmMWxVcGUrMjByK2NvSHZy?= =?utf-8?B?VGhaZDNxZytJbThDMWhIWkdUZlgvS0ZSamJNQUl0bU9TSjFnNDRVaFdzY202?= =?utf-8?B?a1NmQ1RhQVlpTmYvamxHenM1QjJPeWpEVlh0LzNIc2plNDIvTnZiaWFncFo2?= =?utf-8?B?NDNLc2ZIb2QrV2Nra01FQWJ0VGlnbUwzWFBPWC9KS2UxM2Q2V0Q4Zld0Z0xU?= =?utf-8?B?NGc5ays4aUlFVmZZKzJYRytlYk5vTnJhVlVFOHdXblpudGRhemVLSlpoUlk1?= =?utf-8?B?RGJEMFZKS1A5UElLOWdpRFJhaVZCMVFiM01NcnZPMjZOVnJCeHk4dlRhdEJO?= =?utf-8?B?R1hjd2N2a0srZ0JIaExMaHdud0hhN0w3VGtlZXpzSk4rYU8vdm1Nb1VqdnBv?= =?utf-8?B?ZUVlMXRNcnpab1A5YlB5K3hIT3RQUVJIbTdLY2JvMFZLSDgvcDlKV3FpeFQz?= =?utf-8?B?amE5QVo1eTF6NE9TeEpzd1ZLRTV3T1NiTC8wVlJzNjlkd01kWXozRXJVYjBZ?= =?utf-8?B?THZkcWtYbWtUNWE1dzZmbjVLSnFwcFlwK0lrb1RQdFYzdXhVTjNQMW90SS9P?= =?utf-8?B?Wjd1UlUxTkZvTGc3RUU1R1RtK0RIYlZ5RUZCSnp0LzZucEFzalgwUlRlZHVF?= =?utf-8?B?eXV0SFN5a0NQbXV3QmJZYUJzeHBGc3dkMmJTUWlkOW1pRFNkNHdHVDE2RnZ5?= =?utf-8?B?QUhvY3J1Q2hxZUhDZVpUUTd5cTAxZFpMY3RKME5YSTlvYXhMZ2lhZFREamdK?= =?utf-8?B?em1NbGROSFZlV2dLaHpTc2lhREdua2VuS3B4bGg3cUFLdkExOGVRa3NJSlVN?= =?utf-8?Q?3p5ZhFylo/LPr8q7XR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff3ca094-4fdc-4a8b-1d01-08ded8f06b4b X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 10:47:03.9527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rhfrawuEasWBgrDF+tNq582yxpFLunf/EUaDntvGGGrrMMxvTJA3/5gAQkajtzxjpWpwvOVCLqWtNyjxeoivbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6496 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 02/07/2026 12:15, Pedro Alves wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > rocm_solib_ops currently unconditionally returns true to > solib_ops::supports_namespaces. That works OK on Linux where the > underlying solib ops is svr4. But on Windows, the underlying solib > ops is solib-target, which does not support namespaces. The result > is: > > (gdb) info shared > /home/pedro/rocm/gdb/build/gdb/solib.h:270: internal-error: num_active_namespaces: namespaces not supported > A problem internal to GDB has been detected, > further debugging may prove unreliable. > ... > Thread 1 hit Breakpoint 1, internal_verror (file=0x7ff71a27fc80 "/home/pedro/rocm/gdb/build/gdb/solib.h", line=270, > fmt=0x7ff71a27fc5e "%s: namespaces not supported", ap=0xfff1a8 "\270\374'", ) > at /home/pedro/rocm/gdb/build/gdb/utils.c:514 > 514 internal_vproblem (&internal_error_problem, file, line, fmt, ap); > (gdb) bt > #0 internal_verror (file=0x7ff71a27fc80 "/home/pedro/rocm/gdb/build/gdb/solib.h", line=270, > fmt=0x7ff71a27fc5e "%s: namespaces not supported", ap=0xfff1a8 "\270\374'", ) > at /home/pedro/rocm/gdb/build/gdb/utils.c:514 > #1 0x00007ff719c75cf4 in internal_error_loc (file=0x7ff71a27fc80 "/home/pedro/rocm/gdb/build/gdb/solib.h", line=270, > fmt=0x7ff71a27fc5e "%s: namespaces not supported") at /home/pedro/rocm/gdb/build/gdbsupport/errors.cc:57 > #2 0x00007ff719f0aafe in solib_ops::num_active_namespaces (this=0xbb3a0b0) at /home/pedro/rocm/gdb/build/gdb/solib.h:270 > #3 0x00007ff719eca99e in rocm_solib_ops::num_active_namespaces (this=0xc9388a0) at /home/pedro/rocm/gdb/build/gdb/solib-rocm.c:211 > #4 0x00007ff719a14d33 in print_solib_list_table (solib_list=..., print_namespace=true) at /home/pedro/rocm/gdb/build/gdb/solib.c:1011 > #5 0x00007ff719a15833 in info_sharedlibrary_command (pattern=0x0, from_tty=1) at /home/pedro/rocm/gdb/build/gdb/solib.c:1115 > > rocm_solib_ops will stop sitting on top of another solib > implementation once the multi solib provider work lands, but > meanwhile, it'd be helpful to not crash. > > Fix this by making rocm_solib_ops::supports_namespaces() delegate to > the underlying host solib ops like other methods do. > > Change-Id: I1627c6e2f1b1c171c013c8457e9bfca92d5f4dc5 Hi Pedro, This looks good to me, thanks. Approved-by: Lancelot Six (amdgpu) Best, Lancelot. > --- > gdb/solib-rocm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/solib-rocm.c b/gdb/solib-rocm.c > index 3a58a46d886..73797801d6c 100644 > --- a/gdb/solib-rocm.c > +++ b/gdb/solib-rocm.c > @@ -202,7 +202,7 @@ struct rocm_solib_ops : public solib_ops > { return m_host_ops->find_solib_addr (so); } > > bool supports_namespaces () const override > - { return true; } > + { return m_host_ops->supports_namespaces (); } > > int find_solib_ns (const solib &so) const override > { return m_host_ops->find_solib_ns (so); } > > base-commit: 18ca02157d9cc245f035452e397a07a3787034d0 > -- > 2.54.0 >