From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45187 invoked by alias); 16 Oct 2019 14:21:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45177 invoked by uid 89); 16 Oct 2019 14:21:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 14:21:37 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 17A69BA59; Wed, 16 Oct 2019 14:21:35 +0000 (UTC) Subject: Re: Change in binutils-gdb[master]: [gdb/tdep] Fix 'Unexpected register class' assert in amd64_push_argum... To: Alan Hayward , Simon Marchi , Andrew Burgess , "gdb-patches\\@sourceware.org" Cc: nd References: <5A0DCAF8-4BFF-49C2-86C7-5E9C5B5A911B@arm.com> <8811FC3D-F8EB-4711-89E3-BE46423C40A8@arm.com> From: Tom de Vries Message-ID: <736be29d-18d7-af6e-f0fb-538f8499df47@suse.de> Date: Wed, 16 Oct 2019 14:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00482.txt.bz2 On 16-10-2019 13:08, Alan Hayward wrote: >> On 15 Oct 2019, at 18:23, Alan Hayward wrote: >> >> >> >>> On 15 Oct 2019, at 09:04, Tom de Vries (Code Review) wrote: >>> >>> Tom de Vries has posted comments on this change. >>> >>> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/30 >>> ...................................................................... >>> >>> >>> Patch Set 1: >>> >>> https://sourceware.org/ml/gdb-patches/2019-10/msg00343.html: >>> ... >>> On 14-10-2019 15:10, Alan Hayward wrote: >>>>> This exposes 9 more FAILs of the PR tdep/25096 type, so mark all 12 of them as >>>>> KFAIL. >>>> When I run the test, I get three unexpected passes: >>>> >>>> >>>> # of expected passes 9388 >>>> # of unknown successes 3 >>>> # of known failures 9 >>>> >>>> KPASS: gdb.base/infcall-nested-structs.exp: l=c++: types-tc-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) (PRMS gdb/25096) >>>> KPASS: gdb.base/infcall-nested-structs.exp: l=c++: types-ts-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) (PRMS gdb/25096) >>>> KPASS: gdb.base/infcall-nested-structs.exp: l=c++: types-ti-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) (PRMS gdb/25096) >>> >>> That could be due to registers happening to have the correct value. >>> >>> Do these turn into KFAILs if you add: >>> ... >>> diff --git a/gdb/testsuite/gdb.base/infcall-nested-structs.exp >>> b/gdb/testsuite/gdb.base/infcall-nested-structs. >>> exp >>> index 957eb31bdc2..f62f636aa11 100644 >>> --- a/gdb/testsuite/gdb.base/infcall-nested-structs.exp >>> +++ b/gdb/testsuite/gdb.base/infcall-nested-structs.exp >>> @@ -134,6 +134,7 @@ proc run_tests { lang types } { >>> >>> if { $lang == "c++" && $name == "struct_02_01" >>> && [regexp "^types-(tf-t(c|s|i)|t(c|s|i)-tf)" $types match] } { >>> + gdb_test_no_output "set \$xmm0.v2_int64\[0\] = 0" >>> setup_kfail gdb/25096 "x86_64-*-linux*" >>> } >>> gdb_test "p/d check_arg_${name} (ref_val_${name})" "= 1" >>> ... >>> ? >>> ... >> >> I still get KPASSes with that change. >> Also tried adding the line to the next block in the test with the same if statements, but it didn’t help. >> >> > > Sorry, ignore my comment. > I was accidentally running using the 8.3 branch. > When I use the latest master, it all works for me. > Thanks, that explains it for me. The three KPASSES is what you see when you apply the patch to a version that does not contain the commit 6dfc0041129 "gdb/testsuite: Fix typos in infcall-nested-structs.c". Thanks, - Tom