From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UK6OHULSEWDsUAAAWB0awg (envelope-from ) for ; Wed, 27 Jan 2021 15:51:14 -0500 Received: by simark.ca (Postfix, from userid 112) id 772A01EF80; Wed, 27 Jan 2021 15:51:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 256C31E945 for ; Wed, 27 Jan 2021 15:51:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C30613896C34; Wed, 27 Jan 2021 20:51:13 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id D453F389367E for ; Wed, 27 Jan 2021 20:51:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D453F389367E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 016BAAD7F; Wed, 27 Jan 2021 20:51:10 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 27 Jan 2021 21:51:10 +0100 From: tdevries To: Tom Tromey Subject: Re: [PATCH][gdb/testsuite] Fix ERROR in gdb.dwarf2/dw2-out-of-range-end-of-seq.exp In-Reply-To: <87czxqf72t.fsf@tromey.com> References: <20210126180258.GA7826@delia> <87czxqf72t.fsf@tromey.com> User-Agent: Roundcube Webmail Message-ID: <734a8ca8e60f95eadde55cc6b4b96a6a@suse.de> X-Sender: tdevries@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-27 21:39, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> 2021-01-26 Tom de Vries > > Tom> * gdb.dwarf2/dw2-out-of-range-end-of-seq.exp: Add regexp to > Tom> "maint info line-table". Make PASS pattern more specific. Make > Tom> FAIL pattern work for -m32. > > Thanks. > > Tom> -gdb_test_multiple "maint info line-table" "END with address 1 > eliminated" { > Tom> - -re -wrap "END *0x0*1 Y \r\n.*" { > Tom> +set test "END with address 1 eliminated" > Tom> +gdb_test_multiple "maint info line-table $srcfile$" $test { > Tom> + -re -wrap "END *0x0*1 *Y \r\n.*" { > Tom> fail $gdb_test_name > > Should this just pass $gdb_test_name to gdb_test_multiple, rather than > $test? It seems like the two things should be the same. gdb_test_name is a dedicated variable that's only valid inside gdb_test_multiple. Thanks, - Tom