Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "M.M. Kettenis" <m.m.kettenis@alumnus.utwente.nl>
To: Andrew Cagney <cagney@gnu.org>, Mark Kettenis <kettenis@gnu.org>,
	gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA] Fix varobj.c value comparison problems
Date: Sun, 20 Feb 2005 15:21:00 -0000	[thread overview]
Message-ID: <7319977500775101@weblx058.utsp.utwente.nl> (raw)
In-Reply-To: <42160928.4080504@gnu.org>

Andrew Cagney <cagney@gnu.org> wrote:

> Mark, the thing that's missing is an automated testcase.  Having
> something change from -0.0 to +0.0 should do it.

Ah, but that is the exact the opposite of what triggered this fix:

   NaN != NaN

even though the bit pattern is the same, whereas

   -0.0 == +0.0

even though the bit pattern is different.  I caught the first one with
the existing testsuite although that's merely by accident.  Writing a
test that does this reliable is tricky though as NaNs are handled
differently by different targets.  Testing the second one should be possible.  I'll look into it.

Meanwhile, I've checked in the patch.



  reply	other threads:[~2005-02-20  2:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-18 15:28 Mark Kettenis
2005-02-18 15:28 ` Daniel Jacobowitz
2005-02-18 19:00 ` Andrew Cagney
2005-02-20 15:21   ` M.M. Kettenis [this message]
2005-02-20 20:37 Paul Schlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7319977500775101@weblx058.utsp.utwente.nl \
    --to=m.m.kettenis@alumnus.utwente.nl \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox