From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 28EDA388C025 for ; Wed, 5 Aug 2020 19:08:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 28EDA388C025 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id CC8E1242A7C; Wed, 5 Aug 2020 15:08:48 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XGvv7nUCqyE5; Wed, 5 Aug 2020 15:08:48 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 87D1F242E34; Wed, 5 Aug 2020 15:08:48 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 87D1F242E34 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cTfogyl0RYfS; Wed, 5 Aug 2020 15:08:48 -0400 (EDT) Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id 41DC1242C5F; Wed, 5 Aug 2020 15:08:48 -0400 (EDT) Subject: Re: [PATCH 3/4] gdb: pass target to thread_ptid_changed observable To: Pedro Alves , gdb-patches@sourceware.org Cc: Laurent References: <20200720204101.2849535-1-simon.marchi@efficios.com> <20200720204101.2849535-4-simon.marchi@efficios.com> <6bd06f25-c89b-58b5-3639-94813a7284f5@efficios.com> <5e34235b-a256-0255-b268-d929ff2e7a1d@palves.net> From: Simon Marchi Message-ID: <73072472-2115-0c9a-1e28-7b554bc2e4e6@efficios.com> Date: Wed, 5 Aug 2020 15:08:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5e34235b-a256-0255-b268-d929ff2e7a1d@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2020 19:08:51 -0000 On 2020-08-05 10:50 a.m., Pedro Alves wrote: > I don't see why we shouldn't. I'd say because it's not worth the trouble. >Assuming that the regcaches are empty > like in the current patch can also fail is someone inserts some test > before this new test that ends up filling in the regcache. I see it as > your new test being fragile because of that, and running the > "maint selftest" while some program is running is just a way > to trigger it. To me, not allowing selftests while the > program is running is just an admission that the tests > aren't well isolated enough. > I think it would make more sense to require that each test cleans up properly after itself. But anyhow, I'll do as you suggest, I don't mind. Simon