From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dogOAHvmWWNrDREAWB0awg (envelope-from ) for ; Wed, 26 Oct 2022 22:01:31 -0400 Received: by simark.ca (Postfix, from userid 112) id E28D51E11A; Wed, 26 Oct 2022 22:01:30 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=vSH/yDoD; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7BC8B1E0D5 for ; Wed, 26 Oct 2022 22:01:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC649382A2CA for ; Thu, 27 Oct 2022 02:01:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC649382A2CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666836088; bh=YFV9Zfnp/0wLhnqxHnVZj5bt+h22DnRdl3rK4NLtyyw=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=vSH/yDoDdIdAAlm5X2ZZLPR9+WNea5SFKKW0BbtrUx8R/av6/VrW9LZc0Ags5lvjv GhxiCo6+G5vTMZkoXNxfWr7ZiVx+I2+4JAoOfx6EgN+95RJDuZnW1/vzRuhViWiisl SLqKzig9xFtwhmIcmafFkg9g1fI7lOeHiKBJnM1c= Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 38BED3885C3B for ; Thu, 27 Oct 2022 02:00:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38BED3885C3B Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 9B8BA300089; Thu, 27 Oct 2022 02:00:57 +0000 (UTC) Message-ID: <72d8f582-4e89-b256-b830-1da228b2bbde@irq.a4lg.com> Date: Thu, 27 Oct 2022 11:00:55 +0900 Mime-Version: 1.0 Subject: Re: [PATCH 26/40] sim/ppc: Remove getrusage declarations if possible Content-Language: en-US To: Mike Frysinger , gdb-patches@sourceware.org References: <4f666ba3e017785495a6d9e1242c827b4f74424c.1666258361.git.research_trasio@irq.a4lg.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tsukasa OI via Gdb-patches Reply-To: Tsukasa OI Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022/10/24 0:04, Mike Frysinger wrote: > On 20 Oct 2022 09:32, Tsukasa OI wrote: >> Clang generates a warning if there is a function declaration/definition >> with zero arguments. Such declarations/definitions without a prototype (an >> argument list) are deprecated forms of indefinite arguments >> ("-Wdeprecated-non-prototype"). On the default configuration, it causes a >> build failure (unless "--disable-werror" is specified). >> >> This commit removes redundant and indefinite getrusage function declarations >> if the known getrusage declaration is found. > > just delete the code and be done. don't keep it around for ancient irrelevant > systems that we never test on. > -mike I'm concerned what kind of machines / environments to preserve behavior but it seems we no longer have to worry about such pre-POSIX environments (also, sim requires ISO C11 support). Removing getrusage declarations without prototype is simpler and easier for me too, so I agree to delete them. Thanks, Tsukasa