From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 54261387605F for ; Mon, 16 Mar 2020 17:48:19 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 02GHm2ga015510 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2020 13:48:06 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 02GHm2ga015510 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F28C81E5F8; Mon, 16 Mar 2020 13:48:01 -0400 (EDT) Subject: Re: [PATCH 0/7] Add "Windows" OS ABI To: Eli Zaretskii Cc: gdb-patches@sourceware.org, jon.turney@dronecode.org.uk References: <20200316170845.184386-1-simon.marchi@polymtl.ca> <83blowb3bl.fsf@gnu.org> From: Simon Marchi Message-ID: <729be9e0-77bd-2837-48b1-5bc999ae6ceb@polymtl.ca> Date: Mon, 16 Mar 2020 13:48:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <83blowb3bl.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 16 Mar 2020 17:48:02 +0000 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2020 17:48:20 -0000 On 2020-03-16 1:46 p.m., Eli Zaretskii wrote: >> From: Simon Marchi >> Cc: Eli Zaretskii , >> Jon Turney , >> Simon Marchi >> Date: Mon, 16 Mar 2020 13:08:38 -0400 >> >> This patchset started out as a single patch to have the OS ABI Cygwin >> applied to Windows x86-64 binaries, here: >> >> https://sourceware.org/legacy-ml/gdb-patches/2020-03/msg00195.html >> >> with the follow-up here: >> >> https://sourceware.org/pipermail/gdb-patches/2020-March/000022.html >> >> Eli pointed out that it doesn't make sense for binaries compilied with >> MinGW to have the Cygwin OS ABI, that there should be separate OS ABIs >> for Cygwin and non-Cygwin Windows binaries. This already came up in the >> following bug report: >> >> https://sourceware.org/bugzilla/show_bug.cgi?id=21500#add_comment >> >> This patchset does a bit of refactor in that area. Most importantly, it: >> >> - adds a "Windows" OS ABI >> - makes GDB recognize the proper OS ABI (Cygwin or Windows) when >> loading executables >> - makes the builtin long type on Cygwin be 64 bits long > > Thanks for working on this, the changes LGTM. > Thanks for taking a look, I'll give a bit more time for others (Jon might be interested) to take a look if and comment. Simon