From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46195 invoked by alias); 30 Oct 2018 17:09:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46175 invoked by uid 89); 30 Oct 2018 17:09:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0066.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Oct 2018 17:09:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ssutVRD5PAwQCvPp0pSQCHYQpBXxOPgnJjiIDR5xCSE=; b=DhHmwxfGgerPAMc4syMbjEHZxpJSAcvrLplnyG+zhPesxN9DfdjUJJPMsD+7izxTEXh2SofxsfGVrf0iJ3mzACiI6kSYIKhAGo6xF4LszzIdFsYotSfNbt0ahy+X5chfpPqtdpwTsnHt4PqR3iogvqRVmCzCw1G9eBjKW2Ptjdo= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2278.eurprd08.prod.outlook.com (10.172.227.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.25; Tue, 30 Oct 2018 17:09:09 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11%7]) with mapi id 15.20.1273.027; Tue, 30 Oct 2018 17:09:09 +0000 From: Alan Hayward To: Pedro Alves CC: GDB Patches , nd Subject: Re: [PATCH v3 3/3] Aarch64: Fix segfault when casting dummy calls Date: Tue, 30 Oct 2018 17:09:00 -0000 Message-ID: <728A5D57-584B-405D-8315-FA1687C32192@arm.com> References: <20181011144905.66908-1-alan.hayward@arm.com> <20181011144905.66908-4-alan.hayward@arm.com> <95a5dd34-6815-f3f5-107c-13f4956b741e@redhat.com> <9290BC71-862C-48B1-97FD-A46C5D15A65C@arm.com> <201c7a49-ddf3-636a-f15a-eb9a4ccf284e@redhat.com> <3FFDA486-3FC8-4DA2-92C9-83C320F589F6@arm.com> <862cf8f4-9491-a1eb-251e-6c7c1ffffa6c@redhat.com> <830e7c3b-3469-6cea-61d1-5a1e7e230de1@redhat.com> <8DDC5D9D-D601-4D6D-A21F-7A35FF92C6EA@arm.com> <3f0332c2-1721-003e-e8a4-1e854f2ff00b@redhat.com> In-Reply-To: <3f0332c2-1721-003e-e8a4-1e854f2ff00b@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <87413A3F0E4BD1408025AFFF037FE014@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00714.txt.bz2 DQoNCj4gT24gMzAgT2N0IDIwMTgsIGF0IDE2OjMxLCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMTAvMzAvMjAx OCAxMToxMyBBTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPiANCj4+PiBPbiAy OSBPY3QgMjAxOCwgYXQgMTg6MTMsIFBlZHJvIEFsdmVzIDxwYWx2ZXNAcmVk aGF0LmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4gT24gMTAvMjkvMjAxOCAwMjo1 NiBQTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPj4+IA0KPj4+PiBBLWhhISBO b3cgSSB1bmRlcnN0YW5kIHdoeSBJIGdldCB0d28gY2FsbHMgaW50byBfcHVz aF9kdW1teV9jYWxsLg0KPj4+PiANCj4+Pj4gU28gdG8gYW5zd2VyIHlvdXIg cXVlc3Rpb24sIHRoZSBUWVBFX0NPREVfUFRSLT5UWVBFX0NPREVfSU5UIGlz IHRoZSBtYWxsb2MgY2FsbC4NCj4+Pj4gDQo+Pj4+IFRoZW4gdGhlIG5leHQg Y2FsbCB0byBfcHVzaF9kdW1teV9jYWxsIGhhcyBhIHJldHVybiB0eXBlIG9m IDAsIGFzIGV4cGVjdGVkLg0KPj4+PiBUaGlzIGRvZXNu4oCZdCBzZWdmYXVs dCBiZWNhdXNlIGl0IGdvZXMgaW50byBsYW5ndWFnZV9wYXNzX2J5X3JlZmVy ZW5jZSB3aGljaA0KPj4+PiByb3V0ZXMgdG8gZGVmYXVsdF9wYXNzX2J5X3Jl ZmVyZW5jZS4gVGhlIHNhbWUgYXMgdGhlIEMgc2hhcmVkIGxpYnJhcnkgdmVy c2lvbi4NCj4+Pj4gDQo+Pj4+IA0KPj4+PiBJ4oCZdmUgdXBkYXRlZCB0aGUg dGVzdCBzbyBpdCBkb2VzIHtjLGMrK30qe2RlYnVnIG5vZGVidWd9Lg0KPj4+ PiBJIGNhbiBhbHNvIHVwZGF0ZSBpdCB0byBkbyBib3RoIHNoYXJlZCBsaWIg YW5kIG5vbiBzaGFyZWQgbGliIHRvby4gVGhhdCBzaG91bGQNCj4+Pj4gY292 ZXIgZXZlcnl0aGluZy4NCj4+PiBCdXQgc3RpbGwsIHdoeSBkbyB5b3Ugc2Vl IGEgZGlmZmVyZW5jZSBiZXR3ZWVuIHNoYXJlZCBsaWJyYXJ5IGFuZCBub24t c2hhcmVkDQo+Pj4gbGlicmFyeT8NCj4+IA0KPj4gSW4gYWxsIGNhc2VzIHRo ZSBmdW5jdGlvbiB0eXBlIGlzIHRoZSBzYW1lLg0KPj4gDQo+PiBUaGUgZGlm ZmVyZW5jZSBpcyBiZWNhdXNlIHdpdGggYysrICYmIHNoYXJlZCBsaWJyYXJ5 LCB0aGUgY29kZSBlbmRzIHVwIGluIA0KPj4gZ251djNfcGFzc19ieV9yZWZl cmVuY2UoKSwgd2hpY2ggbWVhbnMgaXTigJlzIHVzaW5nIHRoZSBHTlUgRysr IFZlcnNpb24gMyBBQkksDQo+PiB3aGVyZWFzIHdpdGggYW55IG90aGVyIG9w dGlvbnMgKG5vbiBzaGFyZWQgb3IgYykgaXQgZW5kcyB1cCBpbg0KPj4gZGVm YXVsdF9wYXNzX2J5X3JlZmVyZW5jZSgpLg0KPiANCj4gVGhlIGZ1bmN0aW9u IGlzIHRoZSBzYW1lLCBhbmQgc2hvdWxkIGhhdmUgYmVlbiBjb21waWxlZCB1 c2luZyB0aGUgY2FsbGluZw0KPiBjb252ZW50aW9uIGlycmVzcGVjdGl2ZSBv ZiB3aGV0aGVyIGl0IGlzIGxpbmtlZCBpbnRvIHRoZSBtYWluIHByb2dyYW0s DQo+IG9yIGxpbmtlZCBpbnRvIHRoZSBzZXBhcmF0ZSBsaWJyYXJ5LiAgUmln aHQ/DQo+IA0KPiBTbywgZWl0aGVyIEknbSBtaXNzaW5nIHNvbWV0aGluZywg b3IgaW4gb25lIG9mIHRoZSBjYXNlcyAoc2hhcmVkDQo+IHZzIG5vbi1zaGFy ZWQpLCB3ZSdyZSBjYWxsaW5nIHRoZSBmdW5jdGlvbiBpbmNvcnJlY3RseSAo YWxvbmcNCj4gd2l0aCBhbnl0aGluZyBlbHNlIHRoYXQgZGVwZW5kcyBvbiBj YWxsIEFCSSksIG5vPw0KPiANCj4gV2hhdCBhbSBJIG1pc3Npbmc/DQo+IA0K PiBXaGF0IGRvZXM6DQo+IA0KPiAoZ2RiKSBzaG93IGNwLWFiaSANCj4gVGhl IGN1cnJlbnRseSBzZWxlY3RlZCBDKysgQUJJIGlzICJhdXRvIiAoY3VycmVu dGx5ICJnbnUtdjMiKS4NCj4gDQo+IHNob3cgZm9yIHlvdSwgaW4gdGhlIHNo YXJlZCBhbmQgbm9uLXNoYXJlZCBjYXNlcz8NCj4gDQo+IC9tZSBwb2tlcyBh IGJpdC4NCj4gDQo+IE9LLCBJIHNlZSB3aGF0IGl0IGlzLg0KPiANCj4gWW91 J3ZlIGNvbXBpbGVkIHRoZSBfbWFpbl8gLmNjIHdpdGhvdXQgZGVidWcgaW5m byBhcyB3ZWxsOg0KPiANCj4gZysrIC1jIGNvbmRicmVhay1zb2xpYi1tYWlu LmNjIC1vIGNvbmRicmVhay1zb2xpYi1tYWluLm8gLWZuby1pbmxpbmUNCj4g ZysrIC1jIGNvbmRicmVhay1zb2xpYi1saWIuY2MgLW8gY29uZGJyZWFrLXNv bGliLWxpYi5vIC1mbm8taW5saW5lDQo+IGcrKyBjb25kYnJlYWstc29saWIt bWFpbi5vIGNvbmRicmVhay1zb2xpYi1saWIubw0KPiANCj4gQW5kIGlmIHlv dSBkbyB0aGF0LCB0aGUgcHJvZ3JhbSBlbmRzIHVwIHdpdGggbm8gZGVidWcg aW5mbyBhdA0KPiBhbGwsIGFuZCBzbyBHREIgaGFzIG5vIGNsdWUgdGhhdCB0 aGlzIGlzIGEgQysrIHByb2dyYW06DQo+IA0KPiAoZ2RiKSBzdGFydA0KPiBU ZW1wb3JhcnkgYnJlYWtwb2ludCAxIGF0IDB4NDAwNGMxDQo+IFN0YXJ0aW5n IHByb2dyYW06IC90bXAvYS5vdXQgDQo+IA0KPiBUZW1wb3JhcnkgYnJlYWtw b2ludCAxLCAweDAwMDAwMDAwMDA0MDA0YzEgaW4gbWFpbiAoKQ0KPiAoZ2Ri KSBzaG93IGxhbmd1YWdlIA0KPiBUaGUgY3VycmVudCBzb3VyY2UgbGFuZ3Vh Z2UgaXMgImF1dG87IGN1cnJlbnRseSBjIi4NCj4gKGdkYikNCj4gDQo+IA0K PiBJZiB5b3UgY29tcGlsZSAob25seSkgdGhlIG1haW4uY2Mgd2l0aCBkZWJ1 ZyBpbmZvLCBsaWtlIHRoaXM6DQo+IA0KPiAtIGcrKyAtYyBjb25kYnJlYWst c29saWItbWFpbi5jYyAtbyBjb25kYnJlYWstc29saWItbWFpbi5vIC1mbm8t aW5saW5lDQo+ICsgZysrIC1jIGNvbmRicmVhay1zb2xpYi1tYWluLmNjIC1v IGNvbmRicmVhay1zb2xpYi1tYWluLm8gLWZuby1pbmxpbmUgLWcNCj4gDQo+ IHRoZW4gR0RCIHdpbGwga25vdyB0aGF0IHRoZSBwcm9ncmFtIGlzIGEgQysr IHByb2dyYW0uICBBbmQgeW91J2QNCj4gc3RpbGwgYmUgY2FsbGluZyBhIGNt cDMgZnVuY3Rpb24gdGhhdCBoYXMgbm8gZGVidWcgaW5mbywNCj4gYW5kIHNo b3VsZCB0aHVzIHRyaWdnZXIgdGhlIGJ1Zy4NCj4gDQoNClllcywgSSBoaXQg dGhlIGJ1ZyB0aGlzIHdheS4NCg0KTWFueSB0aGFua3MgZm9yIGxvb2tpbmcg dGhyb3VnaCB0aGlzLg0KDQoNCj4gDQo+IA0KPiBTbyB3aGVuIHdlIGNhbGwg Y21wMyB3aXRoIEdEQidzIGxhbmd1YWdlIHNldCB0byBDLCB3ZSBsYW5kDQo+ IGluIGRlZmF1bHRfcGFzc19ieV9yZWZlcmVuY2U6DQo+IA0KPiAoZ2RiKSBz aG93IGxhbmd1YWdlIA0KPiBUaGUgY3VycmVudCBzb3VyY2UgbGFuZ3VhZ2Ug aXMgImF1dG87IGN1cnJlbnRseSBjIi4NCj4gKGdkYikgcCAoaW50KSBjbXAz KHdvcmQpDQo+IA0KPiBUaHJlYWQgMSAiZ2RiIiBoaXQgQnJlYWtwb2ludCAz LCBkZWZhdWx0X3Bhc3NfYnlfcmVmZXJlbmNlICh0eXBlPTB4MWI1YTIzMCkg YXQgc3JjL2dkYi9sYW5ndWFnZS5jOjY2OQ0KPiA2NjkgICAgICAgcmV0dXJu IDA7DQo+ICh0b3AtZ2RiKSBjDQo+IENvbnRpbnVpbmcuDQo+IA0KPiBXaGVu IHRoZSBsYW5ndWFnZSBpcyBzZXQgdG8gQysrLCB3ZSBlbmQgdXAgaW4gZ251 djNfcGFzc19ieV9yZWZlcmVuY2U6DQo+IA0KPiAoZ2RiKSBzZXQgbGFuZ3Vh Z2UgYysrIA0KPiAoZ2RiKSBwIChpbnQpIGNtcDMod29yZCkNCj4gDQo+IFRo cmVhZCAxICJnZGIiIGhpdCBCcmVha3BvaW50IDQsIGdudXYzX3Bhc3NfYnlf cmVmZXJlbmNlICh0eXBlPTB4MWIzMzI5MCkgYXQgc3JjL2dkYi9nbnUtdjMt YWJpLmM6MTI1NQ0KPiAxMjU1ICAgICAgdHlwZSA9IGNoZWNrX3R5cGVkZWYg KHR5cGUpOw0KPiAodG9wLWdkYikgDQo+IA0KPiBBbmQgdGhpcyBpcyBiZWNh dXNlIGxhbmd1YWdlX3Bhc3NfYnlfcmVmZXJlbmNlIHVzZXMgdGhlDQo+IGN1 cnJlbnQgbGFuZ3VhZ2UsIGluc3RlYWQgb2YgdGhlIHN5bWJvbCdzIGxhbmd1 YWdlIChhcmd1YWJseSBhIGJ1Zyk6DQo+IA0KPiAodG9wLWdkYikgYnQNCj4g IzAgIDB4MDAwMDAwMDAwMDY1YmU5MSBpbiBnbnV2M19wYXNzX2J5X3JlZmVy ZW5jZSh0eXBlKikgKHR5cGU9MHgxYjMzMjkwKQ0KPiAgICAgYXQgc3JjL2dk Yi9nbnUtdjMtYWJpLmM6MTI1NQ0KPiAjMSAgMHgwMDAwMDAwMDAwNTQzZTJh IGluIGNwX3Bhc3NfYnlfcmVmZXJlbmNlKHR5cGUqKSAodHlwZT0weDFiMzMy OTApIGF0IHNyYy9nZGIvY3AtYWJpLmM6MjI5DQo+ICMyICAweDAwMDAwMDAw MDA2Y2MwOWIgaW4gbGFuZ3VhZ2VfcGFzc19ieV9yZWZlcmVuY2UodHlwZSop ICh0eXBlPTB4MWIzMzI5MCkNCj4gICAgIGF0IHNyYy9nZGIvbGFuZ3VhZ2Uu Yzo2NjANCj4gIzMgIDB4MDAwMDAwMDAwMDQ1YTI3YSBpbiBkZWZhdWx0X3Jl dHVybl9pbl9maXJzdF9oaWRkZW5fcGFyYW1fcChnZGJhcmNoKiwgdHlwZSop IChnZGJhcmNoPTB4MWIzMTZiMCwgdHlwZT0weDFiMzMyOTApDQo+ICAgICBh dCBzcmMvZ2RiL2FyY2gtdXRpbHMuYzo4NjENCj4gIzQgIDB4MDAwMDAwMDAw MDY0MGE4NiBpbiBnZGJhcmNoX3JldHVybl9pbl9maXJzdF9oaWRkZW5fcGFy YW1fcChnZGJhcmNoKiwgdHlwZSopIChnZGJhcmNoPTB4MWIzMTZiMCwgdHlw ZT0weDFiMzMyOTApDQo+ICAgICBhdCBzcmMvZ2RiL2dkYmFyY2guYzoyNzM5 DQo+ICM1ICAweDAwMDAwMDAwMDA2YTEwMTEgaW4gY2FsbF9mdW5jdGlvbl9i eV9oYW5kX2R1bW15KHZhbHVlKiwgdHlwZSosIGludCwgdmFsdWUqKiwgdm9p ZCAoKikodm9pZCosIGludCksIHZvaWQqKSAoZnVuY3Rpb249MHgxYjQ0NzMw LCBkZWZhdWx0X3JldHVybl90eXBlPTB4MWIzMzI5MCwgbmFyZ3M9MSwgYXJn cz0weDdmZmZmZmZmYzEyOCwgZHVtbXlfZHRvcj0weDAsIGR1bW15X2R0b3Jf ZGF0YT0weDApDQo+ICAgICBhdCBzcmMvZ2RiL2luZmNhbGwuYzo4ODENCj4g DQo+IA0KPiANCj4gU28gdGhhdCdzIHRoZSByZWFsIGRpZmZlcmVuY2UuICBT aGFyZWQgdnMgbm9uLXNoYXJlZCBpcyBqdXN0DQo+IGEga2luZCBvZiBhIHJl ZCBoZXJyaW5nLiAgSWYgeW91IGRvbid0IGhhdmUgZGVidWcgaW5mbyBmb3IN Cj4gbGlic3RkYysrLCBmb3IgZXhhbXBsZSwgdGhlbiBwcm9iYWJseSBHREIg d29uJ3Qga25vdyB0aGF0IHRoZQ0KPiBuby1kZWJ1Zy1pbmZvIHByb2dyYW0g aXMgYSBDKysgcHJvZ3JhbSBlaXRoZXIuDQo+IA0KPiBTbyBwbGVhc2UgYWRq dXN0IHlvdXIgdGVzdCB0byBlbGltaW5hdGUgdXNlIG9mIHRoZSBzaGFyZWQN Cj4gbGlicmFyeSwgYW5kIGJ1aWxkIGp1c3QgdGhlIGNtcDMgc291cmNlIGZp bGUgd2l0aG91dA0KPiBkZWJ1ZyBpbmZvLg0KDQpXaWxsIGRvLg0KDQoNCj4g DQo+PiBMb29raW5nIGF0IHRoZSBkb2MgZm9yIEdOVSBHKysgVmVyc2lvbiAz IEFCSToNCj4+IGh0dHBzOi8vZ2NjLmdudS5vcmcvb25saW5lZG9jcy9saWJz dGRjKysvbWFudWFsL2FiaS5odG1sDQo+PiBUaGUgbGlicmFyeSBuZWVkcyB0 byBiZSBsaW5rZWQgYWdhaW5zdCBsaWJzdGRjKysuc28gdG8gdXNlIGl0Lg0K Pj4gDQo+PiBBIHF1aWNrIGxkZCBzaG93cyBvbmx5IHRoZSBjKysgLnNvIGlz IGxpbmtlZCBhZ2FpbnN0IGl0Lg0KPiANCj4gVGhhdCB3b3VsZG4ndCBtYWtl IG11Y2ggc2Vuc2UuICBUaGUgd2hvbGUgcHJvZ3JhbSBpcyB1c2luZyB0aGUN Cj4gc2FtZSBjb21waWxlci9jYWxsL21hbmdsaW5nIEFCSSwgY2VydGFpbmx5 LCB3aGljaCBpcyB3aGF0DQo+IG1hdHRlcnMgaGVyZS4NCj4gDQo+IFRoYW5r cywNCj4gUGVkcm8gQWx2ZXMNCg0K >From gdb-patches-return-151997-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Oct 30 17:28:24 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 111596 invoked by alias); 30 Oct 2018 17:28:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 111585 invoked by uid 89); 30 Oct 2018 17:28:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=speak, ages X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Oct 2018 17:28:22 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D15E94E8BA; Tue, 30 Oct 2018 17:28:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D47DD86FD9; Tue, 30 Oct 2018 17:28:19 +0000 (UTC) Subject: Re: [PATCH] configure.ac: Cygwin now has ncurses not termcap. Use standard logic. To: Corinna Vinschen References: <1540415244-4879-1-git-send-email-joel@rtems.org> <8bc11746-527b-b123-0879-0c4cbd81eda3@redhat.com> <20181025185014.GN3310@calimero.vinschen.de> Cc: joel@rtems.org, GDB patches From: Pedro Alves Message-ID: <16e94ff1-0c06-7cca-44b1-77bf2fa59519@redhat.com> Date: Tue, 30 Oct 2018 17:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181025185014.GN3310@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00715.txt.bz2 Content-length: 4149 On 10/25/2018 07:50 PM, Corinna Vinschen wrote: > On Oct 25 16:30, Pedro Alves wrote: >> On 10/25/2018 04:01 PM, Joel Sherrill wrote: >>> On Thu, Oct 25, 2018 at 9:34 AM Pedro Alves wrote: >>> >>>> WDTY by "now"? >>>> >>>> I mean Cygwin used to include libtermcap and this built. I updated my >>> Cygwin this >>> week and it is no longer there. I wasn't able to figure out when it went >>> away. libncurses.a >>> is included and that's suitable. >>> >> >> That's so much clearer. >> >>> I cc'ed Corinna. I assume she can speak to when libtermcap.a was removed. > > I have no idea, ages ago. libncurses is used for a long time. Cygwin > should use the same autoconf code to figure out the correct lib as any > other target. Thanks, I've added info the commit log and applied the patch, as below. >From c1230d1bab8e36e1aa40f3bbadcef9b5d9ddc041 Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Tue, 30 Oct 2018 16:41:12 +0000 Subject: [PATCH] [src/erc32] Use ncurses instead of termcap on Cygwin too This removes a Cygwin-specific libtermcap hack that was dependent on the presence of one of the multiple alternative libraries. The one it was hard-coded to pick isn't included with Cygwin anymore. According to Corinna, libtermcap was removed from Cygwin a long time ago, and libncurses is used in Cygwin for a long time too. The fix is to make Cygwin use the same autoconf code to figure out the correct lib as any other target. sim/erc32/Changelog: 2018-10-30 Joel Sherrill * configure.ac: Remove the Cygwin-specific libtermcap.a hack and use the standard logic to determine which library to use. * configure: Regenerate. --- sim/erc32/ChangeLog | 6 ++++++ sim/erc32/configure | 10 +++++----- sim/erc32/configure.ac | 9 ++++----- 3 files changed, 15 insertions(+), 10 deletions(-) diff --git a/sim/erc32/ChangeLog b/sim/erc32/ChangeLog index e2b0232a36..088a2a4b45 100644 --- a/sim/erc32/ChangeLog +++ b/sim/erc32/ChangeLog @@ -1,3 +1,9 @@ +2018-10-30 Joel Sherrill + + * configure.ac: Remove the Cygwin-specific libtermcap.a hack + and use the standard logic to determine which library to use. + * configure: Regenerate. + 2017-09-06 John Baldwin * configure: Regenerate. diff --git a/sim/erc32/configure b/sim/erc32/configure index 1f9a962c47..4efb9b6fbc 100755 --- a/sim/erc32/configure +++ b/sim/erc32/configure @@ -13548,11 +13548,9 @@ fi { $as_echo "$as_me:${as_lineno-$LINENO}: result: $sim_cv_os_cygwin" >&5 $as_echo "$sim_cv_os_cygwin" >&6; } -if test x$sim_cv_os_cygwin = xyes; then - TERMCAP='`if test -r ../../libtermcap/libtermcap.a; then echo ../../libtermcap/libtermcap.a; else echo -ltermcap; fi` -luser32' -else - # Keep in sync with gdb's configure.ac list. - { $as_echo "$as_me:${as_lineno-$LINENO}: checking for library containing tgetent" >&5 + +# Keep in sync with gdb's configure.ac list. +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for library containing tgetent" >&5 $as_echo_n "checking for library containing tgetent... " >&6; } if ${ac_cv_search_tgetent+:} false; then : $as_echo_n "(cached) " >&6 @@ -13610,6 +13608,8 @@ else TERMCAP="" fi +if test x$sim_cv_os_cygwin = xyes; then + TERMCAP="${TERMCAP} -luser32" fi diff --git a/sim/erc32/configure.ac b/sim/erc32/configure.ac index 3135dc55ec..e4df81989c 100644 --- a/sim/erc32/configure.ac +++ b/sim/erc32/configure.ac @@ -26,12 +26,11 @@ AC_CACHE_CHECK([for cygwin], sim_cv_os_cygwin, lose #endif],[sim_cv_os_cygwin=yes],[sim_cv_os_cygwin=no])]) +# Keep in sync with gdb's configure.ac list. +AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncurses], + [TERMCAP=$ac_cv_search_tgetent], [TERMCAP=""]) if test x$sim_cv_os_cygwin = xyes; then - TERMCAP='`if test -r ../../libtermcap/libtermcap.a; then echo ../../libtermcap/libtermcap.a; else echo -ltermcap; fi` -luser32' -else - # Keep in sync with gdb's configure.ac list. - AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncurses], - [TERMCAP=$ac_cv_search_tgetent], [TERMCAP=""]) + TERMCAP="${TERMCAP} -luser32" fi AC_SUBST(TERMCAP) -- 2.14.4