From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22602 invoked by alias); 8 Nov 2017 16:08:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22339 invoked by uid 89); 8 Nov 2017 16:08:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Nov 2017 16:08:42 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84B0225C28 for ; Wed, 8 Nov 2017 16:08:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 84B0225C28 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE61A7D9C6; Wed, 8 Nov 2017 16:08:40 +0000 (UTC) Subject: Re: [PATCH 24/40] Per-language symbol name hashing algorithm To: Keith Seitz , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-25-git-send-email-palves@redhat.com> <596E467A.9040401@redhat.com> <2138d07b-2aed-901d-9c96-9f8b728f22cb@redhat.com> From: Pedro Alves Message-ID: <72716423-e7fc-28d1-352b-8e5fbee82588@redhat.com> Date: Wed, 08 Nov 2017 16:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2138d07b-2aed-901d-9c96-9f8b728f22cb@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00175.txt.bz2 On 07/20/2017 07:53 PM, Pedro Alves wrote: > On 07/18/2017 06:33 PM, Keith Seitz wrote: >> On 06/02/2017 05:22 AM, Pedro Alves wrote: >>> >>> This patch starts fixing this, by doing two things: >>> >>> #1 - adds a language vector method to let each language decide how to >>> compute a symbol name hash. >>> >>> #2 - makes dictionaries know the language of the symbols they hold, >>> and then use the dictionaries language to decide which hashing >>> method to use. >> >> Me likey! :-) >> > > Ahah, it was your idea. :-) > >> Again, just the usual trivial comments. > > [snip] > > Thanks much. I added the missing comments now. > > Here's the updated patch. FYI, I've pushed this one in now. Thanks, Pedro Alves