From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34359 invoked by alias); 16 Jan 2020 14:15:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34084 invoked by uid 89); 16 Jan 2020 14:15:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2020 14:15:29 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 630591E47D; Thu, 16 Jan 2020 09:15:26 -0500 (EST) Subject: Re: [PATCH] Support for DWARF5 location lists entries To: "Achra, Nitika" , "gdb-patches@sourceware.org" Cc: Ali Tamur , "George, Jini Susan" References: <48103fb5-d3ee-0ae0-92a7-f1c02debd449@simark.ca> <0d36089b-1890-c579-7715-641e94dd4bb6@simark.ca> <27bfa975-e28d-eafb-d9db-f0d2be5f5bde@simark.ca> <63fd3ce4-810b-d231-f238-85fe6d2dbb1f@simark.ca> From: Simon Marchi Message-ID: <726ebd81-48b2-684d-d4b5-8cdcf315d737@simark.ca> Date: Thu, 16 Jan 2020 14:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00448.txt.bz2 On 2020-01-16 6:29 a.m., Achra, Nitika wrote: > [AMD Official Use Only - Internal Distribution Only] > > Hi Simon, > > Please find the attachment. > > > *Handle DW_LLE_base_addressx, DW_LLE_startx_length and DW_LLE_start_length. > > Tested by running the testsuite before and after the patch and there is no increase in the number of test cases that fails. > Tested with both -gdwarf-4 and -gdwarf-5 flags. Also tested -gslit-dwarf along with -gdwarf-4 as well as -gdwarf5 flags. > > > gdb/ChangeLog: > *dwarf2loc.c (decode_debug_loclists_addresses): Handle > DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length. > > This is an effort to support DWARF5 in gdb. Hi Achra, The commit message of the patch is empty. The text that is above, which describes what your patch does, should be placed in your git commit, such that it will appear in the patch file when you use "git format-patch". This is the text that people will see when they do "git log", so you can do "git log" to see how it's usually formatted. Thanks, Simon