From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: cgf@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] work around sigsetjmp/siglongjmp macro problems
Date: Tue, 14 Aug 2001 23:52:00 -0000
Message-id: <7263-Wed15Aug2001095153+0300-eliz@is.elta.co.il>
References: <20010813231801.A23019@redhat.com> <Pine.GSO.4.33.0108140934230.23443-100000@makita.cygnus.com> <15225.34182.443304.980626@krustylu.cygnus.com> <20010814160813.D25516@redhat.com>
X-SW-Source: 2001-08/msg00174.html

> Date: Tue, 14 Aug 2001 16:08:13 -0400
> From: Christopher Faylor <cgf@redhat.com>
> 
> >Maybe in the gdb coding style section of the gdb internal manual, we
> >should make this point about macro's arguments.  Eli?
> 
> How about this:

Approved.

> Index: gdbint.texinfo
> ===================================================================
> RCS file: /cvs/uberbaum/gdb/doc/gdbint.texinfo,v
> retrieving revision 1.34
> diff -p -r1.34 gdbint.texinfo
> *** gdbint.texinfo	2001/07/31 17:30:56	1.34
> --- gdbint.texinfo	2001/08/14 20:07:27
> *************** However, use functions with moderation. 
> *** 4395,4400 ****
> --- 4395,4402 ----
>   are just as hard to understand as a single thousand-line function.
>   
>   @emph{Macros are bad, M'kay.}
> + (But if you have to use a macro, make sure that the macro arguments are
> + protected with parentheses.)
>   
>   @cindex types
>   
> cgf
>