Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Remove OS-specific defines (was: _WIN32?)
Date: Mon, 07 May 2001 11:24:00 -0000	[thread overview]
Message-ID: <7263-Mon07May2001212452+0300-eliz@is.elta.co.il> (raw)
In-Reply-To: <1010507173855.ZM18890@ocotillo.lan>

I see that I sent the original RFA to a wrong address.  Sorry, I will
resend.

Here's my reply to Kevin's approval:

> Date: Mon, 7 May 2001 10:38:55 -0700
> From: Kevin Buettner <kevinb@cygnus.com>
> 
> On May 7,  7:10pm, Eli Zaretskii wrote:
> 
> > 	* solib.c (solib_open): Use IS_DIR_SEPARATOR and IS_ABSOLUTE_PATH
> > 	instead of SLASH_CHAR, ROOTED_P and SLASH_P.
> > 	(top-level): #include "filenames.h".
> 
> Your changes to solib.c are approved.  (FWIW, I glanced over your
> changes to the other files and they look good too.)

Thanks for reviewing them so soon.

> Don't forget to also remove the definitions of SLASH_P, SLASH_CHAR, and
> ROOTED_P in config/i386/xm-cygwin.h and config/i386/xm-go32.h.

Yes, it's in the pipeline ;-)  I just wanted to hear from Chris, at
the very least, before futzing with his files.

Btw, is it perhaps a good idea to add to gdbint.texinfo some
guidelines about writing portable code which handles file names,
including the list of these macros?  Andrew?


       reply	other threads:[~2001-05-07 11:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20010503211502.21716.qmail@web6401.mail.yahoo.com>
     [not found] ` <3AF1DAA0.3060702@cygnus.com>
     [not found]   ` <200105071610.TAA24144@is.elta.co.il>
     [not found]     ` <1010507173855.ZM18890@ocotillo.lan>
2001-05-07 11:24       ` Eli Zaretskii [this message]
2001-06-10  6:28       ` Eli Zaretskii
2001-06-12 17:14         ` Christopher Faylor
2001-06-13  2:08           ` Eli Zaretskii
2001-05-13  1:29     ` Eli Zaretskii
2001-05-13  7:09       ` Fernando Nasser
2001-05-13 23:34         ` Eli Zaretskii
2001-05-14 13:18           ` Andrew Cagney
2001-06-04  0:46             ` Eli Zaretskii
     [not found]   ` <200105071609.TAA24129@is.elta.co.il>
     [not found]     ` <200105081141.OAA06131@is.elta.co.il>
2001-06-10  6:27       ` [RFA] Re: DOS/Windows-specific code: cli-cmds.c Eli Zaretskii
     [not found] <3AF6EB58.1020904@cygnus.com>
2001-05-10  3:31 ` [RFA] Remove OS-specific defines (was: _WIN32?) Eli Zaretskii
2001-05-07 11:36 David Taylor
2001-05-08  0:12 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7263-Mon07May2001212452+0300-eliz@is.elta.co.il \
    --to=eliz@is.elta.co.il \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox