From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58123 invoked by alias); 25 Oct 2017 14:15:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57364 invoked by uid 89); 25 Oct 2017 14:15:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=tweaked X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail.rt-rk.com Received: from mx2.rt-rk.com (HELO mail.rt-rk.com) (89.216.37.149) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Oct 2017 14:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.rt-rk.com (Postfix) with ESMTP id B0EED1A49C3; Wed, 25 Oct 2017 16:15:00 +0200 (CEST) Received: from [10.10.13.94] (djole.domain.local [10.10.13.94]) by mail.rt-rk.com (Postfix) with ESMTPSA id 6A4BF1A49AC; Wed, 25 Oct 2017 16:15:00 +0200 (CEST) Subject: Re: [PATCH 0/3] Fix issues with writing Linux core PRSTATUS note on MIPS o32, n32 and n64 into core file To: "Maciej W. Rozycki" Cc: binutils@sourceware.org, gdb-patches@sourceware.org, "nemanja.popov@rt-rk.com" , petar.jovanovic@rt-rk.com, "Ananthakrishna Sowda (asowda)" , Nikola Prica , Pedro Alves References: <74618d56-fa31-4cfe-329f-6a9078bac92b@rt-rk.com> From: Djordje Todorovic Message-ID: <724f0bc9-6744-a915-d19d-77db7e9ce514@rt-rk.com> Date: Wed, 25 Oct 2017 14:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-10/txt/msg00767.txt.bz2 Hi Maciej, Please notice that I have reformatted patches 1/3 and 3/3, according your c= omments, and also tweaked a little bit patch 3/3. Regarding patch 3/3, as Pedro said, currently =E2=80=9Cthread=E2=80=9D func= tion has a piece of code that is never going to be executed since core file= is going to be generated as soon as the first thread reaches the thread fu= nction. So, since we are testing fetching value of TLS variable from core = file, creating just a one thread in test case would be enough and regarding= that, I have cut unnecessary code from the function. Thanks, Djordje