From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NYYaAVp8vGE4CQAAWB0awg (envelope-from ) for ; Fri, 17 Dec 2021 07:02:34 -0500 Received: by simark.ca (Postfix, from userid 112) id E6FA21F0CE; Fri, 17 Dec 2021 07:02:33 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7233E1F0B9 for ; Fri, 17 Dec 2021 07:02:33 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C43E385802B for ; Fri, 17 Dec 2021 12:02:33 +0000 (GMT) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by sourceware.org (Postfix) with ESMTPS id 83225385842C for ; Fri, 17 Dec 2021 12:00:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 83225385842C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f50.google.com with SMTP id a83-20020a1c9856000000b00344731e044bso1417896wme.1 for ; Fri, 17 Dec 2021 04:00:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=46Qv76tSSTTr7LqRN5Ka0uW0D4ZVQMXzh9v0pnp6gDM=; b=Z7uyX3Av3OVln+p4Dq9GpJted1bzmEY+IS7uofwUv8eADM1ieX8Y9QGp7PSY6wN5rU U5Zp3O7aFIIDytLIjFNBpewcLMdE8zPIt5R4FIQvJjQK8kkRxiXpcYpgwNSlRiFNt2Wf 3rn6vbvfMzhmoY64QxF68V8ka0VyGtsF56yhY5kLA5xiMzH8w2mq2JGYsUtgALFpJUos o2o4hAR28Av+toF2RNa34Su9AKEpFE4MlqL4K4yEBV/aVzuhqD1y3A85YOU7BsKyfFhw jJMaUUVGlTDSxwsz6IF9kFwf04CW8mzqMr1mqa1DHcI3wQIfoPGfQbvUofyU7dfA1yOv HZqA== X-Gm-Message-State: AOAM532PgjrZE9ckl93oXvgg+7CYYAm/5+/NmqCDgna5t6/lKds4+cFG 3046cH729vEn0wA9xvGtoUA= X-Google-Smtp-Source: ABdhPJysu5algQ5odgmmSORGBXrLsx+PF0piViouswWITYUJ8iAMSAmbh8dXiL2T5dULBzuHyvwtWw== X-Received: by 2002:a7b:cf28:: with SMTP id m8mr9280185wmg.175.1639742413504; Fri, 17 Dec 2021 04:00:13 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:fb57:3faf:e98:b979? ([2001:8a0:f912:1a00:fb57:3faf:e98:b979]) by smtp.gmail.com with ESMTPSA id j17sm9766580wmq.41.2021.12.17.04.00.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 04:00:12 -0800 (PST) Message-ID: <7215513a-08c4-0f91-1924-c5cc928081b8@palves.net> Date: Fri, 17 Dec 2021 12:00:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 22/29] gdb/testsuite: Remove duplicates from gdb.base/funcargs.exp Content-Language: en-US To: Lancelot SIX References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-23-lsix@lancelotsix.com> <8cddbea1-6388-f2c0-f751-9af6b40f8273@palves.net> <20211216230831.gzisliwejevx3tzi@Plymouth> From: Pedro Alves In-Reply-To: <20211216230831.gzisliwejevx3tzi@Plymouth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-12-16 23:08, Lancelot SIX wrote: > On Fri, Dec 10, 2021 at 11:26:23PM +0000, Pedro Alves wrote: >> On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote: >>> --- a/gdb/testsuite/gdb.base/funcargs.exp >>> +++ b/gdb/testsuite/gdb.base/funcargs.exp >>> @@ -213,7 +213,7 @@ proc complex_args {} { >>> >>> # Run; should stop at call1a and print actual arguments. >>> gdb_run_cmd >>> - gdb_test "" " callca \\(f1=1 \\+ 2i, f2=1 \\+ 2i, f3=1 \\+ 2i\\) .*" "run to call2a" >>> + gdb_test "" " callca \\(f1=1 \\+ 2i, f2=1 \\+ 2i, f3=1 \\+ 2i\\) .*" "run to call2a (complex_arg)" >> >> No tail parens, please. See: >> >> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages > > Sorry, I did forget about this. > > I have changed the way I refactor this code. Mode of the tests are > already grouped into procs, so I replace plain procs with > proc_with_prefix. It also makes it easier to find the problematic > portion of the file when a FAIL pop up. I like it, thanks. This is OK.