From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113052 invoked by alias); 8 Dec 2017 10:47:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113035 invoked by uid 89); 8 Dec 2017 10:47:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 10:47:52 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5024B5FD71 for ; Fri, 8 Dec 2017 10:47:51 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 41D4760BEC; Fri, 8 Dec 2017 10:47:48 +0000 (UTC) Subject: Re: [RFA] Adjust gdb.arch/i386-sse-stack-align.exp print statement To: Sergio Durigan Junior , GDB Patches References: <1499959929-29497-9-git-send-email-palves@redhat.com> <20171207233015.18656-1-sergiodj@redhat.com> From: Pedro Alves Message-ID: <71f1cec5-d299-6b08-4189-84f35e18fc4c@redhat.com> Date: Fri, 08 Dec 2017 10:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171207233015.18656-1-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00163.txt.bz2 On 12/07/2017 11:30 PM, Sergio Durigan Junior wrote: > > commit 46a4882b3c7d9ec981568b8b13a3c9c39c8f8e61 > Author: Pedro Alves > Date: Mon Sep 4 20:21:15 2017 +0100 > > Stop assuming no-debug-info variables have type int > > We now have to explicitly tell GDB the type of the non-debug-info > variable we want to print (by casting). This commit adjusts the > "print" statement on gdb.arch/i386-sse-stack-align.exp to do the > proper cast, fixing a failure that started to happen after the > mentioned commit. > > gdb/testsuite/ChangeLog: > 2017-12-07 Sergio Durigan Junior > > * gdb.arch/i386-sse-stack-align.exp: Cast "print" variable to > "int". This is OK, except... > --- > gdb/testsuite/ChangeLog | 5 +++++ > gdb/testsuite/gdb.arch/i386-sse-stack-align.exp | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index 53f114aa15..81d23d1bb1 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,8 @@ > +2017-12-07 Sergio Durigan Junior > + > + * gdb.arch/i386-sse-stack-align.exp: Cast "print" variable to > + "int". > + > 2017-12-07 Keith Seitz > > * gdb.cp/nested-types.cc: New file. > diff --git a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp > index 47fb9f42d2..946f217ce1 100644 > --- a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp > +++ b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp > @@ -43,7 +43,7 @@ if ![runto_main] then { > > set args "" > foreach i {0 1 2 3 4} { > - set test "print g$i ($args)" > + set test "print (int) g$i ($args)" ... this is printing/calling a function, not a variable: (gdb) print g0 () 'g0' has unknown return type; cast the call to its declared return type So the git log and ChangeLog are inaccurate and should reference 7022349d5c86 ("Stop assuming no-debug-info functions return int") instead. OK with that fixed. Thanks, Pedro Alves