From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ifKOMgMvaWmqGwUAWB0awg (envelope-from ) for ; Thu, 15 Jan 2026 13:16:35 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d56bxfX1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C86DC1E0E1; Thu, 15 Jan 2026 13:16:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5F4B01E070 for ; Thu, 15 Jan 2026 13:16:35 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E2EA74BA2E25 for ; Thu, 15 Jan 2026 18:16:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2EA74BA2E25 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d56bxfX1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 600694BA2E34 for ; Thu, 15 Jan 2026 18:16:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 600694BA2E34 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 600694BA2E34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768500969; cv=none; b=A+Smx1RxP+9A30+YHJqaK/WxhvJ5MGvxqC5OQgfoORg2uLpLA868owMRKvrLl32ANbjk3mTcwWFqHNkc0SbWgFQfNeJ5fkjYWJR2QZX43O1V0c9qxnZ+qwBvzd9a6b3IILBPzlSXopNPXHOscrYifjsPGZKxhAtW2wWpCTH5oSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768500969; c=relaxed/simple; bh=G2r4D1ACQZvsACXPLgWDy9Vq6NN1vIbrVuaUs1LFmc8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=CYPZl05ltkctRclscfSJmli4iSUwzrCins/1NSrhhHhWBMwzlOtgRT/lDs9X4B6B6d0ies+3njCuBDAVFuDtsXzEixt3PZ3VlcMGZkH+BqnMec74Ql5iGyy4XwzkdfZo4uorWpYTKWq90jHFRpUZ/F24XgYTv6JJTk5IHi34lOo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 600694BA2E34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768500969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PQQ8GDuKc3lpZqd7cn+cQb6bZzOzU+9WZ17W2JoDzFM=; b=d56bxfX1jFVKqRSoJtyKqfq8AtDbuMsoNy6oeWkJ82Dpr3+qx8guvav0TpqYt+sBzb+Iqe 5oKOkQcHYKd5bvHdN+x+g3952Rfqvt1plDIaiJL7U8EjxsSAEXOVcSNi895vcskdbhMs5m BVWimW3rxF5rMfE2GSCcOA/ewjat9r8= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-71KVuKaIOOGITHcWpuTN7Q-1; Thu, 15 Jan 2026 13:16:06 -0500 X-MC-Unique: 71KVuKaIOOGITHcWpuTN7Q-1 X-Mimecast-MFC-AGG-ID: 71KVuKaIOOGITHcWpuTN7Q_1768500966 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-88a3929171bso27050096d6.3 for ; Thu, 15 Jan 2026 10:16:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768500965; x=1769105765; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PQQ8GDuKc3lpZqd7cn+cQb6bZzOzU+9WZ17W2JoDzFM=; b=f3m1ThcKZzss9n2r8If4CQFvdNcuxKQIEQRTQA6aI0upyYUuBBrAFojVZBoiM18Yq6 Fm3GpHK0NqL0VujxFTgB4OQm67gyq+0CaaICDOGGdvlWSa7mJOIxXghdIq5hYWuWrGkV Wq/JXbAGpOk8+fyq7xB8I+oxg8qD5C7q0OFFrNU0C6t3HJ/V4mf3DQZ6Jrn+ZqqUpkCB dqQ64Ri5X0Wyn/gXsRbWA8WevAz3gzeiV2fINaWJeT923HewprTc0eQHJGANoroXL9Z+ qWItvzmC/L5/XISUOGCezR+wcv1z7i80aKk+vuqjcKxT5RzjkDOT5Rx+YTzFQcOtmaDP K/7A== X-Forwarded-Encrypted: i=1; AJvYcCXxp+OW01KjN3BGFmh9uSTbfQYvV0diKpTHrv6vAsiloC9lKLoeZPf3/LHkgE4tTUmP8Uz1RccUZsUhWw==@sourceware.org X-Gm-Message-State: AOJu0YwX1Obb4pZ59Bamf299UO3P/nJU6UL3YPsPTXfEtFA+7tMxZNHg 5EAK8ORnCyXly3LIS+cEHfyGLC9uBoeqEjOnYe2sexZt0BsEKPty64q5eKpMh2QAkQKOK4pzYSz dxQ0p/AFTrrN9EVwPl/LCNyrd4VUktH6JhrsB8vKl8AXn3WnUSGShNm+jL7YHd6AaxDOonR4= X-Gm-Gg: AY/fxX6n8MvnAoumN7nPX0cDlqwHVfJkPrCibOYo6QUYkoQjazgbxSROWOIIytxLnCa A/E2Lxs/tAzfNNzz+/l21rgGxpfYgLmmrQxj9Ko9o+q2yvXCbDlBvzwObI5l5PsIHLkDyfPQrR6 JFeN61XhqZ2oQHtDi36TSWQndUBKXRTzLsGt0dTvUKPfmAJ6pWAhFxm7RlB2+qYKXh3eUxFLghm I+P9D5z25JZ2q2YF9NIYdofNhTwL0uWO0jnXjZeu2kUCrIcp6hXqYyIbdNOmVKYeD5E+Bdbs7XX JYI8FOyOtTxidZygQrj8p4YaSwQzmDrEmZAqmRgHuSV5fQLhGYanslT6o1jJmKOvPbMklkHto6w ukS0VkyEvYTxborhg1VHPGg== X-Received: by 2002:ad4:5f0c:0:b0:882:5078:8da1 with SMTP id 6a1803df08f44-8942ddbbb5amr4403356d6.64.1768500965218; Thu, 15 Jan 2026 10:16:05 -0800 (PST) X-Received: by 2002:ad4:5f0c:0:b0:882:5078:8da1 with SMTP id 6a1803df08f44-8942ddbbb5amr4402826d6.64.1768500964659; Thu, 15 Jan 2026 10:16:04 -0800 (PST) Received: from ?IPV6:2804:14d:8084:a5b1::1001? ([2804:14d:8084:a5b1::1001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8942e5e49b4sm1321806d6.8.2026.01.15.10.16.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jan 2026 10:16:04 -0800 (PST) Message-ID: <71d9340d-e7a8-45e3-99f6-d0ec02cb2d23@redhat.com> Date: Thu, 15 Jan 2026 15:16:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] More uses of make_unique_xstrdup To: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org References: <20260115-xstrdup-v1-0-72e13ba99851@adacore.com> <3bf1b983-e7c6-4d76-8c87-9a0d3523d8b3@redhat.com> <9d7acb9f-9dad-45fe-8ea9-8793e8177264@simark.ca> From: Guinevere Larsen In-Reply-To: <9d7acb9f-9dad-45fe-8ea9-8793e8177264@simark.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: i6zysf0JVkyxc5--E9If37IGDO8zVjOGktPCHrXCdlY_1768500966 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/15/26 3:01 PM, Simon Marchi wrote: > On 1/15/26 12:39 PM, Guinevere Larsen wrote: >> On 1/15/26 2:33 PM, Tom Tromey wrote: >>> This replaces some uses of '.reset(xstrdup())' with >>> '= make_unique_xstrdup()'. I think explicit uses of reset >>> should be avoided when possible. >>> >>> Regression tested on x86-64 Fedora 41. >>> >>> Signed-off-by: Tom Tromey >> This makes me wonder... is there any reason to prefer xmalloc/xstrdup instead of using std::string? >> >> My preference is to use stdlib stuff when possible, but maybe I'm misjudging the size of the refactor or there's a reason to prefer the current memory strategy. > When practical to switch to std::string, it typically is an improvement. > It makes strings manipulation safer and clearer. There might be cases > where it is not trivial to use std::string immediately though, so > switching to make_unique_xstrdup is a good incremental change > nonetheless. > > Simon > Right that makes sense. I was moreso double-checking my gut feeling, rather than asserting that the series should convert to std::string -- Cheers, Guinevere Larsen It/she